backward compatible with ListenableFilter#5623
Merged
chickenlj merged 1 commit intoapache:masterfrom Jan 10, 2020
Merged
Conversation
RojerAlone
reviewed
Jan 10, 2020
|
|
||
| void onError(Throwable t, Invoker<?> invoker, Invocation invocation); | ||
| } | ||
| interface Listener2 { |
Contributor
There was a problem hiding this comment.
I think keep two methods in Listener is better:
interface Listener {
@Deprecated
void onResponse(Result appResponse, Invoker<?> invoker, Invocation invocation);
default void onMessage(Result appResponse, Invoker<?> invoker, Invocation invocation) {
onResponse(appResponse, invoker, invocation);
}
void onError(Throwable t, Invoker<?> invoker, Invocation invocation);
}
Then call the onMessage method in ProtocolFilterWrapper, so user can implement eithor onMessage or onResponse method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5619
This pr is to fix the bug that is not compatible with the previous listenable filter in version 2.7.5, but if this pr is used, it will not be compatible with the filter created by the listener declared in 2.7.5. I think this should be regarded as an urgent bug-fix.
@chickenlj What do you think? Is there any other way to solve this problem perfectly?