Skip to content

optimize #5623 : optimize compatible solution of filter listener#5639

Closed
RojerAlone wants to merge 1 commit intoapache:masterfrom
RojerAlone:master
Closed

optimize #5623 : optimize compatible solution of filter listener#5639
RojerAlone wants to merge 1 commit intoapache:masterfrom
RojerAlone:master

Conversation

@RojerAlone
Copy link
Copy Markdown
Contributor

@RojerAlone RojerAlone commented Jan 12, 2020

What is the purpose of the change

optimize #5623

@RojerAlone
Copy link
Copy Markdown
Contributor Author

RojerAlone commented Jan 12, 2020

@chickenlj

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 12, 2020

Codecov Report

Merging #5639 into master will decrease coverage by 0.09%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #5639     +/-   ##
===========================================
- Coverage     61.25%   61.16%   -0.1%     
+ Complexity      423      421      -2     
===========================================
  Files           922      922             
  Lines         37498    37498             
  Branches       5431     5431             
===========================================
- Hits          22968    22934     -34     
- Misses        12055    12075     +20     
- Partials       2475     2489     +14
Impacted Files Coverage Δ Complexity Δ
...api/src/main/java/org/apache/dubbo/rpc/Filter.java 0% <0%> (-100%) 0 <0> (ø)
...rg/apache/dubbo/monitor/support/MonitorFilter.java 67.34% <100%> (ø) 0 <0> (ø) ⬇️
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 17.2% <100%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 87.23% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 91.66% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 43.47% <100%> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 65.21% <100%> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 54.54% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/TimeoutFilter.java 58.33% <100%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/GenericImplFilter.java 57.44% <100%> (ø) 0 <0> (ø) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63809bf...a1f384c. Read the comment docs.

@jasonjoo2010 jasonjoo2010 mentioned this pull request Jan 15, 2020
Closed
@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Jan 17, 2020

I would suggest removing onMessage completely in the next version.

2.7.5 is not a stable version in our release plan, as stated here.

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Jan 17, 2020

#5669

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Jan 17, 2020

Also, we need to remove the default implementation of onResponse once onMessage gets removed.

@RojerAlone
Copy link
Copy Markdown
Contributor Author

RojerAlone commented Jan 19, 2020

I would suggest removing onMessage completely in the next version.

The onMessage method was added in 2.7.5, the change means to rename onResponse method, why removing it ?

Also, we need to remove the default implementation of onResponse once onMessage gets removed.

Got it, the target of this pr is to keep compatible with 2.7.5, and I add a TODO on onMessage method about changing it to non-default .

@chickenlj chickenlj mentioned this pull request Feb 11, 2020
Merged
@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Feb 11, 2020

#5731

@chickenlj chickenlj closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RojerAlone @codecov-io @chickenlj