fix number type is lost in yaml config file#1401
Merged
beiwei30 merged 3 commits intoapache:masterfrom Feb 27, 2018
lovepoem:fix_number_type_is_lost_in_yaml_config_file
Merged
fix number type is lost in yaml config file#1401beiwei30 merged 3 commits intoapache:masterfrom lovepoem:fix_number_type_is_lost_in_yaml_config_file
beiwei30 merged 3 commits intoapache:masterfrom
lovepoem:fix_number_type_is_lost_in_yaml_config_file
Conversation
…pe_is_lost_in_yaml_config_file
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
==========================================
+ Coverage 32.96% 32.99% +0.03%
==========================================
Files 691 691
Lines 34625 34624 -1
Branches 6851 6850 -1
==========================================
+ Hits 11414 11425 +11
+ Misses 21264 21254 -10
+ Partials 1947 1945 -2
Continue to review full report at Codecov.
|
zonghaishang
pushed a commit
to zonghaishang/dubbo
that referenced
this pull request
Mar 2, 2018
* @reference support annotate on annotation type * Fixes apache#1303 TimeUnit conversion error * Fixes apache#1289, use bind_port as mapping key * Fixes apache#1313, remove destroy check in Registry. * checkout .travis.yml from origin/master * Fix hessian2 serialized short, byte is converted to int bug (apache#1232) * Fix hessian2 serialized short, byte is converted to int bug * Fix hessian2 serialized short, byte is converted to int bug * adapt jdk1.5+ * fixed travis-ci failed because of test cases. (apache#1370) * Merge pull request apache#1377, remove redundant arguments for StatItem.isAllowable() * Merge pull request apache#1378, replace StringBuider with simple string concatenation in log. * Merge pull request apache#1375, remove unnecessary boxing. Fixes apache#1245 * Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. * Merge pull request apache#1376, do not instantiate load balance if there is no invokers Fixes apache#1297 * Merge pull request apache#1384, fix build string bug. * Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. * Merge pull request apache#1242, remove redundant null check. fixes apache#1231 * Change Mailing list address * Fixed apache#1398, revert bugs introduced from apache#1375 * Fix time unit problem in UT * Fix time unit problem related with FutureAdapter in UT * Fix time unit problem related with FutureAdapter in UT * Merge pull request apache#1391, fix typo of method name in qos module. * fix hessian lite test case fail bug (apache#1394) * fix hessian lite test case fail bug * update test * remove ignore * Fix time unit problem related with FutureAdapter in UT * revert file * fix number type is lost in yaml config file (apache#1401) * apache#1399 fi * update test * update readme to add some details (apache#1403) * update readme to add some details update readme to add some details * delete duplicated words delete duplicated words * update README format * apache#1411: Locale deserialize 'zh-hant_CN'
This was referenced Mar 2, 2018
xpylq
pushed a commit
to xpylq/dubbo
that referenced
this pull request
Mar 5, 2018
* remotes/upstream/master: (226 commits) clean up imports for CacheTest [Dubbo-apache#1362] cache provider always lru cache (apache#1396) Remove author info and add apache license Fix "promoteTransitiveDependencies=false" of maven-shade-plugin apache#1411: Locale deserialize 'zh-hant_CN' update README format update readme to add some details (apache#1403) fix number type is lost in yaml config file (apache#1401) fix hessian lite test case fail bug (apache#1394) Merge pull request apache#1391, fix typo of method name in qos module. Fix time unit problem related with FutureAdapter in UT Fix time unit problem related with FutureAdapter in UT Fix time unit problem in UT Fixed apache#1398, revert bugs introduced from apache#1375 Change Mailing list address Merge pull request apache#1242, remove redundant null check. Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. Merge pull request apache#1384, fix build string bug. Merge pull request apache#1376, do not instantiate load balance if there is no invokers Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. ...
|
@lovepoem Release 2.5.10 has not this fix, may i know which release would include this fix? as there are many issues about this fix in dubbo-spring-boot-starter project. |
Member
Author
|
https://github.com/alibaba/dubbo/milestone/13 -->v2.6.1 |
Member
Author
|
Now https://github.com/alibaba/dubbo/milestone/13 is released. |
rolandhe
pushed a commit
to rolandhe/dubbo
that referenced
this pull request
Sep 9, 2019
* apache#1399 fi * update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#1399 fix number type is lost in yaml config file
Brief changelog
Remove String type filter when read yaml file data
Verifying this change
Run referenced unit test