Fix build string bug by liketic · Pull Request #1384 · apache/dubbo

liketic · 2018-02-22T09:59:38Z

"Unsupported request: " + message == null ? null : (message.getClass().getName() + ": " + message) will always results (message.getClass().getName() + ": " + message) because + is higher priority than ==.

liketic · 2018-02-22T10:00:08Z

...-rpc/dubbo-rpc-default/src/main/java/com/alibaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java

                    if (!hasMethod) {
-                        logger.warn(new IllegalStateException("The methodName " + inv.getMethodName() + " not found in callback service interface ,invoke will be ignored. please update the api interface. url is:" + invoker.getUrl()) + " ,invocation is :" + inv);
+                        logger.warn(new IllegalStateException("The methodName " + inv.getMethodName() 
+                                + " not found in callback service interface ,invoke will be ignored."


Break a long line.

liketic · 2018-02-22T10:00:21Z

...-rpc/dubbo-rpc-default/src/main/java/com/alibaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java

        public void disconnected(Channel channel) throws RemotingException {
            if (logger.isInfoEnabled()) {
-                logger.info("disconected from " + channel.getRemoteAddress() + ",url:" + channel.getUrl());
+                logger.info("disconnected from " + channel.getRemoteAddress() + ",url:" + channel.getUrl());


Fix a typo.

codecov-io · 2018-02-22T10:18:37Z

Codecov Report

Merging #1384 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   32.37%   32.33%   -0.05%     
==========================================
  Files         691      691              
  Lines       34537    34540       +3     
  Branches     6812     6812              
==========================================
- Hits        11183    11170      -13     
- Misses      21419    21435      +16     
  Partials     1935     1935

Impacted Files	Coverage Δ
...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java	`59.55% <0%> (-0.81%)`	⬇️
...a/dubbo/remoting/transport/netty/NettyChannel.java	`57.5% <0%> (-7.5%)`	⬇️
...libaba/com/caucho/hessian/util/IdentityIntMap.java	`25% <0%> (-5.96%)`	⬇️
...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java	`77.77% <0%> (-5.56%)`	⬇️
...mon/serialize/support/dubbo/GenericDataOutput.java	`64.91% <0%> (-1.41%)`	⬇️
...mmon/serialize/support/dubbo/GenericDataInput.java	`57.91% <0%> (-0.78%)`	⬇️
...ba/dubbo/remoting/transport/netty/NettyServer.java	`71.42% <0%> (+3.57%)`	⬆️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java	`50% <0%> (+8.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582764...aab926a. Read the comment docs.

chickenlj · 2018-02-24T05:59:42Z

"Unsupported request: " + message == null ? null : (message.getClass().getName() + ": " + message) will always results (message.getClass().getName() + ": " + message) because + is higher priority than ==.

Forget commit changes of this part?

liketic · 2018-02-24T06:56:20Z

Thanks @chickenlj . The old code is

"Unsupported request: " + message == null ? null : (message.getClass().getName() + ": " + message)

I added two brackets：

"Unsupported request: " + (message == null ? null : (message.getClass().getName() + ": " + message))

chickenlj · 2018-02-24T07:17:33Z

Thanks for your continuous contributions. BTW, if you want to create a PR that will contain pretty much changes, please follow the Pull Request Template.

liketic · 2018-02-24T07:21:03Z

Thanks @chickenlj , make sense for me.

@reference

* @reference support annotate on annotation type * Fixes apache#1303 TimeUnit conversion error * Fixes apache#1289, use bind_port as mapping key * Fixes apache#1313, remove destroy check in Registry. * checkout .travis.yml from origin/master * Fix hessian2 serialized short, byte is converted to int bug (apache#1232) * Fix hessian2 serialized short, byte is converted to int bug * Fix hessian2 serialized short, byte is converted to int bug * adapt jdk1.5+ * fixed travis-ci failed because of test cases. (apache#1370) * Merge pull request apache#1377, remove redundant arguments for StatItem.isAllowable() * Merge pull request apache#1378, replace StringBuider with simple string concatenation in log. * Merge pull request apache#1375, remove unnecessary boxing. Fixes apache#1245 * Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. * Merge pull request apache#1376, do not instantiate load balance if there is no invokers Fixes apache#1297 * Merge pull request apache#1384, fix build string bug. * Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. * Merge pull request apache#1242, remove redundant null check. fixes apache#1231

@reference

* @reference support annotate on annotation type * Fixes apache#1303 TimeUnit conversion error * Fixes apache#1289, use bind_port as mapping key * Fixes apache#1313, remove destroy check in Registry. * checkout .travis.yml from origin/master * Fix hessian2 serialized short, byte is converted to int bug (apache#1232) * Fix hessian2 serialized short, byte is converted to int bug * Fix hessian2 serialized short, byte is converted to int bug * adapt jdk1.5+ * fixed travis-ci failed because of test cases. (apache#1370) * Merge pull request apache#1377, remove redundant arguments for StatItem.isAllowable() * Merge pull request apache#1378, replace StringBuider with simple string concatenation in log. * Merge pull request apache#1375, remove unnecessary boxing. Fixes apache#1245 * Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. * Merge pull request apache#1376, do not instantiate load balance if there is no invokers Fixes apache#1297 * Merge pull request apache#1384, fix build string bug. * Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. * Merge pull request apache#1242, remove redundant null check. fixes apache#1231 * Change Mailing list address * Fixed apache#1398, revert bugs introduced from apache#1375 * Fix time unit problem in UT * Fix time unit problem related with FutureAdapter in UT

@reference

* @reference support annotate on annotation type * Fixes apache#1303 TimeUnit conversion error * Fixes apache#1289, use bind_port as mapping key * Fixes apache#1313, remove destroy check in Registry. * checkout .travis.yml from origin/master * Fix hessian2 serialized short, byte is converted to int bug (apache#1232) * Fix hessian2 serialized short, byte is converted to int bug * Fix hessian2 serialized short, byte is converted to int bug * adapt jdk1.5+ * fixed travis-ci failed because of test cases. (apache#1370) * Merge pull request apache#1377, remove redundant arguments for StatItem.isAllowable() * Merge pull request apache#1378, replace StringBuider with simple string concatenation in log. * Merge pull request apache#1375, remove unnecessary boxing. Fixes apache#1245 * Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. * Merge pull request apache#1376, do not instantiate load balance if there is no invokers Fixes apache#1297 * Merge pull request apache#1384, fix build string bug. * Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. * Merge pull request apache#1242, remove redundant null check. fixes apache#1231 * Change Mailing list address * Fixed apache#1398, revert bugs introduced from apache#1375 * Fix time unit problem in UT * Fix time unit problem related with FutureAdapter in UT * Fix time unit problem related with FutureAdapter in UT * Merge pull request apache#1391, fix typo of method name in qos module. * fix hessian lite test case fail bug (apache#1394) * fix hessian lite test case fail bug * update test * remove ignore * Fix time unit problem related with FutureAdapter in UT * revert file * fix number type is lost in yaml config file (apache#1401) * apache#1399 fi * update test * update readme to add some details (apache#1403) * update readme to add some details update readme to add some details * delete duplicated words delete duplicated words * update README format * apache#1411: Locale deserialize 'zh-hant_CN'

* remotes/upstream/master: (226 commits) clean up imports for CacheTest [Dubbo-apache#1362] cache provider always lru cache (apache#1396) Remove author info and add apache license Fix "promoteTransitiveDependencies=false" of maven-shade-plugin apache#1411: Locale deserialize 'zh-hant_CN' update README format update readme to add some details (apache#1403) fix number type is lost in yaml config file (apache#1401) fix hessian lite test case fail bug (apache#1394) Merge pull request apache#1391, fix typo of method name in qos module. Fix time unit problem related with FutureAdapter in UT Fix time unit problem related with FutureAdapter in UT Fix time unit problem in UT Fixed apache#1398, revert bugs introduced from apache#1375 Change Mailing list address Merge pull request apache#1242, remove redundant null check. Merge pull request apache#1040, refactor: replace some deprecated methods related with jedis. Merge pull request apache#1384, fix build string bug. Merge pull request apache#1376, do not instantiate load balance if there is no invokers Merge pull request apache#1331, add optional parameter to support hessian protocol method overload and request protocol version. ...

Fix build string bug

aab926a

liketic commented Feb 22, 2018

View reviewed changes

chickenlj merged commit c7170d5 into apache:master Feb 24, 2018

liketic deleted the fix-build-string-bug branch February 24, 2018 07:21

rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019

Merge pull request apache#1384, fix build string bug.

bce2f2b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build string bug#1384

Fix build string bug#1384
chickenlj merged 1 commit intoapache:masterfrom
liketic:fix-build-string-bug

liketic commented Feb 22, 2018 •

edited

Loading

Uh oh!

liketic Feb 22, 2018

Uh oh!

liketic Feb 22, 2018

Uh oh!

codecov-io commented Feb 22, 2018

Uh oh!

chickenlj commented Feb 24, 2018

Uh oh!

liketic commented Feb 24, 2018 •

edited

Loading

Uh oh!

chickenlj commented Feb 24, 2018

Uh oh!

liketic commented Feb 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

liketic commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liketic Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

liketic Feb 22, 2018

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Feb 22, 2018

Codecov Report

Uh oh!

chickenlj commented Feb 24, 2018

Uh oh!

liketic commented Feb 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chickenlj commented Feb 24, 2018

Uh oh!

liketic commented Feb 24, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liketic commented Feb 22, 2018 •

edited

Loading

liketic commented Feb 24, 2018 •

edited

Loading