Skip to content

Allow router to override selection based on config#645

Merged
fjy merged 6 commits intomasterfrom
smarter-router
Jul 23, 2014
Merged

Allow router to override selection based on config#645
fjy merged 6 commits intomasterfrom
smarter-router

Conversation

@fjy
Copy link
Contributor

@fjy fjy commented Jul 22, 2014

No description provided.

fjy added a commit that referenced this pull request Jul 23, 2014
Allow router to override selection based on config
@fjy fjy merged commit 4c6eba9 into master Jul 23, 2014
@fjy fjy deleted the smarter-router branch July 23, 2014 00:10
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Nov 22, 2021
* fix type

* Revert "Fix Keyclock auth integration test based on upstream changes (apache#622)"

This reverts commit c1083fb.

* Bump netty4 to 4.1.68; suppress CVE-2021-37136 and CVE-2021-37137 for netty3 (apache#11844)

* bump netty4 to 4.1.68

* suppress CVE-2021-37136 and CVE-2021-37137 for netty3

* license

* add `prometheus-emitter` to distribution (apache#11812)

* add `prometheus-emitter` to distribution

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* add `druid-momentsketch` to distribution

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* Web console: update typescript 4.4 for faster build speeds (apache#11725)

* update typescript

* do not show pagination when there is only one page

* update snapshots

* fix pagination

* Remove OffheapIncrementalIndex and clarify aggregator thread-safety needs. (apache#11124)

* Remove OffheapIncrementalIndex and clarify aggregator thread-safety needs.

This patch does the following:

- Removes OffheapIncrementalIndex.
- Clarifies that Aggregators are required to be thread safe.
- Clarifies that BufferAggregators and VectorAggregators are not
  required to be thread safe.
- Removes thread safety code from some DataSketches aggregators that
  had it. (Not all of them did, and that's OK, because it wasn't necessary
  anyway.)
- Makes enabling "useOffheap" with groupBy v1 an error.

Rationale for removing the offheap incremental index:

- It is only used in one rare scenario: groupBy v1 (which is non-default)
  in "useOffheap" mode (also non-default). So you have to go pretty deep
  into the wilderness to get this code to activate in production. It is
  never used during ingestion.
- Its existence complicates developer efforts to reason about how
  aggregators get used, because the way it uses buffer aggregators is so
  different from how every other query engine uses them.
- It doesn't have meaningful testing.

By the way, I do believe that the given way the offheap incremental index
works, it actually didn't require buffer aggregators to be thread-safe.
It synchronizes on "aggregate" and doesn't call "get" until it has
stopped calling "aggregate". Nevertheless, this is a bother to think about,
and for the above reasons I think it makes sense to remove the code anyway.

* Remove things that are now unused.

* Revert removal of getFloat, getLong, getDouble from BufferAggregator.

* OAK-related warnings, suppressions.

* Unused item suppressions.

Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com>
Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants