Skip to content

Web console: update typescript 4.4 for faster build speeds#11725

Merged
clintropolis merged 5 commits intoapache:masterfrom
vogievetsky:ts-4.4
Oct 26, 2021
Merged

Web console: update typescript 4.4 for faster build speeds#11725
clintropolis merged 5 commits intoapache:masterfrom
vogievetsky:ts-4.4

Conversation

@vogievetsky
Copy link
Contributor

@vogievetsky vogievetsky commented Sep 20, 2021

Updates to TS4.4 which offers perf improvements to the build speed

The PR also makes sure to hide the pagination controls for all tables if there is only one page to reduce clutter.

Also fixes two small bugs:

  • the customary class was not applied to the refresh button
  • there was an unnecessary namespace. describing how lookup JDBC queries are generated

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

@vogievetsky vogievetsky added Area - Web Console Area - Dev For items related to the project itself, like dev docs and checklists, but not CI labels Sep 20, 2021
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@clintropolis clintropolis merged commit 8ea9309 into apache:master Oct 26, 2021
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Nov 22, 2021
* fix type

* Revert "Fix Keyclock auth integration test based on upstream changes (apache#622)"

This reverts commit c1083fb.

* Bump netty4 to 4.1.68; suppress CVE-2021-37136 and CVE-2021-37137 for netty3 (apache#11844)

* bump netty4 to 4.1.68

* suppress CVE-2021-37136 and CVE-2021-37137 for netty3

* license

* add `prometheus-emitter` to distribution (apache#11812)

* add `prometheus-emitter` to distribution

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* add `druid-momentsketch` to distribution

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* Web console: update typescript 4.4 for faster build speeds (apache#11725)

* update typescript

* do not show pagination when there is only one page

* update snapshots

* fix pagination

* Remove OffheapIncrementalIndex and clarify aggregator thread-safety needs. (apache#11124)

* Remove OffheapIncrementalIndex and clarify aggregator thread-safety needs.

This patch does the following:

- Removes OffheapIncrementalIndex.
- Clarifies that Aggregators are required to be thread safe.
- Clarifies that BufferAggregators and VectorAggregators are not
  required to be thread safe.
- Removes thread safety code from some DataSketches aggregators that
  had it. (Not all of them did, and that's OK, because it wasn't necessary
  anyway.)
- Makes enabling "useOffheap" with groupBy v1 an error.

Rationale for removing the offheap incremental index:

- It is only used in one rare scenario: groupBy v1 (which is non-default)
  in "useOffheap" mode (also non-default). So you have to go pretty deep
  into the wilderness to get this code to activate in production. It is
  never used during ingestion.
- Its existence complicates developer efforts to reason about how
  aggregators get used, because the way it uses buffer aggregators is so
  different from how every other query engine uses them.
- It doesn't have meaningful testing.

By the way, I do believe that the given way the offheap incremental index
works, it actually didn't require buffer aggregators to be thread-safe.
It synchronizes on "aggregate" and doesn't call "get" until it has
stopped calling "aggregate". Nevertheless, this is a bother to think about,
and for the above reasons I think it makes sense to remove the code anyway.

* Remove things that are now unused.

* Revert removal of getFloat, getLong, getDouble from BufferAggregator.

* OAK-related warnings, suppressions.

* Unused item suppressions.

Co-authored-by: Đặng Minh Dũng <dungdm93@live.com>
Co-authored-by: Vadim Ogievetsky <vadim@ogievetsky.com>
Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI Area - Web Console

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants