Skip to content

[refactor](scan) Remove col_name_to_value_range #58283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 3 commits into from
Nov 24, 2025
Merged

[refactor](scan) Remove col_name_to_value_range #58283

Gabriel39 merged 3 commits into from
Nov 24, 2025

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 24, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Nov 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

TPC-H: Total hot run time: 34486 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6cd5788ce31938e3e6d865565cfbe0840eafc277, data reload: false

------ Round 1 ----------------------------------
q1	17619	5120	4922	4922
q2	2040	312	213	213
q3	10769	1273	742	742
q4	10252	1010	398	398
q5	7591	2524	2367	2367
q6	196	172	141	141
q7	918	796	633	633
q8	9362	1369	1143	1143
q9	7429	5532	5460	5460
q10	6895	2212	1829	1829
q11	489	307	289	289
q12	348	362	238	238
q13	17770	3667	3001	3001
q14	220	253	211	211
q15	584	502	503	502
q16	1010	995	950	950
q17	602	860	352	352
q18	7391	7185	7000	7000
q19	1438	951	553	553
q20	355	339	223	223
q21	3708	2617	2360	2360
q22	1025	976	959	959
Total cold run time: 108011 ms
Total hot run time: 34486 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5060	4962	4876	4876
q2	328	375	320	320
q3	2200	2675	2326	2326
q4	1364	1747	1348	1348
q5	4213	4514	4554	4514
q6	210	169	129	129
q7	1993	1978	1788	1788
q8	2604	2669	2531	2531
q9	7661	7608	7525	7525
q10	3021	3270	2837	2837
q11	621	547	521	521
q12	729	790	626	626
q13	3599	3913	3313	3313
q14	290	308	282	282
q15	548	503	501	501
q16	1141	1088	1074	1074
q17	1172	1557	1412	1412
q18	7991	7626	7426	7426
q19	771	807	876	807
q20	1908	1977	1827	1827
q21	4700	4421	4267	4267
q22	1079	1019	994	994
Total cold run time: 53203 ms
Total hot run time: 51244 ms

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

TPC-DS: Total hot run time: 187448 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6cd5788ce31938e3e6d865565cfbe0840eafc277, data reload: false

query1	1026	429	392	392
query2	6555	1643	1666	1643
query3	6750	229	219	219
query4	26640	23213	22857	22857
query5	4459	621	476	476
query6	341	260	236	236
query7	4655	501	303	303
query8	304	269	271	269
query9	8725	2629	2617	2617
query10	498	367	295	295
query11	15605	15060	15023	15023
query12	171	120	112	112
query13	1686	585	465	465
query14	10894	9468	9330	9330
query15	201	186	175	175
query16	7589	685	544	544
query17	1254	786	651	651
query18	2033	429	330	330
query19	209	213	179	179
query20	128	126	125	125
query21	223	137	116	116
query22	4078	4058	4038	4038
query23	33782	32949	33161	32949
query24	8505	2384	2414	2384
query25	665	552	468	468
query26	1244	281	169	169
query27	2751	511	361	361
query28	4432	2238	2200	2200
query29	827	626	520	520
query30	303	224	198	198
query31	932	814	722	722
query32	88	80	79	79
query33	598	400	338	338
query34	780	860	576	576
query35	796	822	731	731
query36	948	990	885	885
query37	120	110	89	89
query38	3410	3461	3397	3397
query39	1545	1409	1418	1409
query40	222	125	116	116
query41	63	59	62	59
query42	123	111	116	111
query43	481	494	456	456
query44	1247	763	781	763
query45	184	177	176	176
query46	887	993	641	641
query47	1754	1779	1718	1718
query48	391	423	324	324
query49	771	511	382	382
query50	654	680	421	421
query51	3863	3896	3848	3848
query52	110	114	103	103
query53	248	269	196	196
query54	307	294	274	274
query55	87	87	87	87
query56	318	366	311	311
query57	1174	1179	1104	1104
query58	292	268	271	268
query59	2519	2593	2447	2447
query60	342	349	341	341
query61	171	161	157	157
query62	772	738	681	681
query63	222	198	195	195
query64	4471	1167	855	855
query65	4046	3909	3928	3909
query66	1115	447	340	340
query67	15192	15063	14794	14794
query68	8265	905	644	644
query69	487	319	285	285
query70	1321	1283	1307	1283
query71	469	333	312	312
query72	6091	4922	4955	4922
query73	686	607	375	375
query74	9075	8947	9032	8947
query75	3913	3287	2814	2814
query76	3785	1172	742	742
query77	819	436	315	315
query78	9629	9713	8783	8783
query79	2063	807	611	611
query80	655	587	490	490
query81	489	256	226	226
query82	483	156	137	137
query83	266	261	256	256
query84	254	110	97	97
query85	931	486	436	436
query86	398	333	298	298
query87	3665	3732	3573	3573
query88	3642	2263	2249	2249
query89	386	320	304	304
query90	1974	226	230	226
query91	182	170	140	140
query92	86	71	66	66
query93	1796	1034	684	684
query94	681	462	356	356
query95	408	311	315	311
query96	492	570	276	276
query97	2897	2956	2872	2872
query98	243	208	207	207
query99	1324	1405	1264	1264
Total cold run time: 275631 ms
Total hot run time: 187448 ms

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

ClickBench: Total hot run time: 27.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6cd5788ce31938e3e6d865565cfbe0840eafc277, data reload: false

query1	0.06	0.05	0.05
query2	0.08	0.05	0.05
query3	0.26	0.08	0.08
query4	1.61	0.11	0.10
query5	0.26	0.26	0.24
query6	1.20	0.64	0.64
query7	0.03	0.03	0.02
query8	0.06	0.04	0.04
query9	0.58	0.53	0.51
query10	0.56	0.57	0.57
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.62	0.60	0.61
query14	1.00	1.00	1.00
query15	0.86	0.83	0.84
query16	0.39	0.38	0.40
query17	1.02	1.01	1.07
query18	0.22	0.20	0.20
query19	1.89	1.78	1.79
query20	0.02	0.01	0.01
query21	15.44	0.19	0.14
query22	5.02	0.07	0.05
query23	15.67	0.27	0.10
query24	2.64	0.72	0.80
query25	0.07	0.07	0.06
query26	0.14	0.15	0.14
query27	0.06	0.06	0.05
query28	5.00	1.15	0.94
query29	12.56	3.84	3.22
query30	0.29	0.14	0.12
query31	2.82	0.58	0.39
query32	3.23	0.54	0.47
query33	2.96	3.13	3.07
query34	15.86	5.14	4.56
query35	4.57	4.62	4.55
query36	0.66	0.51	0.49
query37	0.10	0.07	0.07
query38	0.06	0.05	0.04
query39	0.03	0.04	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.55 s
Total hot run time: 27.77 s

@doris-robot
Copy link

doris-robot commented Nov 24, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/26) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.63% (18278/34730)
Line Coverage 38.06% (166300/436934)
Region Coverage 33.02% (129293/391595)
Branch Coverage 33.81% (55478/164088)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 3.85% (1/26) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.58% (24402/34089)
Line Coverage 58.06% (253779/437107)
Region Coverage 53.41% (211989/396912)
Branch Coverage 54.74% (90378/165099)

@Gabriel39 Gabriel39 merged commit 8f3cece into apache:master Nov 24, 2025
26 of 28 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@Gabriel39 @nagisa-kunhah
[refactor](scan) Remove col_name_to_value_range (apache#58283)
667cf57
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Jan 13, 2026
@Gabriel39
[refactor](scan) Remove col_name_to_value_range (apache#58283)
e271b7e
@Gabriel39 Gabriel39 mentioned this pull request Jan 13, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 14, 2026
@Gabriel39
[branch-4.0]Pick predicates-related PR (#59804)
0174967 
### What problem does this PR solve?

pick #57397 #58283 #58290 #58282 #58832 #58905 #58960 #59005 #59088
#59098 #59126 #59187 #59581 #59625 #59775

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Gabriel39 @Thearas @doris-robot @hello-stephen @Mryange @zhangstar333 @yiguolei