Skip to content

[minor](refactor) rename parquet predicate #57397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gabriel39 merged 1 commit into from
Oct 29, 2025
Merged

[minor](refactor) rename parquet predicate #57397

Gabriel39 merged 1 commit into from
Oct 29, 2025

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Oct 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 28, 2025

ClickBench: Total hot run time: 27.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf1e99b060a11042b7ec92fd7941b64e57c3b94e, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.26	0.25
query6	1.19	0.68	0.66
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.65	0.53	0.52
query10	0.60	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.13
query13	0.62	0.61	0.61
query14	1.04	1.02	1.00
query15	0.85	0.84	0.86
query16	0.40	0.41	0.40
query17	1.03	1.01	1.04
query18	0.22	0.20	0.21
query19	1.98	1.78	1.78
query20	0.01	0.01	0.02
query21	15.45	0.19	0.13
query22	5.08	0.07	0.05
query23	15.66	0.27	0.10
query24	2.53	0.71	0.47
query25	0.08	0.05	0.08
query26	0.16	0.14	0.14
query27	0.07	0.05	0.05
query28	4.64	1.15	0.93
query29	12.61	3.98	3.32
query30	0.29	0.14	0.11
query31	2.82	0.62	0.39
query32	3.22	0.55	0.49
query33	3.11	3.04	3.05
query34	16.01	5.18	4.54
query35	4.58	4.65	4.58
query36	0.67	0.51	0.50
query37	0.11	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.13
query41	0.09	0.04	0.04
query42	0.04	0.04	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.81 s
Total hot run time: 27.72 s

@doris-robot
Copy link

doris-robot commented Oct 28, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.76% (18055/34221)
Line Coverage 37.99% (163688/430865)
Region Coverage 32.36% (124744/385456)
Branch Coverage 33.73% (54550/161713)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.28% (24231/33526)
Line Coverage 59.10% (254519/430666)
Region Coverage 55.11% (215004/390171)
Branch Coverage 56.36% (91579/162486)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit b59f03e into apache:master Oct 29, 2025
27 of 29 checks passed
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
@Gabriel39 @dwdwqfwe
[minor](refactor) rename parquet predicate (apache#57397)
0290697
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Jan 13, 2026
@Gabriel39
[minor](refactor) rename parquet predicate (apache#57397)
e5085f3
@Gabriel39 Gabriel39 mentioned this pull request Jan 13, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 14, 2026
@Gabriel39
[branch-4.0]Pick predicates-related PR (#59804)
0174967 
### What problem does this PR solve?

pick #57397 #58283 #58290 #58282 #58832 #58905 #58960 #59005 #59088
#59098 #59126 #59187 #59581 #59625 #59775

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gabriel39 @hello-stephen @doris-robot @Mryange @zhangstar333 @yiguolei