Skip to content

[fix](parquet) incorrect skip files when returning eof #57071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Oct 20, 2025
Merged

[fix](parquet) incorrect skip files when returning eof #57071

morningman merged 1 commit into from
Oct 20, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 16, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Introduced from topn optimization.
When opening a parquet reader, all row group may be filtered and the open method will return EOF,
we should handle this kind of return value separately and continue opening other files.
Otherwise, the rest of files may be wrongly skipped and the result is incorrect.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Oct 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 30.72 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bda69a506da79774ac77a113577bc1771ab45be5, data reload: false

query1	0.06	0.04	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.27	0.27	0.25
query6	1.20	0.66	0.64
query7	0.04	0.03	0.02
query8	0.06	0.04	0.05
query9	0.63	0.53	0.52
query10	0.59	0.57	0.58
query11	0.19	0.12	0.12
query12	0.16	0.12	0.12
query13	0.64	0.61	0.62
query14	1.02	1.04	1.03
query15	0.85	0.85	0.85
query16	0.42	0.42	0.40
query17	1.08	1.01	1.04
query18	0.22	0.20	0.20
query19	1.97	1.81	1.80
query20	0.02	0.01	0.02
query21	15.56	0.90	0.58
query22	0.75	1.16	0.70
query23	14.90	1.43	0.67
query24	7.10	1.23	0.96
query25	0.53	0.14	0.15
query26	0.61	0.17	0.13
query27	0.07	0.07	0.05
query28	10.07	1.39	0.94
query29	12.55	3.94	3.38
query30	0.30	0.13	0.11
query31	2.82	0.61	0.37
query32	3.23	0.58	0.49
query33	3.17	3.13	3.07
query34	16.14	5.46	4.84
query35	4.92	4.92	4.92
query36	0.70	0.53	0.50
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.17	0.15	0.15
query41	0.08	0.04	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 105.33 s
Total hot run time: 30.72 s

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

BE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.55% (17819/33910)
Line Coverage 37.75% (161926/428950)
Region Coverage 32.25% (123659/383474)
Branch Coverage 33.61% (54224/161316)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

BE Regression && UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.21% (23678/33249)
Line Coverage 57.64% (247117/428708)
Region Coverage 52.76% (204940/388438)
Branch Coverage 54.56% (88506/162211)

hubgeter
hubgeter approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@hubgeter hubgeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

PR approved by at least one committer and no changes requested.

kaka11chen
kaka11chen approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 04e333b into apache:master Oct 20, 2025
37 of 40 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 20, 2025
@morningman
[fix](parquet) incorrect skip files when returning eof (#57071)
2c4d21c 
### What problem does this PR solve?

Problem Summary:

Introduced from topn optimization.
When opening a parquet reader, all row group may be filtered and the
open method will return EOF,
we should handle this kind of return value separately and continue
opening other files.
Otherwise, the rest of files may be wrongly skipped and the result is
incorrect.
@github-actions github-actions bot mentioned this pull request Oct 20, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 22, 2025
@github-actions @morningman
branch-4.0: [fix](parquet) incorrect skip files when returning eof #5…
ca8c3a5 
…7071 (#57157)

Cherry-picked from #57071

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

+2 more reviewers

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@morningman @hello-stephen @doris-robot @kaka11chen @CalvinKirs @suxiaogang223 @hubgeter @yiguolei