Skip to content

branch-4.0: [fix](parquet) incorrect skip files when returning eof #57071 #57157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 22, 2025
Merged

branch-4.0: [fix](parquet) incorrect skip files when returning eof #57071 #57157

yiguolei merged 1 commit into from
Oct 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 20, 2025

Cherry-picked from #57071

@morningman
[fix](parquet) incorrect skip files when returning eof (#57071)
2c4d21c 
### What problem does this PR solve?

Problem Summary:

Introduced from topn optimization.
When opening a parquet reader, all row group may be filtered and the
open method will return EOF,
we should handle this kind of return value separately and continue
opening other files.
Otherwise, the rest of files may be wrongly skipped and the result is
incorrect.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 20, 2025 08:04
@Thearas
Copy link
Contributor

Thearas commented Oct 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 20, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 20, 2025

run buildall

1 similar comment
@yiguolei
Copy link
Contributor

yiguolei commented Oct 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 20, 2025

ClickBench: Total hot run time: 30.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2c4d21c3791d8a98bc37cb67157602222e301077, data reload: true

query1	0.03	0.03	0.03
query2	0.11	0.04	0.04
query3	0.25	0.07	0.07
query4	1.65	0.11	0.11
query5	0.27	0.26	0.26
query6	1.17	0.64	0.64
query7	0.03	0.02	0.02
query8	0.07	0.03	0.04
query9	0.63	0.53	0.52
query10	0.58	0.58	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.64	0.63	0.61
query14	0.80	0.82	0.82
query15	0.88	0.89	0.86
query16	0.39	0.42	0.40
query17	1.11	1.08	1.08
query18	0.18	0.18	0.18
query19	1.86	1.82	1.79
query20	0.02	0.01	0.01
query21	15.40	0.97	0.59
query22	0.79	1.39	0.77
query23	14.79	1.37	0.64
query24	16.31	0.54	0.31
query25	0.27	0.12	0.11
query26	0.39	0.15	0.12
query27	0.07	0.04	0.04
query28	9.11	0.98	0.92
query29	12.58	3.91	3.20
query30	0.30	0.12	0.11
query31	2.87	0.62	0.39
query32	3.27	0.56	0.47
query33	3.30	3.40	3.22
query34	17.38	5.78	5.05
query35	5.23	5.12	5.09
query36	0.75	0.55	0.54
query37	0.11	0.07	0.07
query38	0.10	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 114.39 s
Total hot run time: 30.21 s

@yiguolei yiguolei closed this Oct 21, 2025
@yiguolei yiguolei reopened this Oct 21, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 22, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit ca8c3a5 into branch-4.0 Oct 22, 2025
33 of 40 checks passed
@github-actions github-actions bot deleted the auto-pick-57071-branch-4.0 branch October 22, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @yiguolei @doris-robot @dataroaring @morningman