Skip to content

[Fix](metrics) Fix FE's incorrect prometheus metrics format #57059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Oct 17, 2025
Merged

[Fix](metrics) Fix FE's incorrect prometheus metrics format #57059

dataroaring merged 1 commit into from
Oct 17, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Oct 16, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Oct 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-DS: Total hot run time: 190098 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd6736904a1dd862a312cff7c1d06366243478f6, data reload: false

query1	1071	431	409	409
query2	6569	1704	1697	1697
query3	6759	231	225	225
query4	26642	23853	23099	23099
query5	4584	626	491	491
query6	342	238	230	230
query7	4656	497	303	303
query8	338	282	254	254
query9	8698	2594	2608	2594
query10	490	351	293	293
query11	15605	15103	14820	14820
query12	185	126	114	114
query13	1691	586	431	431
query14	11162	9366	9399	9366
query15	204	199	170	170
query16	7506	684	517	517
query17	1213	762	623	623
query18	2014	413	364	364
query19	266	249	198	198
query20	158	143	136	136
query21	221	142	124	124
query22	4789	4793	4659	4659
query23	34788	34000	33882	33882
query24	9068	2554	2497	2497
query25	689	612	516	516
query26	1286	284	174	174
query27	3757	543	390	390
query28	4474	2258	2251	2251
query29	886	642	508	508
query30	393	257	211	211
query31	970	838	770	770
query32	85	70	73	70
query33	615	403	377	377
query34	1097	880	546	546
query35	843	869	755	755
query36	981	1044	953	953
query37	134	129	104	104
query38	3713	3740	3509	3509
query39	1469	1411	1426	1411
query40	219	125	116	116
query41	60	59	57	57
query42	119	105	126	105
query43	509	505	473	473
query44	1331	837	837	837
query45	187	182	173	173
query46	849	1010	651	651
query47	1743	1793	1822	1793
query48	391	417	325	325
query49	776	474	422	422
query50	663	684	420	420
query51	3881	3980	3882	3882
query52	114	117	98	98
query53	251	280	197	197
query54	612	605	533	533
query55	94	85	84	84
query56	337	306	298	298
query57	1171	1194	1094	1094
query58	294	293	284	284
query59	2548	2636	2564	2564
query60	393	338	331	331
query61	156	165	158	158
query62	798	744	681	681
query63	244	197	198	197
query64	4432	1152	828	828
query65	4108	3994	3978	3978
query66	1118	413	337	337
query67	15346	15446	14710	14710
query68	7841	952	613	613
query69	494	336	291	291
query70	1414	1278	1350	1278
query71	445	358	311	311
query72	6101	4871	4834	4834
query73	630	582	369	369
query74	8782	9193	8883	8883
query75	3655	3339	2841	2841
query76	3379	1170	765	765
query77	809	432	310	310
query78	9607	9664	8858	8858
query79	2306	868	610	610
query80	750	558	503	503
query81	515	261	231	231
query82	467	162	128	128
query83	263	270	258	258
query84	257	116	91	91
query85	918	462	424	424
query86	409	305	285	285
query87	3774	3753	3546	3546
query88	3879	2293	2334	2293
query89	393	335	302	302
query90	1967	232	229	229
query91	177	168	147	147
query92	90	72	74	72
query93	1911	976	650	650
query94	730	441	330	330
query95	404	325	307	307
query96	499	587	285	285
query97	2935	2975	2866	2866
query98	251	228	217	217
query99	1352	1436	1304	1304
Total cold run time: 280559 ms
Total hot run time: 190098 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 30.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd6736904a1dd862a312cff7c1d06366243478f6, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.06
query3	0.25	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.27	0.26
query6	1.18	0.66	0.65
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.63	0.53	0.51
query10	0.58	0.58	0.62
query11	0.16	0.10	0.11
query12	0.16	0.12	0.12
query13	0.64	0.61	0.61
query14	1.04	1.03	1.05
query15	0.86	0.85	0.90
query16	0.40	0.40	0.41
query17	1.07	1.07	1.03
query18	0.22	0.19	0.20
query19	1.94	1.80	1.82
query20	0.01	0.01	0.02
query21	15.46	0.92	0.58
query22	0.77	1.20	0.76
query23	14.81	1.37	0.58
query24	7.48	1.23	0.98
query25	0.47	0.14	0.22
query26	0.60	0.16	0.14
query27	0.08	0.06	0.05
query28	9.88	1.32	0.95
query29	12.58	4.00	3.23
query30	0.28	0.14	0.11
query31	2.83	0.62	0.39
query32	3.24	0.55	0.47
query33	3.11	3.11	3.09
query34	16.22	5.47	4.87
query35	4.97	4.90	4.90
query36	0.69	0.51	0.51
query37	0.11	0.07	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.02
query40	0.18	0.15	0.15
query41	0.09	0.03	0.05
query42	0.04	0.04	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.31 s
Total hot run time: 30.63 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@dataroaring dataroaring merged commit 7165d4e into apache:master Oct 17, 2025
33 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
@bobhan1
[Fix](metrics) Fix FE's incorrect prometheus metrics format (#57059)
9fc73bd
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Oct 17, 2025
@bobhan1
[Fix](metrics) Fix FE's incorrect prometheus metrics format (#57059)
b1e9a20
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 17, 2025
@github-actions @bobhan1
branch-3.1: [Fix](metrics) Fix FE's incorrect prometheus metrics format
f07b3c9 
#57059 (#57082)

Cherry-picked from #57059

Co-authored-by: bobhan1 <baohan@selectdb.com>
yiguolei pushed a commit that referenced this pull request Oct 17, 2025
@github-actions @bobhan1
branch-4.0: [Fix](metrics) Fix FE's incorrect prometheus metrics format
14818c9 
#57059 (#57083)

Cherry-picked from #57059

Co-authored-by: bobhan1 <baohan@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+2 more reviewers

@Hastyshell Hastyshell Hastyshell approved these changes

@0AyanamiRei 0AyanamiRei 0AyanamiRei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bobhan1 @hello-stephen @doris-robot @Hastyshell @dataroaring @0AyanamiRei @yiguolei @morrySnow