Skip to content

branch-3.1: [Fix](metrics) Fix FE's incorrect prometheus metrics format #57059 #57082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 17, 2025
Merged

branch-3.1: [Fix](metrics) Fix FE's incorrect prometheus metrics format #57059 #57082

morrySnow merged 1 commit into from
Oct 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 17, 2025

Cherry-picked from #57059

@github-actions github-actions bot requested a review from morrySnow as a code owner October 17, 2025 02:06
@Thearas
Copy link
Contributor

Thearas commented Oct 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 17, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

TPC-H: Total hot run time: 32760 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9fc73bd0510da7d4408fee5faec19f45074d48d0, data reload: false

------ Round 1 ----------------------------------
q1	17591	5469	5372	5372
q2	2021	390	278	278
q3	12011	1278	732	732
q4	10266	866	442	442
q5	8984	2370	2097	2097
q6	185	162	132	132
q7	892	749	613	613
q8	9332	1418	1123	1123
q9	5233	4914	4868	4868
q10	6767	2266	1872	1872
q11	487	275	255	255
q12	337	352	212	212
q13	17768	3575	3000	3000
q14	237	232	216	216
q15	509	469	469	469
q16	408	418	370	370
q17	579	843	357	357
q18	6822	6673	6726	6673
q19	1204	961	520	520
q20	310	336	199	199
q21	2779	2169	1957	1957
q22	1053	1009	1003	1003
Total cold run time: 105775 ms
Total hot run time: 32760 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5481	5464	5489	5464
q2	233	334	237	237
q3	2256	2631	2323	2323
q4	1403	1789	1388	1388
q5	4423	4919	5014	4919
q6	167	160	123	123
q7	1998	1946	1843	1843
q8	2614	2801	2644	2644
q9	7270	7314	7248	7248
q10	3059	3254	2765	2765
q11	587	503	507	503
q12	698	762	575	575
q13	3379	3772	3196	3196
q14	283	301	276	276
q15	524	467	472	467
q16	433	486	458	458
q17	1248	1718	1250	1250
q18	7578	7362	7286	7286
q19	803	1100	1099	1099
q20	2035	2059	1929	1929
q21	5351	4847	4453	4453
q22	1068	1147	1047	1047
Total cold run time: 52891 ms
Total hot run time: 51493 ms

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

TPC-DS: Total hot run time: 192694 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9fc73bd0510da7d4408fee5faec19f45074d48d0, data reload: false

query1	1001	404	391	391
query2	6110	1964	1880	1880
query3	9093	199	193	193
query4	33794	24024	23536	23536
query5	4618	609	455	455
query6	293	198	169	169
query7	4206	496	310	310
query8	307	247	221	221
query9	9360	2573	2573	2573
query10	484	333	261	261
query11	18217	15651	15196	15196
query12	151	108	108	108
query13	1557	549	424	424
query14	9713	6705	6840	6705
query15	235	194	183	183
query16	8043	668	501	501
query17	1552	761	593	593
query18	2185	425	319	319
query19	210	187	168	168
query20	130	123	128	123
query21	206	134	115	115
query22	4550	4754	4511	4511
query23	35271	34706	34662	34662
query24	7895	2664	2694	2664
query25	536	517	458	458
query26	1169	289	179	179
query27	2584	487	369	369
query28	5686	2222	2168	2168
query29	780	619	460	460
query30	241	190	164	164
query31	1059	900	857	857
query32	93	63	64	63
query33	546	373	317	317
query34	779	852	514	514
query35	776	810	753	753
query36	1030	1065	983	983
query37	106	90	69	69
query38	4062	4037	3969	3969
query39	1567	1488	1488	1488
query40	205	121	110	110
query41	53	48	46	46
query42	131	108	111	108
query43	506	533	491	491
query44	1334	816	817	816
query45	183	174	171	171
query46	886	1049	666	666
query47	1971	2003	1919	1919
query48	412	432	345	345
query49	817	483	397	397
query50	687	696	435	435
query51	7327	7267	7229	7229
query52	101	105	93	93
query53	230	268	205	205
query54	552	571	468	468
query55	80	81	79	79
query56	270	305	256	256
query57	1258	1293	1201	1201
query58	237	218	223	218
query59	3225	3170	3193	3170
query60	292	275	267	267
query61	117	113	108	108
query62	785	740	693	693
query63	232	193	212	193
query64	4737	1005	636	636
query65	3443	3287	3368	3287
query66	1037	415	305	305
query67	16209	15709	15407	15407
query68	7720	817	529	529
query69	488	301	265	265
query70	1202	1112	1111	1111
query71	375	302	266	266
query72	5652	3738	3811	3738
query73	629	744	349	349
query74	10277	9171	9309	9171
query75	3192	3186	2663	2663
query76	3167	1176	778	778
query77	586	363	284	284
query78	10385	10490	9657	9657
query79	2762	880	602	602
query80	601	517	430	430
query81	515	257	218	218
query82	503	117	92	92
query83	161	161	142	142
query84	245	100	77	77
query85	779	373	306	306
query86	397	299	298	298
query87	4287	4408	4232	4232
query88	4981	2420	2405	2405
query89	410	329	290	290
query90	1846	183	183	183
query91	135	135	119	119
query92	62	55	50	50
query93	1858	878	542	542
query94	673	409	295	295
query95	350	279	262	262
query96	479	601	293	293
query97	3195	3261	3149	3149
query98	215	215	207	207
query99	1687	1423	1300	1300
Total cold run time: 297326 ms
Total hot run time: 192694 ms

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

ClickBench: Total hot run time: 29.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9fc73bd0510da7d4408fee5faec19f45074d48d0, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.12	0.11
query5	0.52	0.50	0.49
query6	1.15	0.73	0.73
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.52
query10	0.56	0.55	0.55
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.59
query14	0.79	0.78	0.78
query15	0.84	0.84	0.83
query16	0.38	0.40	0.38
query17	1.06	1.05	1.04
query18	0.23	0.22	0.23
query19	1.91	1.90	1.81
query20	0.02	0.02	0.02
query21	15.39	0.92	0.60
query22	0.76	0.78	0.69
query23	15.06	1.40	0.63
query24	2.93	1.32	2.02
query25	0.13	0.05	0.20
query26	0.30	0.15	0.14
query27	0.04	0.05	0.04
query28	14.31	0.98	0.42
query29	12.59	4.03	3.26
query30	0.27	0.10	0.06
query31	2.82	0.64	0.39
query32	3.23	0.54	0.46
query33	3.04	3.01	3.11
query34	16.76	5.22	4.53
query35	4.59	4.55	4.52
query36	0.65	0.50	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.35 s
Total hot run time: 29.35 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 17, 2025

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit f07b3c9 into branch-3.1 Oct 17, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-57059-branch-3.1 branch October 17, 2025 06:15
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Thearas @doris-robot @hello-stephen @morrySnow @dataroaring @bobhan1