Skip to content

[opt](show-partitions) remove show partitions support for iceberg #56985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 5 commits into from
Oct 29, 2025
Merged

[opt](show-partitions) remove show partitions support for iceberg #56985

morningman merged 5 commits into from
Oct 29, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 15, 2025 •
edited
Loading

What problem does this PR solve?

Directly use select * from table$partitions to show the partition info of a iceberg table is enough.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Oct 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-DS: Total hot run time: 190924 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 785def3d68f8354f7536f0a3dec7e0886a58e8e0, data reload: false

query1	1085	451	429	429
query2	6568	1734	1680	1680
query3	6763	226	223	223
query4	26905	23836	23093	23093
query5	5428	663	521	521
query6	340	242	219	219
query7	4660	514	301	301
query8	339	279	253	253
query9	8726	2547	2600	2547
query10	548	345	301	301
query11	15285	15030	14852	14852
query12	187	127	120	120
query13	1676	576	430	430
query14	11319	9329	9387	9329
query15	217	189	174	174
query16	7659	690	512	512
query17	1302	741	639	639
query18	2083	511	352	352
query19	237	235	191	191
query20	150	147	149	147
query21	237	143	136	136
query22	4757	4898	4587	4587
query23	34987	33987	33878	33878
query24	8605	2531	2568	2531
query25	673	544	473	473
query26	1344	285	163	163
query27	3582	532	377	377
query28	4552	2229	2207	2207
query29	806	648	495	495
query30	312	236	206	206
query31	1001	866	771	771
query32	81	75	67	67
query33	618	402	365	365
query34	1288	931	549	549
query35	857	878	790	790
query36	991	1044	961	961
query37	130	117	98	98
query38	3724	3668	3580	3580
query39	1485	1425	1422	1422
query40	216	128	126	126
query41	63	60	58	58
query42	122	115	115	115
query43	503	507	489	489
query44	1343	844	847	844
query45	188	189	173	173
query46	842	992	646	646
query47	1764	1828	1752	1752
query48	382	425	308	308
query49	774	502	412	412
query50	661	685	421	421
query51	3970	3914	3846	3846
query52	120	117	106	106
query53	243	267	198	198
query54	613	603	547	547
query55	95	82	84	82
query56	325	332	302	302
query57	1179	1196	1128	1128
query58	291	277	281	277
query59	2578	2663	2561	2561
query60	355	342	347	342
query61	164	155	149	149
query62	837	761	670	670
query63	231	206	197	197
query64	4457	1149	857	857
query65	4083	3979	3964	3964
query66	1081	415	335	335
query67	15657	15202	15528	15202
query68	8031	870	609	609
query69	515	332	285	285
query70	1368	1285	1270	1270
query71	472	331	320	320
query72	5908	5040	5031	5031
query73	680	617	367	367
query74	9205	8854	8722	8722
query75	3573	3406	2968	2968
query76	3368	1167	743	743
query77	578	423	316	316
query78	9600	9621	8938	8938
query79	2648	856	603	603
query80	677	566	509	509
query81	526	264	235	235
query82	475	160	142	142
query83	280	264	248	248
query84	260	116	93	93
query85	905	467	483	467
query86	373	313	293	293
query87	3794	3788	3704	3704
query88	3823	2272	2267	2267
query89	395	331	297	297
query90	2031	225	226	225
query91	163	174	139	139
query92	86	74	73	73
query93	2262	973	639	639
query94	728	441	345	345
query95	411	326	318	318
query96	499	592	290	290
query97	2961	2990	2884	2884
query98	254	211	222	211
query99	1353	1424	1297	1297
Total cold run time: 282846 ms
Total hot run time: 190924 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

ClickBench: Total hot run time: 30.5 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 785def3d68f8354f7536f0a3dec7e0886a58e8e0, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.06	0.05
query3	0.27	0.09	0.08
query4	1.61	0.12	0.12
query5	0.28	0.26	0.26
query6	1.18	0.65	0.64
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.64	0.53	0.54
query10	0.58	0.57	0.59
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.64	0.61	0.63
query14	1.03	1.03	1.03
query15	0.87	0.84	0.87
query16	0.40	0.40	0.41
query17	1.05	1.09	1.06
query18	0.22	0.20	0.21
query19	1.90	1.85	1.83
query20	0.01	0.02	0.01
query21	15.44	0.96	0.57
query22	0.79	1.36	0.68
query23	14.74	1.44	0.64
query24	6.87	1.81	0.82
query25	0.46	0.18	0.08
query26	0.62	0.15	0.14
query27	0.08	0.06	0.05
query28	9.11	1.33	0.92
query29	12.55	3.95	3.30
query30	0.28	0.14	0.11
query31	2.84	0.61	0.39
query32	3.23	0.57	0.50
query33	3.05	3.11	3.10
query34	15.89	5.55	4.87
query35	4.98	4.85	4.90
query36	0.70	0.51	0.51
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.19	0.14	0.15
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 103.44 s
Total hot run time: 30.5 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE Regression Coverage Report

Increment line coverage 62.50% (15/24) 🎉
Increment coverage report
Complete coverage report

@morningman
Copy link
Contributor Author

morningman commented Oct 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-DS: Total hot run time: 189781 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a271f7d5c2b86f230a2a25e8d9795fb2897ef30, data reload: false

query1	1081	422	409	409
query2	6559	1695	1703	1695
query3	6760	225	217	217
query4	26887	23526	23154	23154
query5	5337	669	486	486
query6	336	247	211	211
query7	4693	507	308	308
query8	321	263	262	262
query9	8692	2579	2549	2549
query10	556	376	291	291
query11	15609	15183	15337	15183
query12	197	119	113	113
query13	1678	576	440	440
query14	12666	9274	9228	9228
query15	245	194	174	174
query16	7757	716	525	525
query17	1583	806	723	723
query18	2149	488	397	397
query19	322	237	205	205
query20	146	137	137	137
query21	227	140	138	138
query22	4653	4656	4560	4560
query23	34999	33508	33745	33508
query24	8236	2480	2540	2480
query25	597	552	472	472
query26	1261	290	160	160
query27	2772	512	401	401
query28	4634	2240	2234	2234
query29	895	630	508	508
query30	294	260	221	221
query31	984	813	769	769
query32	77	79	74	74
query33	600	397	364	364
query34	835	908	551	551
query35	837	889	742	742
query36	1040	1037	1060	1037
query37	136	118	97	97
query38	3725	3659	3559	3559
query39	1471	1413	1402	1402
query40	221	139	119	119
query41	62	59	59	59
query42	124	111	115	111
query43	491	513	468	468
query44	1384	826	829	826
query45	187	176	187	176
query46	854	1008	647	647
query47	1738	1819	1710	1710
query48	394	421	330	330
query49	758	513	405	405
query50	646	697	402	402
query51	3912	3958	3937	3937
query52	113	115	99	99
query53	243	286	207	207
query54	610	599	522	522
query55	83	94	91	91
query56	323	317	327	317
query57	1158	1189	1102	1102
query58	285	288	279	279
query59	2533	2597	2495	2495
query60	340	346	322	322
query61	158	152	150	150
query62	797	737	653	653
query63	233	194	205	194
query64	4358	1207	902	902
query65	4051	3966	3993	3966
query66	1062	433	321	321
query67	15327	15260	14873	14873
query68	7169	951	605	605
query69	488	321	291	291
query70	1406	1308	1284	1284
query71	484	348	321	321
query72	5761	4915	4783	4783
query73	540	577	365	365
query74	8927	9098	8566	8566
query75	3914	3308	2753	2753
query76	3185	1155	744	744
query77	794	420	312	312
query78	9698	9678	9008	9008
query79	2167	847	586	586
query80	636	560	499	499
query81	517	259	226	226
query82	472	159	129	129
query83	271	282	240	240
query84	259	105	90	90
query85	962	465	420	420
query86	379	313	301	301
query87	3735	3793	3639	3639
query88	3803	2258	2293	2258
query89	388	325	303	303
query90	2024	231	225	225
query91	168	159	137	137
query92	80	80	69	69
query93	1835	973	654	654
query94	701	436	342	342
query95	399	319	311	311
query96	489	577	288	288
query97	2938	2964	2846	2846
query98	240	207	209	207
query99	1650	1394	1312	1312
Total cold run time: 280771 ms
Total hot run time: 189781 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 30.28 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a271f7d5c2b86f230a2a25e8d9795fb2897ef30, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.06
query3	0.26	0.08	0.08
query4	1.62	0.11	0.12
query5	0.28	0.26	0.26
query6	1.18	0.67	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.64	0.53	0.52
query10	0.58	0.60	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.60
query14	1.01	1.02	1.02
query15	0.86	0.84	0.87
query16	0.41	0.41	0.40
query17	1.09	1.04	1.04
query18	0.21	0.20	0.21
query19	1.97	1.86	1.90
query20	0.01	0.02	0.02
query21	15.45	0.92	0.56
query22	0.75	1.19	0.72
query23	14.86	1.38	0.60
query24	6.78	1.62	0.43
query25	0.50	0.18	0.17
query26	0.63	0.15	0.14
query27	0.07	0.06	0.06
query28	9.53	1.37	0.92
query29	12.57	4.05	3.37
query30	0.29	0.15	0.11
query31	2.83	0.60	0.39
query32	3.23	0.57	0.48
query33	3.10	3.06	3.10
query34	16.21	5.54	4.90
query35	4.88	4.93	4.95
query36	0.70	0.51	0.50
query37	0.10	0.07	0.08
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.2 s
Total hot run time: 30.28 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

FE UT Coverage Report

Increment line coverage 12.50% (3/24) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

FE Regression Coverage Report

Increment line coverage 62.50% (15/24) 🎉
Increment coverage report
Complete coverage report

@morningman
Copy link
Contributor Author

morningman commented Oct 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 17, 2025

ClickBench: Total hot run time: 30.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a3cc9eeabf6aae6dcc5d2e24d59ecc7e177547b, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.06	0.06
query3	0.26	0.09	0.09
query4	1.61	0.12	0.12
query5	0.29	0.26	0.26
query6	1.14	0.66	0.64
query7	0.04	0.02	0.02
query8	0.05	0.05	0.05
query9	0.67	0.54	0.53
query10	0.60	0.60	0.59
query11	0.20	0.12	0.11
query12	0.16	0.13	0.13
query13	0.65	0.62	0.61
query14	1.04	1.05	1.05
query15	0.90	0.89	0.86
query16	0.41	0.41	0.42
query17	1.10	1.10	1.11
query18	0.23	0.21	0.20
query19	2.01	1.90	1.88
query20	0.02	0.01	0.02
query21	15.40	0.98	0.60
query22	0.76	1.19	0.79
query23	14.80	1.43	0.67
query24	6.75	0.78	1.05
query25	0.50	0.26	0.06
query26	0.54	0.16	0.15
query27	0.07	0.06	0.05
query28	10.14	1.41	0.94
query29	12.56	4.03	3.34
query30	0.30	0.14	0.12
query31	2.84	0.62	0.40
query32	3.24	0.57	0.48
query33	3.20	3.09	3.09
query34	16.11	5.52	4.84
query35	5.00	4.91	4.93
query36	0.71	0.53	0.52
query37	0.11	0.08	0.07
query38	0.08	0.05	0.05
query39	0.04	0.03	0.02
query40	0.18	0.16	0.14
query41	0.09	0.03	0.04
query42	0.05	0.04	0.03
query43	0.07	0.04	0.03
Total cold run time: 105.07 s
Total hot run time: 30.87 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 18, 2025

FE UT Coverage Report

Increment line coverage 12.50% (3/24) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit 3fa9428 into apache:master Oct 29, 2025
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2025
@morningman
[opt](show-partitions) remove show partitions support for iceberg (#5…
406ad7f 
…6985)

### What problem does this PR solve?

Directly use `select * from table$partitions` to show the partition info
of a iceberg table is enough.
@github-actions github-actions bot mentioned this pull request Oct 29, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 30, 2025
@github-actions @morningman
branch-4.0: [opt](show-partitions) remove show partitions support for…
642b5e5 
… iceberg #56985 (#57452)

Cherry-picked from #56985

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
morningman added a commit to morningman/doris that referenced this pull request Oct 30, 2025
@morningman
[opt](show-partitions) remove show partitions support for iceberg (ap…
3db7c7b 
…ache#56985)

Directly use `select * from table$partitions` to show the partition info
of a iceberg table is enough.
@morningman morningman mentioned this pull request Oct 30, 2025
Merged
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
@morningman @dwdwqfwe
[opt](show-partitions) remove show partitions support for iceberg (ap…
5be5c2e 
…ache#56985)

### What problem does this PR solve?

Directly use `select * from table$partitions` to show the partition info
of a iceberg table is enough.
morningman added a commit that referenced this pull request Oct 31, 2025
@morningman
branch-3.1: [opt](show-partitions) remove show partitions support for…
12242f2 
… iceberg (#56985) (#57501)

bp #56985
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

+1 more reviewer

@hubgeter hubgeter hubgeter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.1-merged kind/behavior-changed reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@morningman @Thearas @doris-robot @hello-stephen @CalvinKirs @zy-kkk @hubgeter @yiguolei