Skip to content

branch-3.1: [opt](show-partitions) remove show partitions support for iceberg (#56985) #57501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 31, 2025
Merged

branch-3.1: [opt](show-partitions) remove show partitions support for iceberg (#56985) #57501

morningman merged 2 commits into from
Oct 31, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 30, 2025

bp #56985

@morningman
[opt](show-partitions) remove show partitions support for iceberg (ap…
3db7c7b 
…ache#56985)

Directly use `select * from table$partitions` to show the partition info
of a iceberg table is enough.
@morningman morningman requested a review from morrySnow as a code owner October 30, 2025 07:12
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Oct 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2025

FE UT Coverage Report

Increment line coverage 12.50% (1/8) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

TPC-H: Total hot run time: 33447 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3db7c7b6fdd6da3657e56cdd4bfc03ba6f25ff1b, data reload: false

------ Round 1 ----------------------------------
q1	17588	5834	5517	5517
q2	2043	434	290	290
q3	11883	1254	778	778
q4	10262	891	484	484
q5	8589	2432	2178	2178
q6	194	171	137	137
q7	960	749	646	646
q8	9358	1490	1240	1240
q9	5268	5046	4951	4951
q10	6796	2296	1879	1879
q11	479	288	270	270
q12	363	366	219	219
q13	17810	3632	3058	3058
q14	235	241	228	228
q15	537	482	476	476
q16	436	438	384	384
q17	663	881	388	388
q18	7064	6532	6496	6496
q19	1207	967	552	552
q20	345	356	211	211
q21	3076	2288	2068	2068
q22	1086	998	997	997
Total cold run time: 106242 ms
Total hot run time: 33447 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5603	5573	5560	5560
q2	245	336	236	236
q3	2243	2662	2373	2373
q4	1397	1870	1376	1376
q5	4494	5200	5048	5048
q6	186	169	141	141
q7	2087	2000	1837	1837
q8	2693	2862	2792	2792
q9	7373	7342	7283	7283
q10	3112	3226	2820	2820
q11	593	536	501	501
q12	720	763	606	606
q13	3467	3876	3180	3180
q14	302	315	273	273
q15	531	487	467	467
q16	435	508	462	462
q17	1307	1755	1291	1291
q18	7718	7551	7242	7242
q19	902	1058	1142	1058
q20	2026	2092	1931	1931
q21	5562	5184	4717	4717
q22	1107	1115	1049	1049
Total cold run time: 54103 ms
Total hot run time: 52243 ms

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

TPC-DS: Total hot run time: 196704 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3db7c7b6fdd6da3657e56cdd4bfc03ba6f25ff1b, data reload: false

query1	980	401	406	401
query2	6362	2094	2021	2021
query3	8689	219	214	214
query4	33675	24265	23599	23599
query5	3901	633	472	472
query6	300	195	198	195
query7	4221	518	343	343
query8	318	259	256	256
query9	9446	2857	2855	2855
query10	473	343	282	282
query11	18051	15531	15481	15481
query12	170	118	109	109
query13	1567	599	451	451
query14	9072	7695	6929	6929
query15	244	196	202	196
query16	8136	670	518	518
query17	1558	772	629	629
query18	2195	450	348	348
query19	233	205	179	179
query20	130	130	128	128
query21	216	139	115	115
query22	4608	4717	4525	4525
query23	35320	34602	34447	34447
query24	7430	2796	2803	2796
query25	572	520	444	444
query26	1170	301	186	186
query27	2173	509	386	386
query28	5439	2489	2396	2396
query29	806	623	504	504
query30	244	203	166	166
query31	1041	930	854	854
query32	100	60	59	59
query33	496	376	331	331
query34	824	896	568	568
query35	807	842	760	760
query36	1120	1147	1025	1025
query37	116	95	69	69
query38	4070	4065	3978	3978
query39	1715	1477	1490	1477
query40	214	131	114	114
query41	52	53	49	49
query42	131	113	116	113
query43	537	554	535	535
query44	1415	910	906	906
query45	205	184	175	175
query46	934	1096	713	713
query47	2034	2037	1927	1927
query48	444	455	383	383
query49	829	513	450	450
query50	742	739	469	469
query51	7458	7459	7442	7442
query52	119	124	105	105
query53	251	284	207	207
query54	620	615	519	519
query55	90	92	90	90
query56	293	288	265	265
query57	1284	1332	1250	1250
query58	256	232	237	232
query59	3252	3382	3212	3212
query60	319	315	281	281
query61	129	120	129	120
query62	820	778	708	708
query63	257	213	207	207
query64	4618	1043	683	683
query65	3380	3372	3326	3326
query66	987	425	325	325
query67	16526	15963	15759	15759
query68	7915	891	589	589
query69	498	317	278	278
query70	1274	1154	1216	1154
query71	396	311	284	284
query72	5760	3853	3989	3853
query73	703	780	387	387
query74	10585	9516	9252	9252
query75	3270	3147	2701	2701
query76	3223	1211	801	801
query77	641	398	298	298
query78	10469	10469	9739	9739
query79	3795	918	639	639
query80	659	528	464	464
query81	529	259	225	225
query82	604	126	94	94
query83	181	172	150	150
query84	250	109	85	85
query85	810	405	321	321
query86	392	319	325	319
query87	4365	4413	4297	4297
query88	5454	2649	2633	2633
query89	419	342	306	306
query90	1805	196	200	196
query91	151	148	119	119
query92	67	58	54	54
query93	2108	903	587	587
query94	681	426	328	328
query95	372	301	287	287
query96	540	631	303	303
query97	3185	3254	3145	3145
query98	237	220	213	213
query99	1532	1407	1346	1346
Total cold run time: 299054 ms
Total hot run time: 196704 ms

@doris-robot
Copy link

doris-robot commented Oct 30, 2025

ClickBench: Total hot run time: 29.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3db7c7b6fdd6da3657e56cdd4bfc03ba6f25ff1b, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.10
query5	0.50	0.52	0.53
query6	1.14	0.73	0.74
query7	0.03	0.01	0.01
query8	0.05	0.03	0.04
query9	0.58	0.51	0.52
query10	0.59	0.56	0.57
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.59
query14	0.79	0.80	0.81
query15	0.86	0.85	0.84
query16	0.41	0.40	0.42
query17	1.07	1.05	1.08
query18	0.26	0.23	0.23
query19	2.02	1.95	1.95
query20	0.02	0.01	0.01
query21	15.36	0.96	0.61
query22	0.74	0.81	0.80
query23	15.02	1.51	0.61
query24	3.17	0.76	0.77
query25	0.16	0.10	0.04
query26	0.42	0.16	0.14
query27	0.07	0.05	0.04
query28	12.27	1.13	0.47
query29	12.61	4.07	3.36
query30	0.25	0.10	0.06
query31	2.82	0.62	0.41
query32	3.23	0.54	0.48
query33	3.06	3.07	3.08
query34	16.77	5.17	4.55
query35	4.59	4.58	4.60
query36	0.65	0.51	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 102.88 s
Total hot run time: 29.49 s

@morningman morningman changed the title [opt](show-partitions) remove show partitions support for iceberg (#56985) branch-3.1: [opt](show-partitions) remove show partitions support for iceberg (#56985) Oct 30, 2025
@morningman
Copy link
Contributor Author

morningman commented Oct 31, 2025

run buildall

@morningman morningman merged commit 12242f2 into apache:branch-3.1 Oct 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @hello-stephen @doris-robot @morrySnow