Skip to content

[opt](iceberg) opt the error msg of iceberg scan node #56327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 3 commits into from
Sep 24, 2025
Merged

[opt](iceberg) opt the error msg of iceberg scan node #56327

morningman merged 3 commits into from
Sep 24, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Sep 22, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

Sometime the origin error msg is misleading.
We should show the root cause in error msg

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Sep 23, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@morningman
Copy link
Contributor Author

morningman commented Sep 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

ClickBench: Total hot run time: 30.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 16230836a40e0d3f02ab3b351773b4a8ecd9febf, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.06	0.06
query3	0.26	0.08	0.09
query4	1.61	0.12	0.11
query5	0.28	0.25	0.26
query6	1.16	0.66	0.63
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.53	0.53
query10	0.58	0.58	0.59
query11	0.19	0.12	0.12
query12	0.15	0.11	0.12
query13	0.63	0.62	0.63
query14	1.03	1.05	1.03
query15	0.85	0.86	0.86
query16	0.40	0.39	0.40
query17	1.05	1.06	1.02
query18	0.22	0.20	0.20
query19	2.27	2.03	2.03
query20	0.02	0.02	0.01
query21	15.60	0.92	0.59
query22	0.77	1.11	0.64
query23	15.06	1.37	0.64
query24	6.99	1.64	1.02
query25	0.49	0.12	0.15
query26	0.66	0.17	0.13
query27	0.07	0.06	0.06
query28	9.69	1.36	0.94
query29	12.56	3.83	3.29
query30	0.29	0.15	0.11
query31	2.82	0.61	0.39
query32	3.24	0.55	0.48
query33	3.14	3.06	3.14
query34	16.06	5.51	4.83
query35	4.92	4.89	4.87
query36	0.68	0.50	0.50
query37	0.10	0.07	0.07
query38	0.06	0.05	0.04
query39	0.04	0.04	0.03
query40	0.17	0.16	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 105.14 s
Total hot run time: 30.79 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit ec2a6f6 into apache:master Sep 24, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 24, 2025
@morningman
[opt](iceberg) opt the error msg of iceberg scan node (#56327)
f664835 
### What problem does this PR solve?

Problem Summary:

Sometime the origin error msg is misleading.
We should show the root cause in error msg
@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 25, 2025
@github-actions @morningman
branch-3.1: [opt](iceberg) opt the error msg of iceberg scan node #56327
7dc4d3a 
 (#56370)

Cherry-picked from #56327

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@morningman
[opt](iceberg) opt the error msg of iceberg scan node (apache#56327) (a…
b4b90a7 
…pache#4825)

close apache#4722
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

+1 more reviewer

@suxiaogang223 suxiaogang223 suxiaogang223 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.0.x-conflict dev/3.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morningman @Thearas @hello-stephen @doris-robot @CalvinKirs @suxiaogang223 @morrySnow