Skip to content

branch-3.1: [opt](iceberg) opt the error msg of iceberg scan node #56327 #56370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 25, 2025
Merged

branch-3.1: [opt](iceberg) opt the error msg of iceberg scan node #56327 #56370

morrySnow merged 1 commit into from
Sep 25, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 24, 2025

Cherry-picked from #56327

@morningman
[opt](iceberg) opt the error msg of iceberg scan node (#56327)
f664835 
### What problem does this PR solve?

Problem Summary:

Sometime the origin error msg is misleading.
We should show the root cause in error msg
@github-actions github-actions bot requested a review from morrySnow as a code owner September 24, 2025 01:50
@Thearas
Copy link
Contributor

Thearas commented Sep 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 24, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 24, 2025

TPC-H: Total hot run time: 32629 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f6648354a7d2b8789b061a6aa432f32e872c0861, data reload: false

------ Round 1 ----------------------------------
q1	17571	5904	5427	5427
q2	2018	414	292	292
q3	12133	1256	759	759
q4	10533	890	458	458
q5	9547	2359	2122	2122
q6	188	163	132	132
q7	899	737	632	632
q8	9321	1393	1180	1180
q9	5242	4949	4904	4904
q10	6785	2266	1818	1818
q11	494	289	269	269
q12	340	357	214	214
q13	17761	3607	3018	3018
q14	232	232	218	218
q15	523	458	462	458
q16	420	422	373	373
q17	617	855	367	367
q18	6798	6303	6308	6303
q19	1206	949	536	536
q20	336	335	209	209
q21	2941	2210	1976	1976
q22	1043	997	964	964
Total cold run time: 106948 ms
Total hot run time: 32629 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5541	5510	5513	5510
q2	231	322	236	236
q3	2274	2627	2308	2308
q4	1443	1804	1363	1363
q5	4391	4999	4985	4985
q6	171	161	129	129
q7	2127	1983	1831	1831
q8	2638	2896	2731	2731
q9	7454	7407	7313	7313
q10	3076	3298	2768	2768
q11	580	522	506	506
q12	724	783	631	631
q13	3439	3907	3299	3299
q14	283	320	273	273
q15	530	480	477	477
q16	462	490	455	455
q17	1253	1749	1305	1305
q18	7802	7628	7512	7512
q19	801	911	1157	911
q20	1994	2056	1877	1877
q21	5354	4840	4599	4599
q22	1071	1100	1042	1042
Total cold run time: 53639 ms
Total hot run time: 52061 ms

@doris-robot
Copy link

doris-robot commented Sep 24, 2025

TPC-DS: Total hot run time: 192671 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f6648354a7d2b8789b061a6aa432f32e872c0861, data reload: false

query1	968	383	391	383
query2	6213	1881	1830	1830
query3	8680	207	198	198
query4	33750	24321	23574	23574
query5	4098	603	446	446
query6	300	193	187	187
query7	4198	493	320	320
query8	301	239	228	228
query9	9187	2604	2578	2578
query10	511	326	287	287
query11	18185	15447	15250	15250
query12	157	112	103	103
query13	1560	552	426	426
query14	10379	6713	6514	6514
query15	204	196	174	174
query16	7967	669	519	519
query17	1582	756	591	591
query18	2094	419	340	340
query19	246	195	169	169
query20	126	121	124	121
query21	210	132	109	109
query22	4669	4657	4457	4457
query23	34988	34841	34149	34149
query24	7633	2711	2729	2711
query25	545	507	423	423
query26	838	295	172	172
query27	2186	482	360	360
query28	5250	2242	2196	2196
query29	668	631	467	467
query30	240	194	165	165
query31	1029	944	877	877
query32	75	64	59	59
query33	509	387	331	331
query34	765	867	524	524
query35	787	830	734	734
query36	1002	1057	952	952
query37	100	97	65	65
query38	4000	3952	4019	3952
query39	1570	1471	1467	1467
query40	210	123	105	105
query41	49	48	47	47
query42	121	104	103	103
query43	492	514	475	475
query44	1377	846	822	822
query45	186	176	173	173
query46	894	1070	668	668
query47	1989	2007	1967	1967
query48	426	412	351	351
query49	728	501	419	419
query50	680	699	440	440
query51	7394	7312	7280	7280
query52	99	105	89	89
query53	228	263	195	195
query54	561	570	492	492
query55	86	79	77	77
query56	273	266	265	265
query57	1294	1268	1219	1219
query58	244	218	222	218
query59	3074	3268	3063	3063
query60	293	295	270	270
query61	112	122	121	121
query62	815	753	698	698
query63	239	200	198	198
query64	3357	1014	635	635
query65	3336	3286	3285	3285
query66	779	399	336	336
query67	16203	16086	15645	15645
query68	7097	831	560	560
query69	497	305	277	277
query70	1196	1150	1148	1148
query71	378	294	270	270
query72	5712	3776	3884	3776
query73	639	755	360	360
query74	10209	9179	9139	9139
query75	3238	3135	2679	2679
query76	2962	1154	775	775
query77	485	378	280	280
query78	10416	10481	9633	9633
query79	3442	875	599	599
query80	702	520	435	435
query81	513	259	223	223
query82	581	119	90	90
query83	153	159	146	146
query84	239	106	78	78
query85	793	395	307	307
query86	393	324	315	315
query87	4341	4280	4275	4275
query88	5162	2417	2418	2417
query89	407	339	296	296
query90	1765	191	191	191
query91	138	138	111	111
query92	64	56	53	53
query93	2003	871	556	556
query94	688	420	301	301
query95	349	281	276	276
query96	496	614	289	289
query97	3188	3302	3238	3238
query98	217	211	196	196
query99	1619	1415	1318	1318
Total cold run time: 293391 ms
Total hot run time: 192671 ms

@doris-robot
Copy link

doris-robot commented Sep 24, 2025

ClickBench: Total hot run time: 28.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f6648354a7d2b8789b061a6aa432f32e872c0861, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.02	0.04
query3	0.25	0.06	0.07
query4	1.64	0.11	0.11
query5	0.53	0.52	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.49	0.49
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.13	0.12	0.11
query13	0.62	0.61	0.59
query14	0.79	0.81	0.80
query15	0.85	0.83	0.84
query16	0.39	0.39	0.38
query17	1.04	1.03	1.04
query18	0.24	0.22	0.21
query19	1.96	1.89	1.90
query20	0.02	0.02	0.01
query21	15.35	0.97	0.57
query22	0.76	0.68	0.62
query23	15.30	1.40	0.57
query24	3.70	1.36	0.68
query25	0.15	0.12	0.11
query26	0.42	0.14	0.14
query27	0.05	0.05	0.05
query28	13.28	1.00	0.45
query29	12.62	3.94	3.27
query30	0.25	0.09	0.06
query31	2.86	0.60	0.38
query32	3.23	0.54	0.46
query33	3.04	3.03	3.05
query34	16.61	5.21	4.52
query35	4.57	4.57	4.60
query36	0.63	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.33 s
Total hot run time: 28.76 s

@morrySnow morrySnow merged commit 7dc4d3a into branch-3.1 Sep 25, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-56327-branch-3.1 branch September 25, 2025 09:35
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @morrySnow @dataroaring @morningman