Skip to content

[fix](warmup) fix show warm up tables #55192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 22, 2025
Merged

[fix](warmup) fix show warm up tables #55192

dataroaring merged 1 commit into from
Aug 22, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Aug 22, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #51594 #52370

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup feature.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@kaijchen
[fix](warmup) fix show warm up tables (apache#53406)
5cfb240 
Related PR: apache#52291 apache#52514

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup
feature.
@Thearas
Copy link
Contributor

Thearas commented Aug 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

kaijchen commented Aug 22, 2025

branch-3.0: #53406

@kaijchen
Copy link
Member Author

kaijchen commented Aug 22, 2025

run buildall

1 similar comment
@kaijchen
Copy link
Member Author

kaijchen commented Aug 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 22, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4797096 into apache:master Aug 22, 2025
30 of 32 checks passed
@kaijchen kaijchen mentioned this pull request Aug 25, 2025
Merged
morrySnow pushed a commit that referenced this pull request Aug 25, 2025
@kaijchen
branch-3.1: [fix](warmup) fix show warm up tables #55192 (#55193)
b63a671 
backport #55192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.8-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kaijchen @Thearas @hello-stephen @liaoxin01 @dataroaring @morrySnow