Skip to content

[fix](warmup) fix show warm up tables #53406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Jul 18, 2025
Merged

[fix](warmup) fix show warm up tables #53406

dataroaring merged 3 commits into from
Jul 18, 2025

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 16, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #52291 #52514

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup feature.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@kaijchen kaijchen requested a review from dataroaring as a code owner July 16, 2025 12:53
@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

freemandealer
freemandealer reviewed Jul 16, 2025
View reviewed changes
regression-test/suites/cloud_p0/cache/multi_cluster/warm_up/table/test_warm_up_tables.groovy Outdated
def getTablesFromShowCommand = { jobId ->
def jobStateResult = sql """ SHOW WARM UP JOB WHERE ID = ${jobId} """
return jobStateResult[0][9]
return jobStateResult[0][12]
Copy link
Contributor

@freemandealer freemandealer Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaijchen needn't modify this test. I'll change it to any.equals to match with any position

@kaijchen
Copy link
Member Author

kaijchen commented Jul 16, 2025

run buildall

1 similar comment
@freemandealer
Copy link
Contributor

freemandealer commented Jul 16, 2025

run buildall

dataroaring
dataroaring previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR approved by anyone and no changes requested.

@freemandealer
Copy link
Contributor

freemandealer commented Jul 17, 2025

run buildall

freemandealer
freemandealer approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 17, 2025
@kaijchen
Copy link
Member Author

kaijchen commented Jul 17, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 17, 2025

TPC-H: Total hot run time: 39616 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 92ad27da17ee059e7ccac9c3f76b8a24331a5124, data reload: false

------ Round 1 ----------------------------------
q1	17893	6974	6565	6565
q2	2075	205	164	164
q3	10659	1170	1096	1096
q4	10505	764	767	764
q5	7684	2880	2840	2840
q6	212	134	131	131
q7	964	618	588	588
q8	9372	1913	1992	1913
q9	6586	6385	6368	6368
q10	7034	2297	2255	2255
q11	462	263	258	258
q12	393	218	220	218
q13	17847	2967	2984	2967
q14	246	200	202	200
q15	520	463	465	463
q16	523	380	375	375
q17	965	563	539	539
q18	7410	6731	6656	6656
q19	1397	1111	1025	1025
q20	469	203	211	203
q21	3868	3070	3208	3070
q22	1090	968	958	958
Total cold run time: 108174 ms
Total hot run time: 39616 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6696	6601	6577	6577
q2	329	222	230	222
q3	2885	2958	2942	2942
q4	1991	1814	1795	1795
q5	5672	5675	5683	5675
q6	208	127	131	127
q7	2285	1789	1784	1784
q8	3357	3495	3491	3491
q9	8736	8869	8806	8806
q10	3571	3520	3433	3433
q11	586	482	480	480
q12	791	615	597	597
q13	8859	3159	3133	3133
q14	295	265	266	265
q15	508	474	456	456
q16	492	454	446	446
q17	1825	1641	1613	1613
q18	8348	7722	7663	7663
q19	1674	1480	1553	1480
q20	2048	1832	1819	1819
q21	5108	5132	5187	5132
q22	1133	1018	1012	1012
Total cold run time: 67397 ms
Total hot run time: 58948 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2025

TPC-DS: Total hot run time: 196320 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 92ad27da17ee059e7ccac9c3f76b8a24331a5124, data reload: false

query1	1272	920	894	894
query2	6326	1893	1907	1893
query3	10834	4249	4341	4249
query4	33189	23669	23529	23529
query5	3588	467	462	462
query6	255	175	179	175
query7	3986	324	317	317
query8	278	223	217	217
query9	9385	2546	2537	2537
query10	479	259	258	258
query11	17937	15060	15234	15060
query12	164	98	102	98
query13	1549	443	434	434
query14	9496	6981	7180	6981
query15	233	179	184	179
query16	8055	492	484	484
query17	1589	591	607	591
query18	2154	313	318	313
query19	257	169	163	163
query20	123	111	111	111
query21	206	115	110	110
query22	4738	4410	4339	4339
query23	35341	34292	34002	34002
query24	11665	2895	2891	2891
query25	690	420	420	420
query26	1917	176	170	170
query27	2778	355	355	355
query28	7475	2109	2136	2109
query29	1015	466	468	466
query30	272	168	161	161
query31	1026	814	833	814
query32	102	55	56	55
query33	787	326	302	302
query34	1008	515	528	515
query35	860	735	721	721
query36	1090	948	920	920
query37	277	71	65	65
query38	4064	3923	4015	3923
query39	1570	1477	1477	1477
query40	261	104	101	101
query41	48	51	49	49
query42	115	99	106	99
query43	503	486	476	476
query44	1274	809	812	809
query45	184	169	169	169
query46	1151	713	718	713
query47	1990	1905	1908	1905
query48	473	394	400	394
query49	1107	423	417	417
query50	836	440	429	429
query51	7424	7236	7253	7236
query52	111	92	94	92
query53	259	186	187	186
query54	1327	477	467	467
query55	76	76	77	76
query56	273	237	252	237
query57	1328	1206	1175	1175
query58	247	205	220	205
query59	3140	3129	3058	3058
query60	299	259	261	259
query61	113	113	121	113
query62	854	720	712	712
query63	222	189	188	188
query64	5101	670	636	636
query65	3400	3272	3278	3272
query66	1403	299	312	299
query67	16047	15463	15541	15463
query68	5329	585	562	562
query69	425	273	256	256
query70	1170	1078	1073	1073
query71	346	260	263	260
query72	6183	4093	4044	4044
query73	739	346	350	346
query74	10760	8962	8945	8945
query75	3409	2620	2656	2620
query76	3217	1232	1127	1127
query77	399	279	271	271
query78	10444	9655	9522	9522
query79	1153	607	589	589
query80	826	425	429	425
query81	541	219	217	217
query82	630	93	91	91
query83	248	146	148	146
query84	230	80	74	74
query85	1495	301	300	300
query86	469	295	293	293
query87	4328	4219	4207	4207
query88	4182	2368	2355	2355
query89	410	287	294	287
query90	2097	186	187	186
query91	179	147	149	147
query92	61	48	51	48
query93	2175	551	545	545
query94	855	297	291	291
query95	359	264	259	259
query96	624	275	276	275
query97	3322	3170	3094	3094
query98	219	213	199	199
query99	1477	1271	1291	1271
Total cold run time: 305897 ms
Total hot run time: 196320 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2025

ClickBench: Total hot run time: 29.6 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 92ad27da17ee059e7ccac9c3f76b8a24331a5124, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.52	0.50	0.54
query6	1.12	0.72	0.71
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.56	0.49	0.51
query10	0.54	0.56	0.59
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	0.76	0.80	0.80
query15	0.83	0.82	0.81
query16	0.38	0.38	0.38
query17	1.03	1.01	0.99
query18	0.23	0.22	0.21
query19	1.88	1.84	1.80
query20	0.01	0.01	0.01
query21	15.42	0.58	0.56
query22	2.22	2.05	1.60
query23	17.06	0.99	0.88
query24	3.14	0.70	1.95
query25	0.21	0.13	0.27
query26	0.36	0.13	0.14
query27	0.05	0.03	0.05
query28	10.00	0.51	0.46
query29	12.57	3.21	3.20
query30	0.25	0.06	0.06
query31	2.85	0.40	0.37
query32	3.23	0.46	0.45
query33	2.96	2.99	3.00
query34	16.98	4.43	4.45
query35	4.50	4.57	4.50
query36	0.68	0.47	0.47
query37	0.09	0.07	0.07
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.15	0.12	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.72 s
Total hot run time: 29.6 s

@freemandealer
Copy link
Contributor

freemandealer commented Jul 18, 2025

run feut

dataroaring
dataroaring approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8a1f679 into apache:branch-3.0 Jul 18, 2025
24 of 25 checks passed
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
kaijchen added a commit to kaijchen/doris that referenced this pull request Aug 22, 2025
@kaijchen
[fix](warmup) fix show warm up tables (apache#53406)
6625e00 
### What problem does this PR solve?

Related PR: apache#52291 apache#52514

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup
feature.
kaijchen added a commit to kaijchen/doris that referenced this pull request Aug 22, 2025
@kaijchen
[fix](warmup) fix show warm up tables (apache#53406)
ef8ec5d 
Related PR: apache#52291 apache#52514

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup
feature.
kaijchen added a commit to kaijchen/doris that referenced this pull request Aug 22, 2025
@kaijchen
[fix](warmup) fix show warm up tables (apache#53406)
5cfb240 
Related PR: apache#52291 apache#52514

Problem Summary:

Fix show warm up jobs after merging periodic and event driven warmup
feature.
@kaijchen kaijchen mentioned this pull request Aug 22, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@freemandealer freemandealer freemandealer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaijchen @hello-stephen @freemandealer @doris-robot @dataroaring