Skip to content

[test](filecache) fix lru dumper test #54456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Aug 10, 2025
Merged

[test](filecache) fix lru dumper test #54456

dataroaring merged 1 commit into from
Aug 10, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Aug 7, 2025

fix incorrect dumper file name and use directory to contain all the test dump files to make test clean.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[test](filecache) fix lru dumper test
7c68aaf 
fix incorrect dumper file name and use directory to contain all the
test dump files to make test clean.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer freemandealer mentioned this pull request Aug 7, 2025
Merged
16 tasks
@freemandealer
Copy link
Contributor Author

freemandealer commented Aug 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

TPC-H: Total hot run time: 34003 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c68aafa55cc3f82155205c873887e587af71859, data reload: false

------ Round 1 ----------------------------------
q1	17637	5418	5347	5347
q2	1933	303	197	197
q3	10277	1341	719	719
q4	10220	1106	509	509
q5	7496	2349	2292	2292
q6	176	165	135	135
q7	935	756	618	618
q8	9301	1262	1079	1079
q9	6767	5039	5110	5039
q10	6939	2373	1992	1992
q11	481	279	262	262
q12	347	365	219	219
q13	17791	3449	2985	2985
q14	239	236	229	229
q15	532	460	456	456
q16	427	426	382	382
q17	574	844	346	346
q18	7578	7095	7152	7095
q19	2769	992	550	550
q20	476	305	215	215
q21	3564	3102	2318	2318
q22	1060	1070	1019	1019
Total cold run time: 107519 ms
Total hot run time: 34003 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5624	5440	5387	5387
q2	302	316	221	221
q3	2164	2565	2199	2199
q4	1285	1703	1312	1312
q5	4338	4333	4430	4333
q6	229	177	143	143
q7	1969	1925	1769	1769
q8	2586	2565	2418	2418
q9	7114	7451	7498	7451
q10	3185	3460	2917	2917
q11	551	518	478	478
q12	1025	772	610	610
q13	3430	3732	3231	3231
q14	290	319	296	296
q15	498	439	462	439
q16	436	548	492	492
q17	1205	1537	1334	1334
q18	8156	7795	7881	7795
q19	10454	892	796	796
q20	3119	1886	1754	1754
q21	11355	4340	4299	4299
q22	1129	1036	969	969
Total cold run time: 70444 ms
Total hot run time: 50643 ms

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

TPC-DS: Total hot run time: 170542 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c68aafa55cc3f82155205c873887e587af71859, data reload: false

============================================
query1	991	413	439	413
query2	6509	1763	1712	1712
query3	6745	238	221	221
query4	26801	23430	22928	22928
query5	4302	612	535	535
query6	316	236	245	236
query7	4644	518	290	290
query8	272	237	220	220
query9	8579	3021	3018	3018
query10	471	363	296	296
query11	15830	14985	14951	14951
query12	182	135	135	135
query13	1666	540	423	423
query14	8550	5859	5949	5859
query15	211	191	161	161
query16	7471	671	479	479
query17	1223	760	635	635
query18	2152	446	330	330
query19	237	209	199	199
query20	147	151	149	149
query21	219	127	105	105
query22	3912	3966	4050	3966
query23	34721	34396	34430	34396
query24	8056	2377	2389	2377
query25	562	512	425	425
query26	1232	286	160	160
query27	2649	485	358	358
query28	4346	2345	2344	2344
query29	778	656	476	476
query30	301	232	200	200
query31	902	789	688	688
query32	88	79	83	79
query33	567	413	373	373
query34	838	852	524	524
query35	803	827	752	752
query36	1028	1054	899	899
query37	137	110	86	86
query38	3983	4008	3865	3865
query39	1443	1376	1363	1363
query40	240	140	130	130
query41	63	59	54	54
query42	139	121	126	121
query43	534	520	473	473
query44	1414	894	872	872
query45	204	197	182	182
query46	944	1061	670	670
query47	1756	1824	1735	1735
query48	395	427	316	316
query49	709	511	418	418
query50	662	687	403	403
query51	4219	4204	4132	4132
query52	129	129	121	121
query53	257	288	220	220
query54	654	641	568	568
query55	89	87	88	87
query56	366	351	341	341
query57	1204	1221	1144	1144
query58	330	347	328	328
query59	2632	2689	2614	2614
query60	391	389	375	375
query61	123	123	119	119
query62	789	765	639	639
query63	249	211	217	211
query64	4290	1085	811	811
query65	4159	4128	4140	4128
query66	1074	447	326	326
query67	query68	18334	887	1001	887
query69	1009	279	289	279
query70	1409	1094	1101	1094
query71	665	315	323	315
query72	9023	2242	2262	2242
query73	4506	654	365	365
query74	8932	8885	8918	8885
query75	7051	3118	2660	2660
query76	8385	1206	795	795
query77	1166	409	329	329
query78	9612	10623	9471	9471
query79	15054	596	566	566
query80	1231	545	483	483
query81	553	261	230	230
query82	449	156	120	120
query83	304	296	273	273
query84	298	108	79	79
query85	882	371	334	334
query86	367	319	301	301
query87	4246	4188	4051	4051
query88	5549	2261	2272	2261
query89	491	369	315	315
query90	2545	227	230	227
query91	146	142	113	113
query92	91	75	68	68
query93	6172	980	660	660
query94	1044	412	285	285
query95	427	336	320	320
query96	527	593	285	285
query97	2678	2777	2555	2555
query98	258	232	229	229
query99	1472	1406	1301	1301
Total cold run time: 306755 ms
Total hot run time: 170542 ms

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

ClickBench: Total hot run time: 33.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c68aafa55cc3f82155205c873887e587af71859, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.26	0.07	0.07
query4	1.62	0.11	0.11
query5	0.41	0.42	0.43
query6	1.15	0.67	0.68
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.56	0.49	0.48
query10	0.52	0.54	0.52
query11	0.16	0.10	0.10
query12	0.14	0.10	0.10
query13	0.67	0.66	0.65
query14	0.94	1.12	1.07
query15	0.95	0.87	0.88
query16	0.38	0.38	0.38
query17	1.06	1.07	1.04
query18	0.22	0.20	0.20
query19	2.07	1.94	1.82
query20	0.01	0.01	0.01
query21	15.37	0.85	0.56
query22	0.76	1.12	0.77
query23	14.85	1.17	0.65
query24	6.41	1.17	0.77
query25	0.48	0.21	0.10
query26	0.57	0.16	0.13
query27	0.06	0.05	0.06
query28	9.59	0.87	0.45
query29	12.59	3.82	3.35
query30	3.10	2.97	2.94
query31	2.82	0.56	0.40
query32	3.24	0.56	0.52
query33	3.05	3.20	3.24
query34	16.15	5.29	5.09
query35	4.91	5.06	5.01
query36	0.68	0.51	0.49
query37	0.10	0.08	0.07
query38	0.06	0.05	0.05
query39	0.04	0.03	0.03
query40	0.17	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 106.46 s
Total hot run time: 33.48 s

@doris-robot
Copy link

doris-robot commented Aug 7, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.83% (16539/28111)
Line Coverage 47.78% (150115/314165)
Region Coverage 36.70% (112630/306863)
Branch Coverage 39.65% (50038/126195)

@freemandealer
Copy link
Contributor Author

freemandealer commented Aug 7, 2025

run vault_p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Aug 7, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 7, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.38% (22452/27590)
Line Coverage 74.12% (232820/314107)
Region Coverage 61.50% (193778/315068)
Branch Coverage 65.52% (83685/127723)

dataroaring
dataroaring approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 76c92c9 into apache:master Aug 10, 2025
26 of 29 checks passed
freemandealer added a commit to freemandealer/doris that referenced this pull request Aug 28, 2025
@freemandealer
[test](filecache) fix lru dumper test (apache#54456)
8c0ebdf 
fix incorrect dumper file name and use directory to contain all the test
dump files to make test clean.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Aug 28, 2025
@freemandealer
[test](filecache) fix lru dumper test (apache#54456)
8d6b062 
fix incorrect dumper file name and use directory to contain all the test
dump files to make test clean.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@morrySnow morrySnow mentioned this pull request Aug 28, 2025
Merged
morrySnow pushed a commit that referenced this pull request Aug 28, 2025
@freemandealer
branch-3.1: [test](filecache) fix lru dumper test #54456 (#55403)
57b36eb 
picked from #54456

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @hello-stephen @doris-robot @Yukang-Lian @dataroaring @morrySnow