Skip to content

branch-3.1: [test](filecache) fix lru dumper test #54456 #55403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 28, 2025
Merged

branch-3.1: [test](filecache) fix lru dumper test #54456 #55403

morrySnow merged 1 commit into from
Aug 28, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Aug 28, 2025 •
edited by morrySnow
Loading

picked from #54456

@freemandealer
[test](filecache) fix lru dumper test (apache#54456)
8d6b062 
fix incorrect dumper file name and use directory to contain all the test
dump files to make test clean.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas
Copy link
Contributor

Thearas commented Aug 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Aug 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

TPC-H: Total hot run time: 32603 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d6b06214840d91eaae9bc2e54d814bc63eef801, data reload: false

------ Round 1 ----------------------------------
q1	17581	5654	5457	5457
q2	2053	301	155	155
q3	10419	1278	737	737
q4	10201	873	462	462
q5	7662	2395	2149	2149
q6	186	170	136	136
q7	901	735	619	619
q8	9321	1426	1132	1132
q9	5266	4889	5022	4889
q10	6789	2284	1827	1827
q11	489	284	274	274
q12	336	355	213	213
q13	17767	3615	3031	3031
q14	226	229	211	211
q15	531	463	460	460
q16	408	426	372	372
q17	577	869	374	374
q18	6954	6581	6395	6395
q19	1078	970	553	553
q20	335	340	205	205
q21	2788	2202	1959	1959
q22	1050	1027	993	993
Total cold run time: 102918 ms
Total hot run time: 32603 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5563	5568	5535	5535
q2	235	333	237	237
q3	2210	2637	2286	2286
q4	1402	1838	1402	1402
q5	4414	4878	5020	4878
q6	167	167	129	129
q7	2037	1994	1820	1820
q8	2636	2849	2716	2716
q9	7269	7099	7211	7099
q10	3024	3289	2778	2778
q11	571	530	494	494
q12	651	783	594	594
q13	3347	3776	3174	3174
q14	282	313	274	274
q15	522	477	469	469
q16	454	481	432	432
q17	1215	1756	1278	1278
q18	7620	7384	7334	7334
q19	787	1191	1026	1026
q20	2000	2023	1906	1906
q21	5145	4878	4645	4645
q22	1125	1089	1049	1049
Total cold run time: 52676 ms
Total hot run time: 51555 ms

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

TPC-DS: Total hot run time: 190653 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d6b06214840d91eaae9bc2e54d814bc63eef801, data reload: false

query1	982	398	422	398
query2	6531	1954	1845	1845
query3	6705	216	222	216
query4	34257	23740	23476	23476
query5	4318	612	464	464
query6	264	208	174	174
query7	4625	495	331	331
query8	296	239	246	239
query9	9694	2639	2605	2605
query10	481	344	276	276
query11	18439	15462	15213	15213
query12	158	109	105	105
query13	1645	552	411	411
query14	10161	6625	7161	6625
query15	213	195	176	176
query16	7887	673	521	521
query17	1759	794	569	569
query18	2298	424	323	323
query19	238	192	156	156
query20	122	119	113	113
query21	199	128	107	107
query22	4572	4814	4474	4474
query23	34933	33145	33830	33145
query24	7241	2614	2594	2594
query25	480	458	395	395
query26	1219	285	169	169
query27	1939	484	336	336
query28	5211	2164	2106	2106
query29	650	554	443	443
query30	255	187	155	155
query31	1018	881	784	784
query32	71	56	57	56
query33	519	361	308	308
query34	738	821	513	513
query35	757	778	722	722
query36	987	1033	953	953
query37	105	96	69	69
query38	3931	3926	3834	3834
query39	1564	1420	1423	1420
query40	206	114	102	102
query41	52	49	49	49
query42	112	101	103	101
query43	506	495	479	479
query44	1332	798	796	796
query45	186	173	178	173
query46	878	1041	679	679
query47	1873	1890	1878	1878
query48	410	420	348	348
query49	815	509	432	432
query50	671	679	425	425
query51	7170	7256	7123	7123
query52	103	104	96	96
query53	239	258	194	194
query54	550	556	472	472
query55	90	80	83	80
query56	284	301	259	259
query57	1206	1243	1192	1192
query58	250	226	234	226
query59	2848	3114	2807	2807
query60	318	307	292	292
query61	144	149	156	149
query62	809	726	682	682
query63	238	200	197	197
query64	4058	1090	722	722
query65	3274	3208	3225	3208
query66	1080	419	325	325
query67	16172	15983	15810	15810
query68	5086	847	557	557
query69	502	317	286	286
query70	1189	1108	1116	1108
query71	504	301	274	274
query72	5772	3808	3796	3796
query73	635	741	353	353
query74	10231	9088	9350	9088
query75	3191	3149	2709	2709
query76	3229	1160	755	755
query77	512	371	280	280
query78	10408	10537	9645	9645
query79	2981	892	613	613
query80	1535	541	456	456
query81	582	259	217	217
query82	683	116	92	92
query83	169	175	156	156
query84	239	103	84	84
query85	804	398	303	303
query86	454	316	302	302
query87	4279	4328	4310	4310
query88	5318	2402	2382	2382
query89	394	341	298	298
query90	1883	190	192	190
query91	144	151	112	112
query92	70	62	54	54
query93	2713	883	536	536
query94	799	425	320	320
query95	349	278	275	275
query96	483	602	291	291
query97	3233	3258	3176	3176
query98	229	211	194	194
query99	1392	1438	1326	1326
Total cold run time: 293328 ms
Total hot run time: 190653 ms

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

ClickBench: Total hot run time: 28.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d6b06214840d91eaae9bc2e54d814bc63eef801, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.51	0.53	0.52
query6	1.14	0.75	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.59	0.51	0.52
query10	0.56	0.55	0.55
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.60	0.58
query14	0.78	0.77	0.82
query15	0.84	0.83	0.83
query16	0.39	0.41	0.39
query17	1.01	1.09	1.03
query18	0.26	0.23	0.23
query19	1.83	1.82	1.78
query20	0.02	0.01	0.01
query21	15.41	0.89	0.57
query22	0.74	0.70	0.64
query23	15.21	1.44	0.56
query24	3.27	0.97	1.18
query25	0.17	0.20	0.19
query26	0.26	0.17	0.14
query27	0.05	0.04	0.04
query28	13.40	1.03	0.43
query29	12.57	3.98	3.26
query30	0.26	0.10	0.07
query31	2.81	0.57	0.37
query32	3.23	0.54	0.46
query33	3.03	3.02	3.03
query34	16.69	5.27	4.53
query35	4.58	4.55	4.54
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.04	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.66 s
Total hot run time: 28.99 s

@doris-robot
Copy link

doris-robot commented Aug 28, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.48% (12723/27973)
Line Coverage 36.36% (113408/311905)
Region Coverage 34.00% (64927/190964)
Branch Coverage 31.04% (34087/109812)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 28, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.38% (21007/27503)
Line Coverage 69.75% (216819/310848)
Region Coverage 67.76% (129887/191698)
Branch Coverage 61.31% (67630/110304)

@morrySnow morrySnow changed the title [test](filecache) fix lru dumper test (#54456) branch-3.1: [test](filecache) fix lru dumper test #54456 Aug 28, 2025
@morrySnow morrySnow merged commit 57b36eb into apache:branch-3.1 Aug 28, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @Thearas @doris-robot @hello-stephen @gavinchou @morrySnow