Skip to content

[opt](recycler) Add concurrency recycle for tmp rowset #52677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 4 commits into from
Sep 4, 2025
Merged

[opt](recycler) Add concurrency recycle for tmp rowset #52677

gavinchou merged 4 commits into from
Sep 4, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Jul 2, 2025

What problem does this PR solve?

after pr

Concurrency Trial 1 Trial 2 Trial 3
1 38973 36734 34172
5 20714 20136 22548
10 14780 15022 15851

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch 2 times, most recently from 6e745cb to 66e512b Compare July 3, 2025 10:03
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 3, 2025

run buildall

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch 2 times, most recently from a748742 to 125c291 Compare July 4, 2025 06:52
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 4, 2025

run cloudut

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch 2 times, most recently from f1f3635 to c5b2f1b Compare July 4, 2025 07:10
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 4, 2025

run cloudut

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (32/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.93% (1219/1470)
Line Coverage 67.58% (21088/31203)
Region Coverage 67.27% (10486/15589)
Branch Coverage 56.60% (5490/9700)

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from c5b2f1b to 0dea5b6 Compare July 4, 2025 07:36
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 4, 2025

run cloudut

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from 0dea5b6 to dc31f19 Compare July 4, 2025 08:10
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 4, 2025

run cloudut

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch 2 times, most recently from 6f469ff to 79f4f62 Compare July 4, 2025 08:42
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Jul 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 4, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (29/29) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.93% (1219/1470)
Line Coverage 67.51% (21062/31200)
Region Coverage 67.26% (10485/15589)
Branch Coverage 56.64% (5494/9700)

gavinchou
gavinchou reviewed Jul 10, 2025
View reviewed changes
gavinchou
gavinchou reviewed Jul 11, 2025
View reviewed changes
@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from 79f4f62 to f8eab8b Compare July 20, 2025 15:06
@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from da09027 to bcf9502 Compare August 12, 2025 07:14
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Aug 12, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 12, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (28/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.61% (1423/1702)
Line Coverage 66.84% (24236/36261)
Region Coverage 67.86% (12066/17780)
Branch Coverage 57.47% (6337/11026)

gavinchou
gavinchou previously approved these changes Aug 13, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

PR approved by anyone and no changes requested.

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from 6b363a6 to 70dcfdd Compare September 1, 2025 04:41
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 1, 2025

run buildall

@wyxxxcat wyxxxcat force-pushed the conc_recycle_tmp_rs branch from 70dcfdd to 29a5745 Compare September 1, 2025 06:24
@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 1, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 1, 2025

Cloud UT Coverage Report

Increment line coverage 100.00% (37/37) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 84.49% (1465/1734)
Line Coverage 67.69% (26155/38640)
Region Coverage 68.62% (12985/18922)
Branch Coverage 58.58% (6945/11856)

@gavinchou gavinchou merged commit 0af28af into apache:master Sep 4, 2025
26 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
@wyxxxcat @wenzhenghu
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
a0d30a9 
after pr

| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1           | 38973   | 36734   | 34172   |
| 5           | 20714   | 20136   | 22548   |
| 10          | 14780   | 15022   | 15851   |
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Sep 28, 2025
@wyxxxcat
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
b044bde 
after pr

| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1           | 38973   | 36734   | 34172   |
| 5           | 20714   | 20136   | 22548   |
| 10          | 14780   | 15022   | 15851   |
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Sep 28, 2025
@wyxxxcat
[opt](recycler) Add concurrency recycle for tmp rowset (apache#52677)
610d0ea 
after pr

| Concurrency | Trial 1 | Trial 2 | Trial 3 |
|-------------|---------|---------|---------|
| 1           | 38973   | 36734   | 34172   |
| 5           | 20714   | 20136   | 22548   |
| 10          | 14780   | 15022   | 15851   |
@wyxxxcat wyxxxcat mentioned this pull request Sep 28, 2025
Merged
morrySnow pushed a commit that referenced this pull request Sep 29, 2025
@wyxxxcat
branch-3.1: [opt](recycler) Add concurrency recycle for tmp rowset #5…
8726a0e 
…2677 (#56573)

pick: #52677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wyxxxcat @Thearas @doris-robot @hello-stephen @gavinchou @Yukang-Lian @dataroaring @morrySnow