[Bug](distinct) fix distinct function with over return error result #51875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33740 ms |
TPC-DS: Total hot run time: 192588 ms |
ClickBench: Total hot run time: 29.38 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33823 ms |
TPC-DS: Total hot run time: 185993 ms |
ClickBench: Total hot run time: 29.28 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
HappenLee
reviewed
Jun 18, 2025
Contributor
Author
|
run buildall |
7a8f4bd to
c578792
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33902 ms |
TPC-DS: Total hot run time: 185985 ms |
ClickBench: Total hot run time: 29.72 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
ClickBench: Total hot run time: 29.69 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Jun 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
github-actions bot
pushed a commit
that referenced
this pull request
Jun 25, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
dataroaring
pushed a commit
that referenced
this pull request
Jun 26, 2025
…51875) ### What problem does this PR solve? Problem Summary: before the result is not correctly, as after insert the rows, should reset all state of nested function. So the result of the next line will not be affected by the previous one ``` mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi; +------+------+----------------------------------------+ | id | v1 | multi_distinct_group_concat(v2) over() | +------+------+----------------------------------------+ | 3 | 1 | a | | 1 | 1 | a,a | | 1 | 1 | a,a,a | | 2 | 1 | a,a,a,a | +------+------+----------------------------------------+ 4 rows in set (0.21 sec) mysql> select id, v1, multi_distinct_sum(v1) over() from multi; +------+------+-------------------------------+ | id | v1 | multi_distinct_sum(v1) over() | +------+------+-------------------------------+ | 1 | 1 | 1 | | 1 | 1 | 2 | | 2 | 1 | 3 | | 3 | 1 | 4 | +------+------+-------------------------------+ 4 rows in set (0.06 sec) ```
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jul 3, 2025
…ror result apache#51875 (apache#52312) Cherry-picked from apache#51875 Co-authored-by: zhangstar333 <zhangsida@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
before the result is not correctly, as after insert the rows, should reset all state of nested function.
So the result of the next line will not be affected by the previous one
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)