Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51875

@github-actions github-actions bot requested a review from morrySnow as a code owner June 25, 2025 11:41
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…51875)

### What problem does this PR solve?
Problem Summary:
before the result is not correctly, as after insert the rows, should
reset all state of nested function.
So the result of the next line will not be affected by the previous one
```
mysql> select id, v1, multi_distinct_group_concat(v2) over() from multi;
+------+------+----------------------------------------+
| id   | v1   | multi_distinct_group_concat(v2) over() |
+------+------+----------------------------------------+
|    3 |    1 | a                                      |
|    1 |    1 | a,a                                    |
|    1 |    1 | a,a,a                                  |
|    2 |    1 | a,a,a,a                                |
+------+------+----------------------------------------+
4 rows in set (0.21 sec)

mysql> select id, v1, multi_distinct_sum(v1) over() from multi;
+------+------+-------------------------------+
| id   | v1   | multi_distinct_sum(v1) over() |
+------+------+-------------------------------+
|    1 |    1 |                             1 |
|    1 |    1 |                             2 |
|    2 |    1 |                             3 |
|    3 |    1 |                             4 |
+------+------+-------------------------------+
4 rows in set (0.06 sec)
```
@dataroaring dataroaring force-pushed the auto-pick-51875-branch-3.1 branch from e0ecf7d to 2c7f025 Compare June 26, 2025 02:19
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.95% (11323/26989)
Line Coverage 32.63% (96825/296745)
Region Coverage 31.79% (50106/157609)
Branch Coverage 28.46% (25952/91172)

@morrySnow morrySnow merged commit 976b4d6 into branch-3.1 Jun 27, 2025
23 of 28 checks passed
@github-actions github-actions bot deleted the auto-pick-51875-branch-3.1 branch June 27, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants