Skip to content

Conversation

@morningman
Copy link
Contributor

This reverts commit 9c9992e.

Proposed changes

The PR #4925 will cause BE crash by following case:

CREATE TABLE `tbl1` (
  `k1` int(11) NULL COMMENT "",
  `k2` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`k1`, `k2`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_num" = "1",
"in_memory" = "false",
"storage_format" = "V2"
);

insert into tbl1 values(1,2);
delete from tbl1 where k1=1;
alter table tbl1 modify column k2 bigint key;

BE will crash when doing schema change with delete condition.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

@morningman morningman added the kind/revert Revert a previous commit label Dec 5, 2020
@EmmyMiao87 EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Dec 5, 2020
@acelyc111
Copy link
Member

Sorry about that, I'll try to fix it this weekend. Anyway, you can revert it before I fix it.

Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 merged commit c440aa0 into apache:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/revert Revert a previous commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants