[Refactor] Refactor DeleteHandler and Cond module #4925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae68a0f to
edd1ef5
Compare
morningman
reviewed
Nov 21, 2020
| _has_sequence_col = true; | ||
| break; | ||
| } | ||
| DCHECK_NE(_sequence_col_idx, -1); |
Member
Author
There was a problem hiding this comment.
@morningman Because has_sequence_col() in line 600 is inline bool has_sequence_col() const { return _sequence_col_idx != -1; }, so _sequence_col_idx shoule always be -1 here.
963f6ca to
780999e
Compare
352b777 to
8e9656a
Compare
8e9656a to
5f48dba
Compare
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 4, 2020
Introduced due to conflict of apache#5018 and apache#4925
Closed
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 5, 2020
This reverts commit 9c9992e.
1 task
EmmyMiao87
pushed a commit
that referenced
this pull request
Dec 5, 2020
acelyc111
added a commit
to acelyc111/incubator-doris
that referenced
this pull request
Dec 6, 2020
This patch mainly do the following refactors: - Use int64_t instead of int32_t for 'version' in DeleteHandler - Move some comments from .cpp to .h file, add some new comments in .h files, and also remove some meaningless comments - Use switch...case... instead of multiple if..else.. for DeleteConditionHandler::is_condition_value_valid - Use range loop to simplify code - Reduce some compare operations in Cond::del_eval - Improve some branch predictions in Reader - Fix and improve some unit tests
2 tasks
yangzhg
pushed a commit
that referenced
this pull request
Dec 8, 2020
* [Refactor] Refactor DeleteHandler and Cond module (#4925) This patch mainly do the following refactors: - Use int64_t instead of int32_t for 'version' in DeleteHandler - Move some comments from .cpp to .h file, add some new comments in .h files, and also remove some meaningless comments - Use switch...case... instead of multiple if..else.. for DeleteConditionHandler::is_condition_value_valid - Use range loop to simplify code - Reduce some compare operations in Cond::del_eval - Improve some branch predictions in Reader - Fix and improve some unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch mainly do the following refactors:
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.