[Fix](function) fix wrong floor of function date_diff when unit less than day #49429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34530 ms |
TPC-DS: Total hot run time: 193291 ms |
ClickBench: Total hot run time: 30.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34442 ms |
TPC-DS: Total hot run time: 193758 ms |
ClickBench: Total hot run time: 31.5 s |
21e42b1 to
948f899
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34233 ms |
TPC-DS: Total hot run time: 192889 ms |
ClickBench: Total hot run time: 31.91 s |
Merged
16 tasks
948f899 to
30bbabb
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34371 ms |
TPC-DS: Total hot run time: 194831 ms |
ClickBench: Total hot run time: 30.87 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BiteTheDDDDt
previously approved these changes
Mar 28, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
May 6, 2025
…than day (apache#49429) Issue Number: close #xxx Related PR: #xxx Problem Summary: should consider the microseconds' effect. before: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 24 | +------------------------------------------------------------+ ``` now: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 23 | +------------------------------------------------------------+ ``` fix the wrong floor of function date_diff when unit less than day - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
May 6, 2025
…than day (apache#49429) Issue Number: close #xxx Related PR: #xxx Problem Summary: should consider the microseconds' effect. before: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 24 | +------------------------------------------------------------+ ``` now: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 23 | +------------------------------------------------------------+ ``` fix the wrong floor of function date_diff when unit less than day - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
May 6, 2025
…than day (apache#49429) Issue Number: close #xxx Related PR: #xxx Problem Summary: should consider the microseconds' effect. before: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 24 | +------------------------------------------------------------+ ``` now: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 23 | +------------------------------------------------------------+ ``` fix the wrong floor of function date_diff when unit less than day - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…than day (apache#49429) Issue Number: close #xxx Related PR: #xxx Problem Summary: should consider the microseconds' effect. before: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 24 | +------------------------------------------------------------+ ``` now: ```sql mysql> select hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1'); +------------------------------------------------------------+ | hours_diff('2023-10-15 00:00:00', '2023-10-14 00:00:00.1') | +------------------------------------------------------------+ | 23 | +------------------------------------------------------------+ ``` fix the wrong floor of function date_diff when unit less than day - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
16 tasks
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Oct 15, 2025
…56893) ### What problem does this PR solve? Related PR: #49429 Problem Summary: only fix in 3.1 before: mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table; +-----------------------------------------------------------------+ | hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) | +-----------------------------------------------------------------+ | 103079215078 | +-----------------------------------------------------------------+ now: mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table; +-----------------------------------------------------------------+ | hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) | +-----------------------------------------------------------------+ | -24 | +-----------------------------------------------------------------+
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
…ev1 (apache#5237) pick apache#54967 Related PR: apache#49429 Problem Summary: before: ```sql mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table; +-----------------------------------------------------------------+ | hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) | +-----------------------------------------------------------------+ | 103079215078 | +-----------------------------------------------------------------+ ``` now: ```sql mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table; +-----------------------------------------------------------------+ | hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) | +-----------------------------------------------------------------+ | -24 | +-----------------------------------------------------------------+ ``` and make fe fold of `now()` return v2 type ### Release note Fix wrong calculation of timestampdiff of datetimev1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
should consider the microseconds' effect.
before:
now:
Release note
fix the wrong floor of function date_diff when unit less than day
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)