Skip to content

[fix](function) Fix wrong calculation of timestampdiff of datetimev1 #56893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 15, 2025
Merged

[fix](function) Fix wrong calculation of timestampdiff of datetimev1 #56893

morrySnow merged 1 commit into from
Oct 15, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Oct 13, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #49429

Problem Summary:

only fix in 3.1

before:

mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table;
+-----------------------------------------------------------------+
| hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) |
+-----------------------------------------------------------------+
|                                                    103079215078 |
+-----------------------------------------------------------------+

now:

mysql> select hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) from my_doris_table;
+-----------------------------------------------------------------+
| hours_diff(now(), date_format(event_date, '%Y-%m-%d %H:00:00')) |
+-----------------------------------------------------------------+
|                                                             -24 |
+-----------------------------------------------------------------+

and make fe fold of now() return v2 type

Release note

Fix wrong calculation of timestampdiff of datetimev1

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zclllyybb zclllyybb requested a review from morrySnow as a code owner October 13, 2025 06:14
@Thearas
Copy link
Contributor

Thearas commented Oct 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb zclllyybb mentioned this pull request Oct 13, 2025
Closed
16 tasks
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-H: Total hot run time: 32945 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71133b89f9c50c5fd1f63ea49bd8b2381d2558bf, data reload: false

------ Round 1 ----------------------------------
q1	17684	5488	5466	5466
q2	2046	404	281	281
q3	12333	1240	740	740
q4	10285	883	454	454
q5	8987	2409	2133	2133
q6	187	163	133	133
q7	902	732	619	619
q8	9327	1437	1202	1202
q9	5361	4967	4927	4927
q10	6776	2287	1836	1836
q11	480	280	264	264
q12	336	352	212	212
q13	17782	3597	3037	3037
q14	222	235	207	207
q15	518	473	454	454
q16	421	439	374	374
q17	619	881	376	376
q18	6942	6366	6501	6366
q19	1898	967	545	545
q20	328	331	219	219
q21	3076	2236	2111	2111
q22	1041	1045	989	989
Total cold run time: 107551 ms
Total hot run time: 32945 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5630	5504	5501	5501
q2	232	335	237	237
q3	2275	2649	2369	2369
q4	1402	1791	1393	1393
q5	4410	5095	5009	5009
q6	173	161	123	123
q7	2135	2005	1785	1785
q8	2638	2784	2757	2757
q9	7343	7385	7266	7266
q10	3041	3199	2712	2712
q11	598	509	501	501
q12	688	763	642	642
q13	3419	3774	3244	3244
q14	292	300	266	266
q15	521	457	471	457
q16	428	490	441	441
q17	1211	1731	1285	1285
q18	7709	7642	7377	7377
q19	828	1090	1113	1090
q20	2033	2046	1957	1957
q21	5332	4878	4523	4523
q22	1092	1087	1011	1011
Total cold run time: 53430 ms
Total hot run time: 51946 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 192529 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 71133b89f9c50c5fd1f63ea49bd8b2381d2558bf, data reload: false

query1	966	403	410	403
query2	6177	1963	1886	1886
query3	8678	207	206	206
query4	33650	23770	23461	23461
query5	3676	589	463	463
query6	298	198	195	195
query7	4207	509	325	325
query8	304	237	230	230
query9	9432	2614	2594	2594
query10	470	316	255	255
query11	18077	15392	15259	15259
query12	163	115	113	113
query13	1573	539	422	422
query14	9132	6762	7599	6762
query15	244	191	191	191
query16	8082	637	510	510
query17	1582	783	606	606
query18	2165	439	314	314
query19	226	193	174	174
query20	131	122	130	122
query21	206	131	110	110
query22	4593	4552	4528	4528
query23	35532	34449	34000	34000
query24	7765	2657	2698	2657
query25	549	514	446	446
query26	897	289	172	172
query27	2157	486	358	358
query28	5100	2279	2228	2228
query29	755	582	446	446
query30	245	192	157	157
query31	989	925	857	857
query32	91	63	57	57
query33	488	370	325	325
query34	744	864	534	534
query35	793	825	732	732
query36	1006	1053	974	974
query37	104	92	72	72
query38	4130	3986	3966	3966
query39	1588	1497	1705	1497
query40	205	120	111	111
query41	51	64	45	45
query42	123	102	102	102
query43	523	512	468	468
query44	1377	842	876	842
query45	184	180	173	173
query46	909	1060	702	702
query47	1966	1972	1928	1928
query48	404	423	364	364
query49	734	489	411	411
query50	690	691	433	433
query51	7320	7420	7146	7146
query52	101	103	94	94
query53	239	253	192	192
query54	566	555	471	471
query55	83	84	81	81
query56	305	278	272	272
query57	1274	1254	1238	1238
query58	242	216	220	216
query59	3076	3184	3006	3006
query60	295	305	268	268
query61	127	122	112	112
query62	787	748	712	712
query63	234	193	193	193
query64	3805	1029	637	637
query65	3387	3292	3279	3279
query66	863	441	317	317
query67	16312	15886	15669	15669
query68	4432	863	585	585
query69	496	304	270	270
query70	1167	1153	1114	1114
query71	375	300	264	264
query72	5897	3742	3885	3742
query73	663	749	363	363
query74	10557	9434	9177	9177
query75	3205	3173	2678	2678
query76	2982	1128	750	750
query77	462	370	283	283
query78	10288	10479	9601	9601
query79	2940	841	617	617
query80	707	521	448	448
query81	494	264	224	224
query82	529	120	91	91
query83	157	165	153	153
query84	240	110	86	86
query85	785	369	308	308
query86	385	309	277	277
query87	4356	4348	4252	4252
query88	5127	2436	2414	2414
query89	403	332	295	295
query90	1752	191	191	191
query91	142	149	114	114
query92	65	59	52	52
query93	2628	927	550	550
query94	651	412	312	312
query95	354	281	282	281
query96	501	612	286	286
query97	3158	3238	3134	3134
query98	234	206	197	197
query99	1316	1461	1331	1331
Total cold run time: 290595 ms
Total hot run time: 192529 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 28.19 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 71133b89f9c50c5fd1f63ea49bd8b2381d2558bf, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.11
query5	0.49	0.51	0.51
query6	1.15	0.72	0.73
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.50
query10	0.55	0.54	0.55
query11	0.14	0.10	0.10
query12	0.15	0.12	0.11
query13	0.61	0.60	0.60
query14	0.77	0.80	0.79
query15	0.84	0.84	0.82
query16	0.42	0.39	0.40
query17	1.08	1.05	0.99
query18	0.25	0.23	0.22
query19	1.92	1.79	1.93
query20	0.01	0.01	0.01
query21	15.46	0.94	0.56
query22	0.73	0.75	0.65
query23	15.22	1.43	0.52
query24	3.25	0.59	0.27
query25	0.15	0.06	0.04
query26	0.25	0.16	0.13
query27	0.06	0.05	0.05
query28	12.55	1.13	0.45
query29	12.63	4.10	3.36
query30	0.25	0.10	0.06
query31	2.83	0.62	0.38
query32	3.22	0.55	0.45
query33	3.01	3.03	3.03
query34	16.57	5.17	4.51
query35	4.57	4.64	4.57
query36	0.65	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.86 s
Total hot run time: 28.19 s

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-H: Total hot run time: 33046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 20b8b624a8a8827a0db93caf88bdc49660c0ab27, data reload: false

------ Round 1 ----------------------------------
q1	17582	5537	5526	5526
q2	2011	396	289	289
q3	12319	1257	796	796
q4	10558	881	471	471
q5	9641	2397	2150	2150
q6	190	165	135	135
q7	914	760	632	632
q8	9353	1444	1204	1204
q9	5224	4941	4938	4938
q10	6794	2280	1852	1852
q11	482	279	268	268
q12	346	371	217	217
q13	17801	3653	3041	3041
q14	235	224	223	223
q15	514	476	475	475
q16	423	438	372	372
q17	632	883	372	372
q18	6867	6450	6318	6318
q19	1222	967	576	576
q20	333	355	218	218
q21	2997	2278	2009	2009
q22	1081	964	1009	964
Total cold run time: 107519 ms
Total hot run time: 33046 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5619	5587	5524	5524
q2	235	328	238	238
q3	2316	2791	2364	2364
q4	1398	1798	1366	1366
q5	4461	5152	5154	5152
q6	173	167	130	130
q7	2111	2016	1878	1878
q8	2727	2887	2793	2793
q9	7314	7198	7252	7198
q10	3109	3253	2822	2822
q11	599	507	505	505
q12	670	793	612	612
q13	3456	3824	3188	3188
q14	283	300	275	275
q15	519	484	486	484
q16	457	481	434	434
q17	1249	1774	1268	1268
q18	7624	7520	7312	7312
q19	860	1198	1168	1168
q20	2027	2039	1927	1927
q21	5643	5097	4741	4741
q22	1085	1057	993	993
Total cold run time: 53935 ms
Total hot run time: 52372 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 193731 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 20b8b624a8a8827a0db93caf88bdc49660c0ab27, data reload: false

query1	954	403	401	401
query2	6207	1924	1884	1884
query3	8690	213	203	203
query4	33809	24630	23787	23787
query5	4292	619	458	458
query6	289	219	193	193
query7	4206	498	331	331
query8	320	252	249	249
query9	9361	2593	2583	2583
query10	480	325	260	260
query11	18162	15539	15212	15212
query12	157	103	103	103
query13	1544	522	406	406
query14	8915	7263	7219	7219
query15	244	189	182	182
query16	8099	661	516	516
query17	1571	762	624	624
query18	2125	420	329	329
query19	230	219	173	173
query20	130	128	124	124
query21	214	133	110	110
query22	4707	4608	4617	4608
query23	34659	34404	34052	34052
query24	7511	2704	2715	2704
query25	561	505	426	426
query26	861	292	177	177
query27	2222	495	366	366
query28	5492	2240	2225	2225
query29	737	604	479	479
query30	237	190	166	166
query31	1036	953	824	824
query32	92	63	67	63
query33	527	394	320	320
query34	768	859	529	529
query35	788	839	742	742
query36	992	1073	934	934
query37	107	90	67	67
query38	4090	4088	4045	4045
query39	1574	1477	1480	1477
query40	206	122	116	116
query41	48	55	48	48
query42	129	112	106	106
query43	524	507	488	488
query44	1378	856	840	840
query45	194	179	171	171
query46	890	1048	674	674
query47	2018	2009	1957	1957
query48	410	438	379	379
query49	721	490	403	403
query50	672	683	433	433
query51	7485	7362	7257	7257
query52	101	104	94	94
query53	231	255	188	188
query54	565	551	488	488
query55	82	83	87	83
query56	275	294	277	277
query57	1259	1288	1215	1215
query58	239	216	222	216
query59	3027	3188	3135	3135
query60	304	297	271	271
query61	119	113	118	113
query62	794	762	698	698
query63	251	202	190	190
query64	3746	1011	643	643
query65	3389	3306	3295	3295
query66	852	409	316	316
query67	16379	15861	15677	15677
query68	7857	832	566	566
query69	498	304	273	273
query70	1194	1117	1143	1117
query71	367	290	270	270
query72	5703	3899	3890	3890
query73	642	747	364	364
query74	10179	9543	9063	9063
query75	3213	3145	2668	2668
query76	3052	1197	760	760
query77	497	389	290	290
query78	10319	10552	9704	9704
query79	3648	900	595	595
query80	640	520	440	440
query81	476	253	222	222
query82	548	123	91	91
query83	170	164	145	145
query84	283	98	80	80
query85	782	363	305	305
query86	345	316	269	269
query87	4456	4416	4193	4193
query88	5354	2407	2407	2407
query89	416	331	296	296
query90	1817	193	193	193
query91	139	145	114	114
query92	65	55	54	54
query93	1930	933	559	559
query94	691	404	297	297
query95	350	285	276	276
query96	491	611	280	280
query97	3186	3257	3141	3141
query98	218	219	188	188
query99	1512	1433	1299	1299
Total cold run time: 294286 ms
Total hot run time: 193731 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 28.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 20b8b624a8a8827a0db93caf88bdc49660c0ab27, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.11	0.10
query5	0.50	0.51	0.54
query6	1.14	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.49
query10	0.56	0.54	0.54
query11	0.14	0.10	0.10
query12	0.13	0.12	0.11
query13	0.61	0.60	0.60
query14	0.79	0.78	0.80
query15	0.84	0.84	0.83
query16	0.37	0.39	0.40
query17	1.07	1.04	1.03
query18	0.24	0.22	0.22
query19	1.89	1.87	1.91
query20	0.02	0.01	0.02
query21	15.38	0.91	0.56
query22	0.74	0.79	0.72
query23	15.03	1.45	0.50
query24	3.24	1.50	0.64
query25	0.28	0.12	0.05
query26	0.24	0.15	0.13
query27	0.05	0.04	0.04
query28	13.56	1.00	0.43
query29	12.53	4.02	3.40
query30	0.25	0.09	0.07
query31	2.83	0.61	0.37
query32	3.22	0.54	0.46
query33	2.98	3.00	3.04
query34	16.60	5.20	4.53
query35	4.52	4.57	4.54
query36	0.65	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 103.49 s
Total hot run time: 28.68 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

FE UT Coverage Report

Increment line coverage 50.00% (2/4) 🎉
Increment coverage report
Complete coverage report

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 13, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-H: Total hot run time: 32809 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2fdae1034c135d4c2ee04287d4d364fba0ea04d4, data reload: false

------ Round 1 ----------------------------------
q1	17595	5453	5465	5453
q2	2031	391	282	282
q3	11940	1254	762	762
q4	10272	865	455	455
q5	9254	2379	2131	2131
q6	188	165	134	134
q7	901	755	622	622
q8	9346	1395	1136	1136
q9	5280	4978	4847	4847
q10	6796	2287	1835	1835
q11	521	293	265	265
q12	340	353	216	216
q13	17778	3623	3015	3015
q14	216	228	221	221
q15	524	467	458	458
q16	456	435	374	374
q17	620	871	377	377
q18	6826	6516	6465	6465
q19	1202	948	561	561
q20	333	348	209	209
q21	2977	2153	1996	1996
q22	1088	1022	995	995
Total cold run time: 106484 ms
Total hot run time: 32809 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5572	5529	5515	5515
q2	244	335	232	232
q3	2221	2638	2325	2325
q4	1375	1825	1389	1389
q5	4433	5003	4955	4955
q6	181	168	133	133
q7	2093	1983	1810	1810
q8	2608	2938	2703	2703
q9	7245	7257	7207	7207
q10	3056	3303	2735	2735
q11	579	493	491	491
q12	658	762	612	612
q13	3434	3826	3155	3155
q14	267	305	274	274
q15	512	482	468	468
q16	461	502	425	425
q17	1252	1738	1247	1247
q18	7493	7460	7376	7376
q19	851	1124	1069	1069
q20	1996	2038	1950	1950
q21	5307	4888	4671	4671
q22	1069	1040	1004	1004
Total cold run time: 52907 ms
Total hot run time: 51746 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

TPC-DS: Total hot run time: 191285 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2fdae1034c135d4c2ee04287d4d364fba0ea04d4, data reload: false

query1	941	405	402	402
query2	6221	1938	1904	1904
query3	8687	206	202	202
query4	33829	24148	23458	23458
query5	3726	597	453	453
query6	299	215	174	174
query7	4197	498	334	334
query8	306	240	229	229
query9	9435	2609	2605	2605
query10	481	330	276	276
query11	18198	15402	15444	15402
query12	160	113	108	108
query13	1553	540	423	423
query14	9584	7723	6583	6583
query15	270	186	187	186
query16	8133	703	528	528
query17	1582	785	594	594
query18	2151	437	328	328
query19	249	209	159	159
query20	125	123	122	122
query21	210	145	116	116
query22	4389	4702	4417	4417
query23	35137	34477	33832	33832
query24	7408	2696	2701	2696
query25	533	492	431	431
query26	824	289	178	178
query27	2059	497	353	353
query28	5440	2258	2209	2209
query29	729	607	477	477
query30	252	195	158	158
query31	1020	946	828	828
query32	88	67	63	63
query33	529	380	352	352
query34	761	901	529	529
query35	773	805	720	720
query36	1002	1096	987	987
query37	103	104	71	71
query38	4090	3977	3957	3957
query39	1524	1492	1467	1467
query40	210	120	103	103
query41	50	47	46	46
query42	120	103	101	101
query43	516	510	484	484
query44	1346	857	844	844
query45	191	182	174	174
query46	900	1055	709	709
query47	1991	2000	1944	1944
query48	411	438	346	346
query49	718	495	418	418
query50	689	692	447	447
query51	7384	7357	7307	7307
query52	113	103	91	91
query53	231	261	192	192
query54	558	547	457	457
query55	81	79	80	79
query56	270	269	265	265
query57	1281	1300	1209	1209
query58	225	215	220	215
query59	3097	3200	3170	3170
query60	313	284	265	265
query61	122	107	158	107
query62	817	794	718	718
query63	230	201	202	201
query64	4040	1004	678	678
query65	3381	3296	3307	3296
query66	799	422	310	310
query67	16535	15711	15509	15509
query68	7729	836	547	547
query69	491	303	272	272
query70	1168	1141	1130	1130
query71	381	299	267	267
query72	5666	2696	3910	2696
query73	646	746	359	359
query74	10257	9269	9014	9014
query75	3260	3152	2680	2680
query76	3199	1174	789	789
query77	700	374	280	280
query78	10311	10540	9700	9700
query79	3702	849	609	609
query80	738	533	447	447
query81	501	264	221	221
query82	583	126	93	93
query83	169	166	150	150
query84	282	103	82	82
query85	780	358	312	312
query86	356	311	277	277
query87	4376	4366	4246	4246
query88	4314	2434	2377	2377
query89	424	339	297	297
query90	1830	187	188	187
query91	141	142	108	108
query92	67	54	51	51
query93	1192	922	557	557
query94	678	427	316	316
query95	351	288	272	272
query96	495	610	284	284
query97	3197	3220	3158	3158
query98	221	209	211	209
query99	1577	1407	1302	1302
Total cold run time: 293399 ms
Total hot run time: 191285 ms

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

ClickBench: Total hot run time: 29.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fdae1034c135d4c2ee04287d4d364fba0ea04d4, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.52	0.52	0.50
query6	1.14	0.74	0.73
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.59	0.50	0.50
query10	0.56	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.59
query14	0.77	0.83	0.80
query15	0.85	0.84	0.82
query16	0.38	0.40	0.39
query17	1.06	1.01	1.06
query18	0.25	0.22	0.22
query19	1.94	1.83	1.81
query20	0.02	0.02	0.01
query21	15.40	0.88	0.54
query22	0.72	0.74	0.81
query23	15.04	1.38	0.61
query24	3.26	1.92	1.46
query25	0.20	0.24	0.05
query26	0.20	0.14	0.14
query27	0.06	0.04	0.05
query28	14.37	0.98	0.43
query29	12.58	4.10	3.39
query30	0.25	0.08	0.06
query31	2.84	0.58	0.37
query32	3.24	0.54	0.46
query33	3.04	3.03	3.04
query34	16.46	5.21	4.57
query35	4.59	4.59	4.53
query36	0.64	0.51	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 104.37 s
Total hot run time: 29.64 s

@morrySnow morrySnow changed the title [Fix-3.1](function) Fix wrong calculation of timestampdiff of datetimev1 [fix](function) Fix wrong calculation of timestampdiff of datetimev1 Oct 14, 2025
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Oct 14, 2025

run buildall

@zclllyybb zclllyybb requested a review from morrySnow October 14, 2025 13:54
@doris-robot
Copy link

doris-robot commented Oct 14, 2025

TPC-H: Total hot run time: 32566 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 91d34329787709bad800cfdf1477a6e528a0d8f8, data reload: false

------ Round 1 ----------------------------------
q1	17606	5454	5441	5441
q2	2033	404	280	280
q3	12079	1252	738	738
q4	10514	886	459	459
q5	9644	2414	2109	2109
q6	189	165	135	135
q7	901	735	604	604
q8	9325	1448	1140	1140
q9	5251	4987	4882	4882
q10	6757	2268	1812	1812
q11	463	279	257	257
q12	329	360	207	207
q13	17782	3751	2990	2990
q14	220	217	210	210
q15	533	463	477	463
q16	416	432	370	370
q17	603	878	381	381
q18	6935	6384	6390	6384
q19	1202	965	518	518
q20	333	341	220	220
q21	2832	2164	1973	1973
q22	1055	1038	993	993
Total cold run time: 107002 ms
Total hot run time: 32566 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5571	5494	5532	5494
q2	235	329	237	237
q3	2265	2592	2328	2328
q4	1325	1842	1371	1371
q5	4430	5018	4969	4969
q6	177	170	133	133
q7	2095	1903	1795	1795
q8	2633	2801	2698	2698
q9	7243	7257	7263	7257
q10	3049	3290	2744	2744
q11	578	518	496	496
q12	662	756	604	604
q13	3392	3811	3129	3129
q14	283	288	294	288
q15	518	477	459	459
q16	425	491	446	446
q17	1244	1729	1290	1290
q18	7547	7473	7387	7387
q19	833	883	1154	883
q20	2027	2060	1906	1906
q21	5415	4805	4546	4546
q22	1049	1046	1037	1037
Total cold run time: 52996 ms
Total hot run time: 51497 ms

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

TPC-DS: Total hot run time: 193145 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 91d34329787709bad800cfdf1477a6e528a0d8f8, data reload: false

query1	947	404	402	402
query2	6171	2001	1905	1905
query3	8678	209	213	209
query4	33851	23795	23515	23515
query5	3523	593	466	466
query6	290	217	193	193
query7	4219	513	319	319
query8	300	233	238	233
query9	9513	2605	2594	2594
query10	447	341	262	262
query11	18415	15424	15318	15318
query12	162	108	110	108
query13	1554	564	418	418
query14	8744	7315	6834	6834
query15	237	192	182	182
query16	8078	682	516	516
query17	1587	779	611	611
query18	2141	427	338	338
query19	206	200	180	180
query20	126	127	133	127
query21	207	129	108	108
query22	4427	4743	4399	4399
query23	35330	34158	34303	34158
query24	7608	2733	2756	2733
query25	547	495	447	447
query26	1168	296	176	176
query27	2389	474	367	367
query28	5436	2260	2228	2228
query29	792	622	462	462
query30	237	204	177	177
query31	1023	972	855	855
query32	98	69	61	61
query33	517	363	328	328
query34	763	855	535	535
query35	767	808	758	758
query36	1015	1048	966	966
query37	106	95	72	72
query38	4009	3972	3974	3972
query39	1588	1492	1466	1466
query40	218	118	105	105
query41	49	53	48	48
query42	125	104	108	104
query43	506	526	479	479
query44	1324	819	827	819
query45	183	182	173	173
query46	901	1071	680	680
query47	2026	2015	1936	1936
query48	409	451	348	348
query49	776	483	417	417
query50	683	702	426	426
query51	7542	7293	7401	7293
query52	107	99	90	90
query53	230	267	200	200
query54	557	561	471	471
query55	84	79	84	79
query56	280	287	261	261
query57	1256	1281	1243	1243
query58	241	217	221	217
query59	3009	3181	3056	3056
query60	301	288	288	288
query61	112	120	122	120
query62	778	775	699	699
query63	238	206	199	199
query64	4558	1024	651	651
query65	3381	3296	3333	3296
query66	1028	451	309	309
query67	16434	15788	15535	15535
query68	7705	837	560	560
query69	500	309	265	265
query70	1160	1161	1136	1136
query71	361	303	263	263
query72	5746	3829	3890	3829
query73	657	752	357	357
query74	10540	9453	9242	9242
query75	3199	3184	2718	2718
query76	3173	1182	777	777
query77	555	385	293	293
query78	10361	10412	9631	9631
query79	3770	915	614	614
query80	737	532	447	447
query81	523	263	216	216
query82	595	120	87	87
query83	178	160	145	145
query84	284	89	78	78
query85	780	369	303	303
query86	402	308	307	307
query87	4283	4388	4241	4241
query88	5180	2436	2502	2436
query89	417	340	292	292
query90	1817	192	189	189
query91	135	140	113	113
query92	68	54	52	52
query93	2274	908	552	552
query94	678	420	313	313
query95	349	282	272	272
query96	493	610	292	292
query97	3161	3290	3095	3095
query98	227	202	202	202
query99	1507	1450	1288	1288
Total cold run time: 296367 ms
Total hot run time: 193145 ms

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

ClickBench: Total hot run time: 29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 91d34329787709bad800cfdf1477a6e528a0d8f8, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.53	0.51	0.50
query6	1.14	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.50	0.50
query10	0.55	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.59
query14	0.79	0.81	0.77
query15	0.84	0.83	0.81
query16	0.38	0.39	0.39
query17	1.03	1.10	1.06
query18	0.24	0.22	0.22
query19	1.84	1.90	1.81
query20	0.01	0.02	0.01
query21	15.39	0.95	0.58
query22	0.75	1.02	0.79
query23	14.71	1.41	0.59
query24	3.43	0.70	2.37
query25	0.24	0.25	0.05
query26	0.24	0.14	0.13
query27	0.06	0.05	0.05
query28	13.75	0.96	0.44
query29	12.56	4.13	3.46
query30	0.24	0.08	0.07
query31	2.83	0.60	0.38
query32	3.22	0.55	0.46
query33	2.99	3.05	3.04
query34	16.77	5.18	4.56
query35	4.64	4.57	4.51
query36	0.63	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.14	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 103.79 s
Total hot run time: 29 s

@doris-robot
Copy link

doris-robot commented Oct 14, 2025

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.77% (12872/28121)
Line Coverage 36.66% (115252/314420)
Region Coverage 34.17% (65740/192363)
Branch Coverage 31.19% (34506/110640)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.38% (21125/27658)
Line Coverage 69.67% (218565/313719)
Region Coverage 67.60% (130643/193250)
Branch Coverage 61.21% (68061/111192)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.38% (21125/27658)
Line Coverage 69.67% (218553/313719)
Region Coverage 67.60% (130636/193250)
Branch Coverage 61.20% (68052/111192)

@morrySnow morrySnow merged commit 6eb4a80 into apache:branch-3.1 Oct 15, 2025
21 of 22 checks passed
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Closed
@zclllyybb zclllyybb deleted the tsdiff3.1 branch October 28, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

dev/3.1.2-merged p0_w

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zclllyybb @Thearas @doris-robot @hello-stephen @morrySnow