[Bug] Can not use non-key column as partition column in duplicate table #3916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c72a284 to
728b601
Compare
EmmyMiao87
reviewed
Jun 21, 2020
fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java
Outdated
Show resolved
Hide resolved
| for (Column column : schema) { | ||
| if (column.getName().equalsIgnoreCase(colName)) { | ||
| if (!column.isKey()) { | ||
| if (!column.isKey() && column.getAggregationType() != AggregateType.NONE) { |
Contributor
There was a problem hiding this comment.
Why does it need a second check here?
Contributor
Author
There was a problem hiding this comment.
Historical issues...
It is OK, may be removed in future.
…java Co-authored-by: EmmyMiao87 <522274284@qq.com>
EmmyMiao87
reviewed
Jun 21, 2020
fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: EmmyMiao87 <522274284@qq.com>
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 22, 2020
…le (apache#3916) The following statement will throw error: ``` create table test.tbl2 (k1 int, k2 int, k3 float) duplicate key(k1) partition by range(k2) (partition p1 values less than("10")) distributed by hash(k3) buckets 1 properties('replication_num' = '1'); ``` Error: `Only key column can be partition column` But in duplicate key table, columns can be partition or distribution column even if they are not in duplicate keys. This bug is introduced by apache#3812
suxiaogang223
pushed a commit
to suxiaogang223/doris
that referenced
this pull request
Jul 15, 2025
… policy on unique table (apache#49905) (apache#3916) pick apache#49905
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 21, 2025
… policy on unique table (apache#49905) (apache#3916) pick apache#49905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following statement will throw error:
Error:
Only key column can be partition columnBut in duplicate key table, columns can be partition or distribution column
even if they are not in duplicate keys.
This bug is introduced by #3812