Forbidden float column in short key #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Create table will forbidden float/double |
morningman
requested changes
Jun 9, 2020
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Already forbidden |
morningman
reviewed
Jun 10, 2020
fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
Outdated
Show resolved
Hide resolved
| rollupColumn.setAggregationType(null, false); | ||
| } | ||
| if (theBeginIndexOfValue == 0) { | ||
| throw new DdlException("The first column could not be float or double, use decimal instead."); |
Contributor
There was a problem hiding this comment.
use decimal instead can be removed. Because user has no choice.
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java
Outdated
Show resolved
Hide resolved
When the user does not specify the key column, doris will automatically supplement the key column. However, doris does not support float or double as the key column, so when adding the key column, doris should avoid setting those column as the key column. The CreateMaterailizedView, AddRollup and CreateDuplicateTable need to forbidden float column in short key. If the float column is directly encountered during the supplement process, the subsequent columns are all value columns. If the first column is float or double, Doris will throw the exception. Fixed apache#3811 Change-Id: Ib66d9355acefcd8f281906bcb7b4dd684319ff08
…iewStmt.java Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Change-Id: Ie1320d9af56083633c7634c1c3df485f3994da31
Change-Id: Ib4c4791847d522fa312efff4016787c9caeab785
For duplicate table without order by columns, the order by columns are same as short key columns. If the order by columns have been designated, the count of short key columns must be <= the count of order by columns. The short key columns must be less then 3 columns and less then 36 bytes. Also the float and double could not be the short key column. At the same time, doirs must be at least one short key column. So the type of first column could not be float or double. If the varchar is the short key column, it can only be the least one short key column. Change-Id: I46ec2c78e87d73c3f3aeeb815b9acc6dcfe280e0
Change-Id: Ia4d2a9bfb1b4321dc3ed8e2dd243d9a4fd2dbf69
Change-Id: I1d13600a39d59cf93feb42df85c1089ca1029615
Change-Id: Id647f940b81ebfc27e18ef83e5275af7177bf926
morningman
added a commit
that referenced
this pull request
Jun 22, 2020
…le (#3916) The following statement will throw error: ``` create table test.tbl2 (k1 int, k2 int, k3 float) duplicate key(k1) partition by range(k2) (partition p1 values less than("10")) distributed by hash(k3) buckets 1 properties('replication_num' = '1'); ``` Error: `Only key column can be partition column` But in duplicate key table, columns can be partition or distribution column even if they are not in duplicate keys. This bug is introduced by #3812
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 22, 2020
* Forbidden float column in short key When the user does not specify the short key column, doris will automatically supplement the short key column. However, doris does not support float or double as the short key column, so when adding the short key column, doris should avoid setting those column as the key column. The short key columns must be less then 3 columns and less then 36 bytes. The CreateMaterailizedView, AddRollup and CreateDuplicateTable need to forbidden float column in short key. If the float column is directly encountered during the supplement process, the subsequent columns are all value columns. Also the float and double could not be the short key column. At the same time, Doris must be at least one short key column. So the type of first column could not be float or double. If the varchar is the short key column, it can only be the least one short key column. Fixed apache#3811 For duplicate table without order by columns, the order by columns are same as short key columns. If the order by columns have been designated, the count of short key columns must be <= the count of order by columns.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 22, 2020
…le (apache#3916) The following statement will throw error: ``` create table test.tbl2 (k1 int, k2 int, k3 float) duplicate key(k1) partition by range(k2) (partition p1 values less than("10")) distributed by hash(k3) buckets 1 properties('replication_num' = '1'); ``` Error: `Only key column can be partition column` But in duplicate key table, columns can be partition or distribution column even if they are not in duplicate keys. This bug is introduced by apache#3812
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Mar 28, 2025
…pache#3812) File cache will only be clear when clear_cache is called if tablet meta no longer exists in ms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user does not specify the key column, doris will automatically supplement the key column.
However, doris does not support float or double as the key column, so when adding the key column, doris should avoid setting those column as the key column.
The CreateMaterailizedView, AddRollup and CreateDuplicateTable need to forbidden float column in short key.
If the float column is directly encountered during the supplement process, the subsequent columns are all value columns.
If the first column is float or double, Doris will throw the exception.
Fixed #3811
Change-Id: Ib66d9355acefcd8f281906bcb7b4dd684319ff08