Skip to content

[branch-2.0] Pick "[fix](partial update) Fix missing rowsets during doing alignment when flushing memtable due to compaction #28062" #28468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Dec 16, 2023
Merged

[branch-2.0] Pick "[fix](partial update) Fix missing rowsets during doing alignment when flushing memtable due to compaction #28062" #28468

xiaokang merged 1 commit into from
Dec 16, 2023

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 15, 2023

Proposed changes

picks #28062

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 15, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 15, 2023

TeamCity be ut coverage result:
Function Coverage: 37.81% (7988/21129)
Line Coverage: 29.48% (64826/219913)
Region Coverage: 28.95% (33356/115238)
Branch Coverage: 24.84% (17122/68938)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cce3823cea1961379ddc7ca91964793abcb1983c_cce3823cea1961379ddc7ca91964793abcb1983c/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 15, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 15, 2023

TeamCity be ut coverage result:
Function Coverage: 37.82% (7990/21129)
Line Coverage: 29.49% (64849/219913)
Region Coverage: 28.96% (33371/115238)
Branch Coverage: 24.85% (17129/68938)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cce3823cea1961379ddc7ca91964793abcb1983c_cce3823cea1961379ddc7ca91964793abcb1983c/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 15, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.51 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17167655425 Bytes

@xiaokang xiaokang merged commit 8c8f322 into apache:branch-2.0 Dec 16, 2023
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Dec 19, 2023
@liaoxin01
[Revert](partial update) Revert "Fix missing rowsets during doing ali…
35cef78 
…gnment when flushing memtable due to compaction apache#28062 (apache#28468)"

This reverts commit 8c8f322.
@liaoxin01 liaoxin01 mentioned this pull request Dec 19, 2023
Merged
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 19, 2023
@bobhan1
Revert "[fix](partial update) Fix missing rowsets during doing alignm…
d97b337 
…ent when flushing memtable due to compaction apache#28062 (apache#28468)"

This reverts commit 8c8f322.
@bobhan1 bobhan1 mentioned this pull request Dec 19, 2023
Merged
dataroaring pushed a commit that referenced this pull request Dec 20, 2023
@liaoxin01
[Revert](partial update) Revert "Fix missing rowsets during doing ali…
c16be3c 
…gnment when flushing memtable due to compaction #28062 (#28468)" (#28676)

This reverts commit 8c8f322.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @doris-robot @xiaokang