Skip to content

[Revert](partial update) Revert "Fix missing rowsets during doing alignment when flushing memtable due to compaction #28062 (#28468)" #28676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Dec 20, 2023
Merged

[Revert](partial update) Revert "Fix missing rowsets during doing alignment when flushing memtable due to compaction #28062 (#28468)" #28676

dataroaring merged 1 commit into from
Dec 20, 2023

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Dec 19, 2023 •
edited
Loading

This reverts commit 8c8f322.

Proposed changes

revert pr #28468 that may result in duplicate key for mow table.
pick from #28674

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01
[Revert](partial update) Revert "Fix missing rowsets during doing ali…
35cef78 
…gnment when flushing memtable due to compaction apache#28062 (apache#28468)"

This reverts commit 8c8f322.
@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Dec 19, 2023

run buildall

zhannngchen
zhannngchen approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 19, 2023

TeamCity be ut coverage result:
Function Coverage: 37.82% (7993/21136)
Line Coverage: 29.50% (64900/220031)
Region Coverage: 28.97% (33396/115268)
Branch Coverage: 24.85% (17138/68976)
Coverage Report: http://coverage.selectdb-in.cc/coverage/35cef780e0e8fd79b668a749c1f294e507a6dbd9_35cef780e0e8fd79b668a749c1f294e507a6dbd9/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 19, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.96 seconds
stream load tsv: 602 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17163231472 Bytes

dataroaring
dataroaring approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c16be3c into apache:branch-2.0 Dec 20, 2023
@bobhan1 bobhan1 mentioned this pull request Dec 20, 2023
Merged
@liaoxin01 liaoxin01 deleted the revert_28468 branch February 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liaoxin01 @doris-robot @zhannngchen @dataroaring