[Improve](sort) avoid too may tmp vectors for get_columns #27734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

xiaokang merged 2 commits into apache:master from eldenmoon:master

Nov 30, 2023

Member

eldenmoon commented Nov 29, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Member Author

eldenmoon commented Nov 29, 2023

run buildall

eldenmoon added the dev/2.0.4 label

Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"

Member Author

eldenmoon commented Nov 29, 2023

run buildall

Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"


          [Improve](sort) avoid too may tmp vectors for get_columns

51ae024

eldenmoon force-pushed the master branch 2 times, most recently from 8a8f07a to 51ae024 Compare

November 29, 2023 03:23

Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"


          Merge branch 'master' into master

e8346e5

Member Author

eldenmoon commented Nov 29, 2023

run buildall

Contributor

github-actions bot commented Nov 29, 2023

clang-tidy review says "All clean, LGTM! 👍"

doris-robot commented Nov 29, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.44 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17099309585 Bytes

yiguolei approved these changes

View reviewed changes

Contributor

yiguolei left a comment

lgtm

github-actions bot added the approved label

Contributor

github-actions bot commented Nov 29, 2023

PR approved by at least one committer and no changes requested.

github-actions bot added the reviewed label

Contributor

github-actions bot commented Nov 29, 2023

PR approved by anyone and no changes requested.

xiaokang approved these changes

View reviewed changes

Contributor

xiaokang left a comment

LGTM

xiaokang merged commit e9debca into apache:master

wm1581066 added the p0_b label

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request


          [Improve](sort) avoid too may tmp vectors for get_columns (apache#27734)

275ce6b

eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request


          [Improve](sort) avoid too may tmp vectors for get_columns (apache#27734)

45dc2d3

eldenmoon mentioned this pull request

[Pick](branch-2.0) pick some PRs about point query optimization #28611

Merged

xiaokang pushed a commit that referenced this pull request


          [Pick](branch-2.0) pick some PRs about point query optimization (#28611)

c03c92a

* [Fix](point query) fix memleak by increasing `scanReplicaIds` when using prepared statement (#28184)
* [Performance](point query)Opimize partition prune for point query (#28150)
* [Improve](sort) avoid too may tmp vectors for get_columns (#27734)

xiaokang added dev/2.0.4-merged and removed dev/2.0.4 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dev/2.0.4-merged p0_b reviewed