Skip to content

[Pick](branch-2.0) pick some PRs about point query optimization #28611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 3 commits into from
Dec 19, 2023
Merged

[Pick](branch-2.0) pick some PRs about point query optimization #28611

xiaokang merged 3 commits into from
Dec 19, 2023

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Dec 19, 2023

Proposed changes

  1. [Improve](sort) avoid too may tmp vectors for get_columns #27734
  2. [Performance](point query)Opimize partition prune for point query #28150
  3. [Fix](point query) fix memleak by increasing scanReplicaIds when using prepared statement #28184
    Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@eldenmoon
Copy link
Member Author

eldenmoon commented Dec 19, 2023

run buildall

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Dec 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 19, 2023

TeamCity be ut coverage result:
Function Coverage: 37.81% (7993/21139)
Line Coverage: 29.49% (64902/220084)
Region Coverage: 28.97% (33400/115291)
Branch Coverage: 24.84% (17138/68988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45dc2d3f4aede3be34cde3e1036f95f3594ebd36_45dc2d3f4aede3be34cde3e1036f95f3594ebd36/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 19, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.9 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162687079 Bytes

@xiaokang xiaokang merged commit c03c92a into apache:branch-2.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/planner Issues or PRs related to the query planner kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldenmoon @doris-robot @xiaokang