Skip to content

[branch-2.0][fix](outfile) Fix parquet writer wrong result issue #26027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 2 commits into from
Oct 31, 2023
Merged

[branch-2.0][fix](outfile) Fix parquet writer wrong result issue #26027

xiaokang merged 2 commits into from
Oct 31, 2023

Conversation

@BePPPower
Copy link
Contributor

@BePPPower BePPPower commented Oct 27, 2023 •
edited
Loading

Proposed changes

Issue Number: close #xxx

  1. fix a regression test
  2. Fixed a problem with parquet writer: null values in a parquet column do not have a corresponding value space, but null values in a doris column do have a reserved space. 【There is no such problem on the master branch, because master branch switched to use ARROW to write parquet file format】

fix a bug that fileSize is not correct, introduced by this pr: #25920

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman changed the title [fix](outfile) Fix parquet writer [branch-2.0][fix](outfile) Fix parquet writer wrong result issue Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor

xiaokang commented Oct 28, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 28, 2023

TeamCity be ut coverage result:
Function Coverage: 38.23% (7928/20738)
Line Coverage: 30.03% (64076/213381)
Region Coverage: 29.25% (33195/113504)
Branch Coverage: 25.06% (17056/68054)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69df10042a4ef6d1ed09bbe7f93c3b148ea5d438_69df10042a4ef6d1ed09bbe7f93c3b148ea5d438/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 28, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.98 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17167804365 Bytes

@morningman
Copy link
Contributor

morningman commented Oct 29, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 29, 2023

TeamCity be ut coverage result:
Function Coverage: 38.23% (7928/20738)
Line Coverage: 30.03% (64078/213381)
Region Coverage: 29.25% (33196/113504)
Branch Coverage: 25.07% (17059/68054)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b304e70c1840c7ca7b0dd8f731f15b82f8bbb182_b304e70c1840c7ca7b0dd8f731f15b82f8bbb182/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 29, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.03 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17167479370 Bytes

@BePPPower
Copy link
Contributor Author

BePPPower commented Oct 30, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 30, 2023

TeamCity be ut coverage result:
Function Coverage: 38.24% (7930/20738)
Line Coverage: 30.04% (64101/213381)
Region Coverage: 29.26% (33210/113504)
Branch Coverage: 25.08% (17065/68054)
Coverage Report: http://coverage.selectdb-in.cc/coverage/05e9e1ff80d0ddb3accd8c1237d16ff8f3832c28_05e9e1ff80d0ddb3accd8c1237d16ff8f3832c28/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 30, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.64 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162059287 Bytes

@BePPPower
Copy link
Contributor Author

BePPPower commented Oct 30, 2023

run p0

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 30, 2023

run p0

@xiaokang xiaokang merged commit 79608f9 into apache:branch-2.0 Oct 31, 2023
@morningman morningman mentioned this pull request Nov 1, 2023
Closed
3 tasks
@BePPPower BePPPower mentioned this pull request Nov 2, 2023
Merged
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@BePPPower
[branch-2.0][fix](outfile) Fix parquet writer wrong result issue (apa…
375adfd 
…che#26027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev/2.0.3-merged kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BePPPower @xiaokang @doris-robot @morningman @hello-stephen