[fix](Outfile) fix bug that it will core dump if the _schema fails to build in the open phase #25920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
This was referenced Oct 26, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
… build in the open phase apache#25920
yiguolei
pushed a commit
that referenced
this pull request
Aug 22, 2024
… build in the open phase (#39770) ## Proposed changes refer to: #25920 *** SIGSEGV address not mapped to object (@0x0) received by PID 73639 (TID 0x7f16ef041700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) in /usr/local/service/doris/lib/be/doris_be 1# os::Linux::chained_handler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 4# 0x00007F18DFB65400 in /lib64/libc.so.6 5# doris::vectorized::VOrcWriterWrapper::written_len() in /usr/local/service/doris/lib/be/doris_be 6# doris::vectorized::VFileResultWriter::_close_file_writer(bool, bool) in /usr/local/service/doris/lib/be/doris_be 7# doris::vectorized::VFileResultWriter::close() in /usr/local/service/doris/lib/be/doris_be 8# doris::vectorized::VResultFileSink::close(doris::RuntimeState*, doris::Status) in /usr/local/service/doris/lib/be/doris_be 9# doris::PlanFragmentExecutor::close() in /usr/local/service/doris/lib/be/doris_be 10# doris::PlanFragmentExecutor::~PlanFragmentExecutor() in /usr/local/service/doris/lib/be/doris_be 11# std::_Sp_counted_ptr<doris::FragmentExecState*, (__gnu_cxx::_Lock_policy)2>::_M_dispose() in /usr/local/service/doris/lib/be/doris_be 12# std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() in /usr/local/service/doris/lib/be/doris_be 13# doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&, std::function<void (doris::PlanFragmentExecutor*)>) in /usr/local/s ervice/doris/lib/be/doris_be 14# doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&) in /usr/local/service/doris/lib/be/doris_be 15# doris::PInternalServiceImpl::_exec_plan_fragment_impl(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, dor is::PFragmentRequestVersion, bool) in /usr/local/service/doris/lib/be/doris_be 16# doris::PInternalServiceImpl::_exec_plan_fragment_in_pthread(google::protobuf::RpcController*, doris::PExecPlanFragmentRequest const*, doris::PExe cPlanFragmentResult*, google::protobuf::Closure*) in /usr/local/service/doris/lib/be/doris_be 17# doris::PriorityThreadPool::work_thread(int) in /usr/local/service/doris/lib/be/doris_be 18# execute_native_thread_routine in /usr/local/service/doris/lib/be/doris_be 19# start_thread in /lib64/libpthread.so.0 20# __clone in /lib64/libc.so.6 <!--Describe your changes.--> Co-authored-by: derenli <derenli@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Refer: #25854
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...