-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[chore](macOS) Specify the version of LLVM for Homebrew to install it #17945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
|
run p0 |
|
run buildall |
|
run buildall |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
run p0 |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
BiteTheDDDDt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…apache#17945) Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.
…apache#17945) Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.
Backport: 1. [chore](macOS) Use LLVM Clang by default apache#17292 2. [chore](workflow) Fix the workflow BE UT (macOS) apache#17403 3. [chore](macOS) Disable detect_container_overflow at BE startup apache#17514 4. [chore](macOS) Specify the version of LLVM for Homebrew to install it apache#17945
Proposed changes
Issue Number: close #xxxProblem summary
Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...