Skip to content

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Mar 3, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail. See https://github.com/apache/doris/actions/runs/4322344391/jobs/7544647102.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147 adonis0147 changed the title [chore](workflow) Fix the BE UT (macOS) [chore](workflow) Fix the workflow BE UT (macOS) Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit c9179bd into apache:master Mar 3, 2023
@adonis0147 adonis0147 deleted the workflow branch March 3, 2023 15:35
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
adonis0147 added a commit to adonis0147/doris that referenced this pull request Apr 24, 2023
apache#17292 enabled detect_container_overflow which made the workflow BE UT (macOS) fail.
adonis0147 added a commit that referenced this pull request Apr 24, 2023
Backport:
1. [chore](macOS) Use LLVM Clang by default #17292
2. [chore](workflow) Fix the workflow BE UT (macOS) #17403
3. [chore](macOS) Disable detect_container_overflow at BE startup #17514
4. [chore](macOS) Specify the version of LLVM for Homebrew to install it #17945
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
Backport:
1. [chore](macOS) Use LLVM Clang by default apache#17292
2. [chore](workflow) Fix the workflow BE UT (macOS) apache#17403
3. [chore](macOS) Disable detect_container_overflow at BE startup apache#17514
4. [chore](macOS) Specify the version of LLVM for Homebrew to install it apache#17945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants