Skip to content

Conversation

@chenlinzhong
Copy link
Contributor

Proposed changes

Issue Number: close #16634

Problem summary

solve bthread hang problem

  • change task queue type from blocking queue to nonblocking queue

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman
Copy link
Contributor

run buildall

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 79e49da into apache:master Feb 28, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Apr 10, 2023
morningman added a commit to morningman/doris that referenced this pull request Apr 10, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 13, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 19, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 19, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit to morningman/doris that referenced this pull request Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman added a commit that referenced this pull request Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (#17435)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639)
2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206)
3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/1.2.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] replace brpc bthread with pthead

4 participants