[Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread #16639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
TeamCity pipeline, clickbench performance test result: |
morningman
reviewed
Feb 13, 2023
Contributor
|
Please also update this document: |
dataroaring
requested changes
Feb 13, 2023
eldenmoon
reviewed
Feb 13, 2023
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
resolved |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run p0 |
3 similar comments
Contributor
Author
|
run p0 |
Contributor
Author
|
run p0 |
Contributor
Author
|
run p0 |
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Feb 23, 2023
…:mutex block brpc::bthread (apache#16639) mainly include: - brpc service adds two types of thread pools. The number of "light" and "heavy" thread pools is different Classify the interfaces of be. Those related to data transmission are classified as heavy interfaces and others as light interfaces - Add some monitoring to the thread pool, including the queue size and the number of active threads. Use these - indicators to guide the configuration of the number of threads
5 tasks
morningman
pushed a commit
that referenced
this pull request
Feb 23, 2023
…:mutex block brpc::bthread (#16639) mainly include: - brpc service adds two types of thread pools. The number of "light" and "heavy" thread pools is different Classify the interfaces of be. Those related to data transmission are classified as heavy interfaces and others as light interfaces - Add some monitoring to the thread pool, including the queue size and the number of active threads. Use these - indicators to guide the configuration of the number of threads
morningman
added a commit
to morningman/doris
that referenced
this pull request
Feb 27, 2023
…ing std::mutex block brpc::bthread (apache#16639)" This reverts commit 8534abc.
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…:mutex block brpc::bthread (apache#16639) mainly include: - brpc service adds two types of thread pools. The number of "light" and "heavy" thread pools is different Classify the interfaces of be. Those related to data transmission are classified as heavy interfaces and others as light interfaces - Add some monitoring to the thread pool, including the queue size and the number of active threads. Use these - indicators to guide the configuration of the number of threads
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 10, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
5 tasks
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 13, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 19, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 19, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 21, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
5 tasks
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
1. cherry-pick [Improvement](brpc) Using a thread pool for RPC service avoiding std::mutex block brpc::bthread (apache#16639) 2. cherry-pick [fix](brpc) solve bthread hang problem (apache#17206) 3. cherry-pick [deps](libhdfs) add official hadoop libhdfs for x86 (apache#17435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #16634
Problem summary
mainly include:
主要包括
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...