Skip to content

[Improvement][TaskLog] Unified task log#7831

Merged
lenboo merged 5 commits intoapache:devfrom
caishunfeng:master_logger
Jan 7, 2022
Merged

[Improvement][TaskLog] Unified task log#7831
lenboo merged 5 commits intoapache:devfrom
caishunfeng:master_logger

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng commented Jan 5, 2022

Purpose of the pull request

this pr close #7661
relative pr #7665 #7423

Brief change log

log file: /logs/20220105/4091837859296_1-1-1.log
log format: [INFO] 2022-01-05 23:51:26.770 [taskAppId=TASK-20220105-4091837859296_1-1-1] TaskLogLogger-class org.apache.dolphinscheduler.server.master.runner.task.CommonTaskProcessor:[123]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #7831 (f4e294e) into dev (7fd94ff) will decrease coverage by 0.01%.
The diff coverage is 20.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #7831      +/-   ##
============================================
- Coverage     41.03%   41.01%   -0.02%     
+ Complexity     3695     3694       -1     
============================================
  Files           637      637              
  Lines         27025    27034       +9     
  Branches       3063     3068       +5     
============================================
- Hits          11089    11088       -1     
- Misses        14867    14878      +11     
+ Partials       1069     1068       -1     
Impacted Files Coverage Δ
...che/dolphinscheduler/common/utils/LoggerUtils.java 0.00% <0.00%> (ø)
...inscheduler/server/master/config/MasterConfig.java 69.76% <ø> (+0.20%) ⬆️
...server/master/runner/task/CommonTaskProcessor.java 4.47% <0.00%> (ø)
...ver/master/runner/task/ConditionTaskProcessor.java 5.19% <0.00%> (+0.13%) ⬆️
...ver/master/runner/task/DependentTaskProcessor.java 5.33% <0.00%> (ø)
...er/server/master/runner/task/SubTaskProcessor.java 6.09% <0.00%> (-0.40%) ⬇️
...server/master/runner/task/SwitchTaskProcessor.java 2.58% <0.00%> (ø)
...che/dolphinscheduler/server/log/TaskLogFilter.java 0.00% <0.00%> (ø)
...pache/dolphinscheduler/spi/task/TaskConstants.java 0.00% <ø> (ø)
...eduler/server/worker/runner/TaskExecuteThread.java 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd94ff...f4e294e. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

25.4% 25.4% Coverage
1.7% 1.7% Duplication

Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit e4cdd82 into apache:dev Jan 7, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 10, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 10, 2022
caishunfeng pushed a commit to caishunfeng/dolphinscheduler that referenced this pull request Jan 10, 2022
caishunfeng added a commit that referenced this pull request Jan 11, 2022
* [cherry-pick][Improvement][TaskLog] Unified task log #7831

* [cherry-pick][Improvement][TaskLog] Unified task log #7831

* fix thread name

Co-authored-by: caishunfeng <534328519@qq.com>
@caishunfeng caishunfeng deleted the master_logger branch February 17, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-server] memory leak of logger in worker

3 participants