Skip to content

[Bug] [dolphinscheduler-server] memory leak of logger #7661#7665

Merged
lenboo merged 19 commits intoapache:2.0.2-preparefrom
zwZjut:2.0.2-prepare#7661
Dec 28, 2021
Merged

[Bug] [dolphinscheduler-server] memory leak of logger #7661#7665
lenboo merged 19 commits intoapache:2.0.2-preparefrom
zwZjut:2.0.2-prepare#7661

Conversation

@zwZjut
Copy link
Copy Markdown
Contributor

@zwZjut zwZjut commented Dec 28, 2021

Purpose of the pull request

#7661

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

zwZjut and others added 17 commits December 13, 2021 10:24
@zwZjut
[Feature][dolphinscheduler-api] parse traceId in http header for Cros…
2f26f5f 
…s system delivery to #7237 (#7238)

* to #7237

* rerun test

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
chery-pick 05aef27 and handle conflicts
4a90027
@zwZjut
to #7065: fix ExecutorService and schedulerService (#7072)
9c45a4f 
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
[Feature][dolphinscheduler-api] access control of taskDefinition and …
6897517 
…taskInstance in project to #7081  (#7082)

* to #7081

* fix #7081

* to #7081

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
chery-pick 8ebe060 and handle conflicts
6f491e4
@zwZjut
cherry-pick 1f18444 and handle conflicts
1bcde64
@zwZjut @CalvinKirs
fix #6807: dolphinscheduler.zookeeper.env_vars - > dolphinscheduler.r…
9cddad9 
…egistry.env_vars (#6808)

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
Co-authored-by: Kirs <acm_master@163.com>
@zwZjut
add default constructor (#6780)
70ec96a 
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
@zwZjut
to #7108 (#7109)
c79acd1
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
6c29e89 
…duler into 2.0.2-prepare
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
3367f56 
…duler into 2.0.2-prepare
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
9737335 
…duler into 2.0.2-prepare
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
8842fe6 
…duler into 2.0.2-prepare
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
ada2a71 
…duler into 2.0.2-prepare
add conf && pick #7562 to worker
b10ecd9
Merge branch '2.0.2-prepare' of https://github.com/zwZjut/dolphinsche…
9fca00d 
…duler into 2.0.2-prepare
to #7661
6abd285
@zwZjut zwZjut changed the base branch from dev to 2.0.2-prepare December 28, 2021 04:18
caishunfeng
caishunfeng approved these changes Dec 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 28, 2021 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (2.0.2-prepare@df40cdc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...phinscheduler/server/log/TaskLogDiscriminator.java 73.33% 1 Missing and 3 partials ⚠️
...ver/master/runner/task/ConditionTaskProcessor.java 0.00% 4 Missing ⚠️
...che/dolphinscheduler/server/log/TaskLogFilter.java 71.42% 0 Missing and 2 partials ⚠️
...r/server/master/runner/task/BaseTaskProcessor.java 0.00% 1 Missing ⚠️
...eduler/server/worker/runner/TaskExecuteThread.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             2.0.2-prepare    #7665   +/-   ##
================================================
  Coverage                 ?   31.36%           
  Complexity               ?     1555           
================================================
  Files                    ?      433           
  Lines                    ?    14783           
  Branches                 ?     1480           
================================================
  Hits                     ?     4637           
  Misses                   ?     9687           
  Partials                 ?      459

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 28, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 24 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 319 Code Smells

16.5% 16.5% Coverage
0.9% 0.9% Duplication

lenboo
lenboo approved these changes Dec 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit 32fb3f8 into apache:2.0.2-prepare Dec 28, 2021
This was referenced Jan 5, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@lenboo lenboo lenboo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zwZjut @codecov-commenter @caishunfeng @lenboo