Skip to content

[Improvement][API][num-6] TaskDefinition releaseTaskDefinition#6965

Merged
brave-lee merged 6 commits intoapache:devfrom
yikeshiguang:dev_20211123
Nov 23, 2021
Merged

[Improvement][API][num-6] TaskDefinition releaseTaskDefinition#6965
brave-lee merged 6 commits intoapache:devfrom
yikeshiguang:dev_20211123

Conversation

@yikeshiguang
Copy link
Copy Markdown
Contributor

The online and offline tasks correspond to the flag field. When online, there is a resource dependency to judge whether the resource is available. #6772

@zhuangchong zhuangchong added the first time contributor First-time contributor label Nov 23, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #6965 (fec96fc) into dev (e6239e8) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head fec96fc differs from pull request most recent head 8b0ebb2. Consider uploading reports for the commit 8b0ebb2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6965      +/-   ##
============================================
- Coverage     32.90%   32.75%   -0.16%     
+ Complexity     1625     1618       -7     
============================================
  Files           432      432              
  Lines         14379    14379              
  Branches       1446     1446              
============================================
- Hits           4732     4710      -22     
- Misses         9191     9214      +23     
+ Partials        456      455       -1     
Impacted Files Coverage Δ
...he/dolphinscheduler/common/enums/SqoopJobType.java 0.00% <0.00%> (-88.89%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 47.27% <0.00%> (-7.28%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...inscheduler/common/task/sqoop/SqoopParameters.java 74.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6239e8...8b0ebb2. Read the comment docs.

brave-lee
brave-lee previously approved these changes Nov 23, 2021
Copy link
Copy Markdown
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@brave-lee brave-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job

@brave-lee brave-lee merged commit 360464e into apache:dev Nov 23, 2021
brave-lee pushed a commit to brave-lee/dolphinscheduler that referenced this pull request Dec 2, 2021
…e#6965)

* finished releaseTaskDefinition

* add releaseTaskDefinition unit test

* change import

* add import

* bug fix

* change import

Co-authored-by: 时光 <caizhedong@cai-inc.com>
lenboo pushed a commit that referenced this pull request Dec 3, 2021
* pick-6863

* [Improvement][API][num-7] add task delete check (#6887)

* upgrade add sub_process

* add interface method

* add interface method

* fix ut

* add task delete check

* add task delete check

* [Improvement][API][num-5] The workflow of the main table version is not allowed to be deleted (#6893)

* feature:deleteProcessDefinitionVersion

* pref:delete duplicate enum definition

Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>

* [DS-6931][fix] swagger failed to start due to improper use of request param annotation (#6933)

Co-authored-by: eye <eye.gu@aloudata.com>

* [fix #6878]  implement interface queryUpstreamRelation queryDownstreamRelation and add UT (#6888)

* fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT

* fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT

* fix: #6878, add license

* fix: #6878, code style

* fix: #6878, code style

* fix: #6878, fix Duplication

* fix: #6878

* fix: #6878 , fix style

* to #6878: fix style

* to #6878: fix style

* to #6878: add buildTaskDefinition to overwrite equals and hashCode

Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>

* [Improvement][API][num-6] TaskDefinition  releaseTaskDefinition (#6965)

* finished releaseTaskDefinition

* add releaseTaskDefinition unit test

* change import

* add import

* bug fix

* change import

Co-authored-by: 时光 <caizhedong@cai-inc.com>

* pick-6966

* update task_definition_log field typ (#6967)

* update task_definition_log field typ

update task_definition_log  field task_params type,modify text to longtext to be consistent with the main table

* update t_ds_task_definition_log field task_params

update t_ds_task_definition_log field task_params

* pick-6970

* pick-6977

* pick-6984

* add processDefinition releaseWorkflowAndSchedule (#7044)

* [Improvement][API][num-1] save schedule when workflow is offline in interface 'createEmptyProcessDefinition' (#7047)

* [Improvement] save schedule when workflow is offline

* [Improvement] rollback transactional when creating/updating schedule failed.

* [Improvement] resolve merge conflict

* [Improvement] do not set projectName and processDefinitionName when saving schedule

* [Improvement] do not set projectName and processDefinitionName when saving schedule

Co-authored-by: edward-yang <yangjianh210@gmail.com>

* pick-7053

* pick-7098

* pick add 6772 relation code

* fix ut

Co-authored-by: Jeff Zhan <360400325@qq.com>
Co-authored-by: 北笙 <“zhanqian@cai-inc.com”>
Co-authored-by: ououtt <734164350@qq.com>
Co-authored-by: eye <eye.gu@aloudata.com>
Co-authored-by: zwZjut <zw15068835817@163.com>
Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
Co-authored-by: 时光 <41109695+yikeshiguang@users.noreply.github.com>
Co-authored-by: 时光 <caizhedong@cai-inc.com>
Co-authored-by: zhang <60912722+boy-xiaozhang@users.noreply.github.com>
Co-authored-by: EdwardYang <yangjianh210@126.com>
Co-authored-by: edward-yang <yangjianh210@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants