[fix #6878] implement interface queryUpstreamRelation queryDownstreamRelation and add UT#6888
Merged
brave-lee merged 13 commits intoapache:devfrom Nov 22, 2021
zwZjut:#6878
Merged
[fix #6878] implement interface queryUpstreamRelation queryDownstreamRelation and add UT#6888brave-lee merged 13 commits intoapache:devfrom zwZjut:#6878
brave-lee merged 13 commits intoapache:devfrom
zwZjut:#6878
Conversation
added 3 commits
November 17, 2021 17:09
…Relation and add UT
…Relation and add UT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #6888 +/- ##
============================================
- Coverage 33.07% 32.84% -0.23%
+ Complexity 1626 1623 -3
============================================
Files 433 432 -1
Lines 14365 14377 +12
Branches 1437 1446 +9
============================================
- Hits 4751 4722 -29
- Misses 9158 9200 +42
+ Partials 456 455 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brave-lee
reviewed
Nov 18, 2021
...c/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 19, 2021 12:58
kezhenxu94
reviewed
Nov 19, 2021
.../test/java/org/apache/dolphinscheduler/api/controller/ProcessTaskRelationControllerTest.java
Show resolved
Hide resolved
brave-lee
reviewed
Nov 19, 2021
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
brave-lee
pushed a commit
to brave-lee/dolphinscheduler
that referenced
this pull request
Dec 2, 2021
…streamRelation and add UT (apache#6888) * fix: apache#6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: apache#6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: apache#6878, add license * fix: apache#6878, code style * fix: apache#6878, code style * fix: apache#6878, fix Duplication * fix: apache#6878 * fix: apache#6878 , fix style * to apache#6878: fix style * to apache#6878: fix style * to apache#6878: add buildTaskDefinition to overwrite equals and hashCode Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com>
lenboo
pushed a commit
that referenced
this pull request
Dec 3, 2021
* pick-6863 * [Improvement][API][num-7] add task delete check (#6887) * upgrade add sub_process * add interface method * add interface method * fix ut * add task delete check * add task delete check * [Improvement][API][num-5] The workflow of the main table version is not allowed to be deleted (#6893) * feature:deleteProcessDefinitionVersion * pref:delete duplicate enum definition Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> * [DS-6931][fix] swagger failed to start due to improper use of request param annotation (#6933) Co-authored-by: eye <eye.gu@aloudata.com> * [fix #6878] implement interface queryUpstreamRelation queryDownstreamRelation and add UT (#6888) * fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: #6878, implement interface queryUpstreamRelation queryDownstreamRelation and add UT * fix: #6878, add license * fix: #6878, code style * fix: #6878, code style * fix: #6878, fix Duplication * fix: #6878 * fix: #6878 , fix style * to #6878: fix style * to #6878: fix style * to #6878: add buildTaskDefinition to overwrite equals and hashCode Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com> * [Improvement][API][num-6] TaskDefinition releaseTaskDefinition (#6965) * finished releaseTaskDefinition * add releaseTaskDefinition unit test * change import * add import * bug fix * change import Co-authored-by: 时光 <caizhedong@cai-inc.com> * pick-6966 * update task_definition_log field typ (#6967) * update task_definition_log field typ update task_definition_log field task_params type,modify text to longtext to be consistent with the main table * update t_ds_task_definition_log field task_params update t_ds_task_definition_log field task_params * pick-6970 * pick-6977 * pick-6984 * add processDefinition releaseWorkflowAndSchedule (#7044) * [Improvement][API][num-1] save schedule when workflow is offline in interface 'createEmptyProcessDefinition' (#7047) * [Improvement] save schedule when workflow is offline * [Improvement] rollback transactional when creating/updating schedule failed. * [Improvement] resolve merge conflict * [Improvement] do not set projectName and processDefinitionName when saving schedule * [Improvement] do not set projectName and processDefinitionName when saving schedule Co-authored-by: edward-yang <yangjianh210@gmail.com> * pick-7053 * pick-7098 * pick add 6772 relation code * fix ut Co-authored-by: Jeff Zhan <360400325@qq.com> Co-authored-by: 北笙 <“zhanqian@cai-inc.com”> Co-authored-by: ououtt <734164350@qq.com> Co-authored-by: eye <eye.gu@aloudata.com> Co-authored-by: zwZjut <zw15068835817@163.com> Co-authored-by: honghuo.zw <honghuo.zw@alibaba-inc.com> Co-authored-by: 时光 <41109695+yikeshiguang@users.noreply.github.com> Co-authored-by: 时光 <caizhedong@cai-inc.com> Co-authored-by: zhang <60912722+boy-xiaozhang@users.noreply.github.com> Co-authored-by: EdwardYang <yangjianh210@126.com> Co-authored-by: edward-yang <yangjianh210@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
#6878
#6772
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: