Skip to content

Add Alibaba Druid to NOTICE file#6488

Merged
lenboo merged 1 commit intoapache:devfrom
CalvinKirs:#druid_notice_miss
Oct 11, 2021
Merged

Add Alibaba Druid to NOTICE file#6488
lenboo merged 1 commit intoapache:devfrom
CalvinKirs:#druid_notice_miss

Conversation

@CalvinKirs
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs commented Oct 10, 2021

@CalvinKirs CalvinKirs requested a review from lenboo October 10, 2021 15:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #6488 (6ff55f9) into dev (eb21a17) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 6ff55f9 differs from pull request most recent head e873e6b. Consider uploading reports for the commit e873e6b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #6488      +/-   ##
============================================
- Coverage     38.67%   38.62%   -0.05%     
+ Complexity     3209     3206       -3     
============================================
  Files           645      645              
  Lines         25729    25729              
  Branches       2786     2786              
============================================
- Hits           9950     9938      -12     
- Misses        14860    14874      +14     
+ Partials        919      917       -2
Impacted Files Coverage Δ
...olphinscheduler/rpc/remote/NettyClientHandler.java 41.86% <0.00%> (-9.31%) ⬇️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 39.00% <0.00%> (-5.68%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.35% <0.00%> (-1.70%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb21a17...e873e6b. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

zhongjiajie
zhongjiajie approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhuangchong
zhuangchong approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

ruanwenjun
ruanwenjun approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lenboo
lenboo approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit ea49353 into apache:dev Oct 11, 2021
lenboo pushed a commit that referenced this pull request Oct 11, 2021
@CalvinKirs @caishunfeng
[cherry-pick #6484 #6488][MasterServer] upgrade the druid and mysql c…
2460eb6 
…onnector version (#6494)

* [DS-6483][MasterServer] upgrade the druid and mysql connector version (#6484)

* [DS-6483][MasterServer] upgrade the druid and mysql connector version

* remove mysql connector in known-dependencies.txt

* change mysql connector version to 8.0.16

Co-authored-by: caishunfeng <534328519@qq.com>

* Add Alibaba Druid to NOTICE file (#6488)

Co-authored-by: wind <caishunfeng@users.noreply.github.com>
Co-authored-by: caishunfeng <534328519@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@lenboo lenboo lenboo approved these changes

@zhuangchong zhuangchong zhuangchong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@CalvinKirs @codecov-commenter @zhongjiajie @ruanwenjun @lenboo @zhuangchong