[DS-6483][MasterServer] upgrade the druid and mysql connector version#6484
Merged
lenboo merged 3 commits intoapache:devfrom Oct 10, 2021
Merged
[DS-6483][MasterServer] upgrade the druid and mysql connector version#6484lenboo merged 3 commits intoapache:devfrom
lenboo merged 3 commits intoapache:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6484 +/- ##
=========================================
Coverage 38.64% 38.64%
Complexity 3206 3206
=========================================
Files 645 645
Lines 25729 25729
Branches 2786 2786
=========================================
Hits 9942 9942
Misses 14870 14870
Partials 917 917
Continue to review full report at Codecov.
|
Member
|
Good job! |
zhongjiajie
previously approved these changes
Oct 10, 2021
| druidDataSource.setTestWhileIdle(PropertyUtils.getBoolean(Constants.SPRING_DATASOURCE_TEST_WHILE_IDLE, true)); | ||
| druidDataSource.setTestOnBorrow(PropertyUtils.getBoolean(Constants.SPRING_DATASOURCE_TEST_ON_BORROW, true)); | ||
| druidDataSource.setTestOnReturn(PropertyUtils.getBoolean(Constants.SPRING_DATASOURCE_TEST_ON_RETURN, true)); | ||
| druidDataSource.setTestOnReturn(PropertyUtils.getBoolean(Constants.SPRING_DATASOURCE_TEST_ON_RETURN, false)); |
Member
There was a problem hiding this comment.
Should we add comment to desc why we have to set it to fasle?
Contributor
Author
There was a problem hiding this comment.
you can see the druid config and comment at datasource.properties.
CalvinKirs
reviewed
Oct 10, 2021
| mybatis-plus-core-3.2.0.jar | ||
| mybatis-plus-extension-3.2.0.jar | ||
| mybatis-spring-2.0.2.jar | ||
| mysql-connector-java-8.0.24.jar |
Member
There was a problem hiding this comment.
don't need to add this dependency.
druid's some licenses not add.
Contributor
Author
There was a problem hiding this comment.
ok, I will fix it.
Member
There was a problem hiding this comment.
This should not be added, it's GPL license.
Member
There was a problem hiding this comment.
yup, his dependency scope tests. so we don't need to add it
CalvinKirs
reviewed
Oct 10, 2021
| <mybatis.spring.version>2.0.1</mybatis.spring.version> | ||
| <cron.utils.version>5.0.5</cron.utils.version> | ||
| <druid.version>1.1.22</druid.version> | ||
| <druid.version>1.2.4</druid.version> |
Member
There was a problem hiding this comment.
The compatibility of the druid version and the sql driver version should be noted
Member
There was a problem hiding this comment.
This problem may need to be reflected in the document
Contributor
Author
There was a problem hiding this comment.
ok, I will change related document if this pr is merged.
|
Kudos, SonarCloud Quality Gate passed! |
CalvinKirs
approved these changes
Oct 10, 2021
Member
|
I will fix the missing Notice issue. |
lenboo
pushed a commit
that referenced
this pull request
Oct 11, 2021
…onnector version (#6494) * [DS-6483][MasterServer] upgrade the druid and mysql connector version (#6484) * [DS-6483][MasterServer] upgrade the druid and mysql connector version * remove mysql connector in known-dependencies.txt * change mysql connector version to 8.0.16 Co-authored-by: caishunfeng <534328519@qq.com> * Add Alibaba Druid to NOTICE file (#6488) Co-authored-by: wind <caishunfeng@users.noreply.github.com> Co-authored-by: caishunfeng <534328519@qq.com>
3 tasks
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler-website
that referenced
this pull request
Oct 13, 2021
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler-website
that referenced
this pull request
Oct 14, 2021
lenboo
pushed a commit
to apache/dolphinscheduler-website
that referenced
this pull request
Oct 16, 2021
* Copy doc from 1.3.8 to dev * Change dev default page to quick start * Sperate User Munal to multiple file * Combine doc page parameter and parameters-intro * Move flink call and open api to user_guide * Rename directory user_guide to guide * Upgrade mysql connector to 8.0.16 ref: apache/dolphinscheduler#6484 * Add sub directory install for `user_doc/guide` * Add directory architecture * Add directory for integration * Fix quick start link * Fix en-us install link * Sperate datasource to multiple files * Remove TODO marked * Change TOD order and name * Union globalParam and param to directory parameter * Delete file parameter * Add task conditions * Correct task conditions keyword `Conditions` * Add task Pigeon doc
davidzollo
pushed a commit
to davidzollo/dolphinscheduler-website
that referenced
this pull request
Dec 17, 2021
* Copy doc from 1.3.8 to dev * Change dev default page to quick start * Sperate User Munal to multiple file * Combine doc page parameter and parameters-intro * Move flink call and open api to user_guide * Rename directory user_guide to guide * Upgrade mysql connector to 8.0.16 ref: apache/dolphinscheduler#6484 * Add sub directory install for `user_doc/guide` * Add directory architecture * Add directory for integration * Fix quick start link * Fix en-us install link * Sperate datasource to multiple files * Remove TODO marked * Change TOD order and name * Union globalParam and param to directory parameter * Delete file parameter * Add task conditions * Correct task conditions keyword `Conditions` * Add task Pigeon doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr close #6483
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: