Skip to content

[Feature][DataQuality] Add data quality module #4830

Merged
CalvinKirs merged 21 commits intoapache:data_quality_designfrom
zixi0825:dqs_module
Apr 11, 2021
Merged

[Feature][DataQuality] Add data quality module #4830
CalvinKirs merged 21 commits intoapache:data_quality_designfrom
zixi0825:dqs_module

Conversation

@zixi0825
Copy link
Copy Markdown
Member

What is the purpose of the pull request

*This pull request adds data quality module #4829 *

Brief change log

  • Add data quality module
  • Modify pom.xml in root path
  • Modify dolphinscheduler-binary.xml

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 21, 2021

Codecov Report

Merging #4830 (b8acd7f) into data_quality_design (14d49bc) will increase coverage by 0.03%.
The diff coverage is 49.34%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             data_quality_design    #4830      +/-   ##
=========================================================
+ Coverage                  45.01%   45.04%   +0.03%     
- Complexity                  3376     3437      +61     
=========================================================
  Files                        537      558      +21     
  Lines                      23077    23381     +304     
  Branches                    2691     2714      +23     
=========================================================
+ Hits                       10387    10532     +145     
- Misses                     11762    11896     +134     
- Partials                     928      953      +25     
Impacted Files Coverage Δ Complexity Δ
...pache/dolphinscheduler/data/quality/Constants.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...scheduler/data/quality/DataQualityApplication.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...r/data/quality/exception/DataQualityException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ler/data/quality/flow/connector/HiveConnector.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ata/quality/flow/executor/SparkSqlExecuteTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...lphinscheduler/data/quality/utils/StringUtils.java 0.00% <0.00%> (ø) 2.00 <2.00> (?)
...hinscheduler/data/quality/utils/Preconditions.java 20.00% <20.00%> (ø) 1.00 <1.00> (?)
...dolphinscheduler/data/quality/utils/JdbcUtils.java 37.50% <37.50%> (ø) 2.00 <2.00> (?)
...dolphinscheduler/data/quality/utils/JsonUtils.java 42.10% <42.10%> (ø) 2.00 <2.00> (?)
.../data/quality/configuration/ExecutorParameter.java 45.00% <45.00%> (ø) 5.00 <5.00> (?)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d49bc...b8acd7f. Read the comment docs.

@CalvinKirs CalvinKirs added the Waiting for user feedback Waiting for feedback from issue/PR author label Mar 11, 2021
@CalvinKirs CalvinKirs added feature new feature and removed Waiting for user feedback Waiting for feedback from issue/PR author labels Mar 13, 2021
@zixi0825 zixi0825 changed the title [Feature][DataQuality] add data quality module [Feature][DataQuality] Add data quality module Mar 20, 2021
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

54.8% 54.8% Coverage
2.2% 2.2% Duplication

@CalvinKirs CalvinKirs added the Waiting for review Waiting for review label Apr 7, 2021
Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs
Copy link
Copy Markdown
Member

@ruanwenjun hi please take a look

@ruanwenjun
Copy link
Copy Markdown
Member

@CalvinKirs Looks good to me.

@CalvinKirs CalvinKirs merged commit 0c6ffdb into apache:data_quality_design Apr 11, 2021
@davidzollo davidzollo removed the Waiting for review Waiting for review label Apr 18, 2021
caishunfeng pushed a commit that referenced this pull request Jan 27, 2022
* add data quality module

* add license

* add package configuration in dist pom

* fix license and jar import bug

* replace apache/skywalking-eyes@9bd5feb SHA

* refacotr jbdc-connector and writer

* modify parameter name in HiveConnector

* fix checkstyle error

* fix checkstyle error in dolphinschesuler-dist

* fix checkstyle error in dolphinschesuler-dist

* fix checkstyle error in dolphinschesuler-dist

* fix duplicate code bug

* fix code style bug

* fix code smells

* add dq relevant enums and parameter

* replace apache/skywalking-eyes@9bd5feb SHA

* fix Constants bug

* remove the unused class

* add unit test

* fix code style error

* add unit test

* refactor data quality common entity

* fix code style error

* add unit test

* close e2e test

* fix code smell bug

* modify dataquality enum value to 14 in TaskType

* add data qualtiy task

* update

* add getDatasourceOptions interface

* fix checkstyle

* close e2e test

* add data quality task ui

* update skywalking-eyes SHA

* fix style

* fix eslint error

* fix eslint error

* test e2e

* add unit test and alter dataquality task result

* fix checkstyle

* fix process service test error

* add unit test and fix code smells

* fix checkstyle error

* fix unit test error

* fix checkstyle error

* change execute sql type name

* revert ui pom.xml

* fix data quality task error

* fix checkstyle error

* fix dq task src_connector_type ui select bug

* fix spark rw postgresql bug

* change mysql driver scope

* fix form-create json bug

* fix code smell

* fix DolphinException Bug

* fix ui validate rule and Alert title

* fix target connection param bug

* fix threshold validate change

* add rule input entry index

* change statistic_comparison_check logic

* remove check type change

* add DateExpressionReplaceUtil

* fix null point expetion

* fix null point expetion

* fix test error

* add more sql driver

* fix test error and remove DateExprReplaceUtil

* add get datasource tables and columns

* add get datasource tables and columns

* remove hive-jdbc in pom.xml

* fix code smells

* update sql

* change the pom.xml

* optimize multi_table_accuracy ui

* fix v-show error

* fix code smells

* update sql

* [Feature][DataQuality] Add data quality task ui (#5054)

* add data quality task ui

* update skywalking-eyes SHA

* fix style

* fix eslint error

* fix eslint error

* test e2e

* fix dq task src_connector_type ui select bug

* fix threshold validate change

* remove check type change

* add get datasource tables and columns

* optimize multi_table_accuracy ui

* fix v-show error

* fix code smells

Co-authored-by: sunchaohe <sunzhaohe@linklogis.com>

* [Feature][DataQuality] Add data quality module  (#4830)

* add data quality module

* add license

* add package configuration in dist pom

* fix license and jar import bug

* replace apache/skywalking-eyes@9bd5feb SHA

* refacotr jbdc-connector and writer

* modify parameter name in HiveConnector

* fix checkstyle error

* fix checkstyle error in dolphinschesuler-dist

* fix checkstyle error in dolphinschesuler-dist

* fix checkstyle error in dolphinschesuler-dist

* fix duplicate code bug

* fix code style bug

* fix code smells

* update

* close e2e test

* fix spark rw postgresql bug

* change mysql driver scope

* add more sql driver

* remove hive-jdbc in pom.xml

* change the pom.xml

Co-authored-by: sunchaohe <sunzhaohe@linklogis.com>

* [Feature][DataQuality] Add data quality task backend (#4883)

* add dq relevant enums and parameter

* replace apache/skywalking-eyes@9bd5feb SHA


Co-authored-by: sunchaohe <sunzhaohe@linklogis.com>

* refactor data_quality_module

* add header license

* data quality module refactor

* fix unit test error

* fix checkstyle error

* fix unit test error

* fix checkstyle error

* fix unit test error

* fix code smell

* fix check style

* fix unit test error

* task statistics value add unique code

* fix unit test error

* fix checkstyle error

* fix checkstyle

* fix security hotspot

* fix unit test error

* fix security hotspot

* fix check

* add data quality task error handling

* fix unit test error

* add unit test

* add unit test

* optimize data quality result alert

* fix unit test

* fix sql script error

* fix bug

* update sql script

* fix checkstyle

* add license

* fix checkstyle

* fix checkstyle

* fix unit test

* add jacoco dependencies

* fix unit test

* fix unit test

* add jacoco dependencies

* add unit test

* add unit test

* add license

* fix checkstyle

* fix pom

* fix checkstyle

* fix checkstyle

* merge dev

* fix ui error

* fix pom error

* fix pom error

* fix test error

* fix test error

* mssql-jdbc exclude azure-keyvault

* fix test error

* merge dev and add unit test

* add notes

* rollback the CollectionUtils

* fix

* update sql

* fix

* fix

* fix query rule page error

* change dq.jar path

* fix sql error

* fix ui error

* fix(dq): jar path&task enum description

* add notes on DataQualityApplication

* fix dq result jump error

* fix(ui): page condition

* feat(ui): add show error output path

* change version

* remove all chinese word in sql

* merge

Co-authored-by: sunchaohe <sunzhaohe@linklogis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants