Skip to content

[Feature][DataQuality] Add Data quality Module #4283#6718

Merged
caishunfeng merged 200 commits intoapache:devfrom
zixi0825:data_quality_design
Jan 27, 2022
Merged

[Feature][DataQuality] Add Data quality Module #4283#6718
caishunfeng merged 200 commits intoapache:devfrom
zixi0825:data_quality_design

Conversation

@zixi0825
Copy link
Copy Markdown
Member

@zixi0825 zixi0825 commented Nov 6, 2021

Purpose of the pull request

This pull request add data quality module, the design can be viewed in #4283

davidzollo
davidzollo previously approved these changes Jan 23, 2022
Copy link
Copy Markdown
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for your great job, such a big feature
LGTM
+1

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's a big feature for DS. Gread job!

@caishunfeng
Copy link
Copy Markdown
Contributor

I have no other questions.
PTAL @lenboo

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 68 Code Smells

39.6% 39.6% Coverage
7.8% 7.8% Duplication

Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@zixi0825 zixi0825 requested a review from kezhenxu94 January 27, 2022 06:20
@kezhenxu94 kezhenxu94 dismissed their stale review January 27, 2022 07:01

Have no time for now to review, dismiss the requested changes

@caishunfeng caishunfeng merged commit 4ba6d66 into apache:dev Jan 27, 2022
Copy link
Copy Markdown
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo
Copy link
Copy Markdown
Contributor

Great job

@rusonding
Copy link
Copy Markdown
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants