Fix kill yarn job error when failover caused by doesn't set ProcessDefinition#10948
Merged
ruanwenjun merged 1 commit intoapache:devfrom Jul 13, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10948 +/- ##
============================================
- Coverage 40.31% 40.29% -0.03%
+ Complexity 4858 4857 -1
============================================
Files 943 943
Lines 36994 37015 +21
Branches 4059 4062 +3
============================================
+ Hits 14914 14915 +1
- Misses 20578 20593 +15
- Partials 1502 1507 +5
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
SnowMoon-Dev
pushed a commit
to SnowMoon-Dev/dolphinscheduler
that referenced
this pull request
Jul 14, 2022
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Aug 1, 2022
* Fix taskInstance's host is not worker nettyServer address (apache#10926) * Fix taskInstance's host is not worker nettyServer address * Remove unnecessary mock (cherry picked from commit df0416c) * Fix kill yarn job error when failover caused by doesn't set ProcessDefinition (apache#10948) (cherry picked from commit b245e7c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Due to we don't set the processDefinition so will get NPE when get task log.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: