Skip to content

Fix taskInstance's host is not worker nettyServer address#10926

Merged
caishunfeng merged 2 commits intoapache:devfrom
ruanwenjun:dev_wenjun_fixTaskInstanceHostBug
Jul 13, 2022
Merged

Fix taskInstance's host is not worker nettyServer address#10926
caishunfeng merged 2 commits intoapache:devfrom
ruanwenjun:dev_wenjun_fixTaskInstanceHostBug

Conversation

@ruanwenjun
Copy link
Copy Markdown
Member

Purpose of the pull request

This bug is imported by #10886

Brief change log

  • Set the worker address from message's senderAddress

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

caishunfeng
caishunfeng previously approved these changes Jul 13, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng merged commit df0416c into apache:dev Jul 13, 2022
SnowMoon-Dev pushed a commit to SnowMoon-Dev/dolphinscheduler that referenced this pull request Jul 14, 2022
* Fix taskInstance's host is not worker nettyServer address

* Remove unnecessary mock
@ruanwenjun ruanwenjun added this to the 3.0.0-release milestone Jul 14, 2022
ruanwenjun added a commit that referenced this pull request Jul 19, 2022
* Fix taskInstance's host is not worker nettyServer address

* Remove unnecessary mock

(cherry picked from commit df0416c)
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Aug 1, 2022
* Fix taskInstance's host is not worker nettyServer address (apache#10926)

* Fix taskInstance's host is not worker nettyServer address

* Remove unnecessary mock

(cherry picked from commit df0416c)

* Fix kill yarn job error when failover caused by doesn't set ProcessDefinition (apache#10948)

(cherry picked from commit b245e7c)
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.31%. Comparing base (427c585) to head (c6798a2).
⚠️ Report is 2027 commits behind head on dev.

Files with missing lines Patch % Lines
...master/processor/TaskExecuteResponseProcessor.java 0.00% 2 Missing ⚠️
.../master/processor/TaskExecuteRunningProcessor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #10926      +/-   ##
============================================
- Coverage     40.31%   40.31%   -0.01%     
  Complexity     4858     4858              
============================================
  Files           943      943              
  Lines         36994    37009      +15     
  Branches       4059     4061       +2     
============================================
+ Hits          14914    14920       +6     
- Misses        20578    20587       +9     
  Partials       1502     1502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants