[Improve] Enhance complement function transformation by hstdream · Pull Request #10376 · apache/dolphinscheduler

hstdream · 2022-06-08T16:41:50Z

caishunfeng

I think it's not a complete pr and we should add the auto generate date tool on ui.

lenboo · 2022-06-09T11:17:16Z

I think we can keep two complement data way in the same time.

� Conflicts: � dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java

codecov-commenter · 2022-06-10T00:50:54Z

Codecov Report

❌ Patch coverage is 32.57143% with 118 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.53%. Comparing base (b0d9d3f) to head (e13fb00).
⚠️ Report is 2221 commits behind head on dev.

Files with missing lines	Patch %	Lines
...cheduler/api/service/impl/ExecutorServiceImpl.java	47.86%	41 Missing and 20 partials ⚠️
.../server/master/runner/WorkflowExecuteRunnable.java	0.00%	50 Missing ⚠️
...pache/dolphinscheduler/service/corn/CronUtils.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #10376      +/-   ##
============================================
- Coverage     40.56%   40.53%   -0.04%     
- Complexity     4767     4772       +5     
============================================
  Files           877      877              
  Lines         35623    35701      +78     
  Branches       3945     3970      +25     
============================================
+ Hits          14452    14470      +18     
- Misses        19738    19787      +49     
- Partials       1433     1444      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…shielded for the time being. After the front-end code is merged, it is opened again

hstdream · 2022-06-10T01:41:18Z

@SbloodyS @caishunfeng

caishunfeng · 2022-06-11T03:33:19Z

LGTM overall. But we still have discussion in #10376 (comment)

Hi @SbloodyS you should give a approve because the change requested.

Sorry. I don't have strong opinion here. I just not quite sure about whether should give a approve since we still have unresolved discussions.

I gave approved. Do you have better suggestions? @zhongjiajie @caishunfeng

Sorry, I got it wrong, thanks for pointing it out.

caishunfeng

+1

zhongjiajie · 2022-06-11T07:34:24Z

LGTM overall. But we still have discussion in #10376 (comment)

Hi @SbloodyS you should give a approve because the change requested.

Sorry. I don't have strong opinion here. I just not quite sure about whether should give a approve since we still have unresolved discussions.

I gave approved. Do you have better suggestions? @zhongjiajie @caishunfeng

i think we better add some java doc on that constants value about why we set it to 100 instead of other value

hstdream · 2022-06-11T08:40:51Z

LGTM overall. But we still have discussion in #10376 (comment)

Hi @SbloodyS you should give a approve because the change requested.

Sorry. I don't have strong opinion here. I just not quite sure about whether should give a approve since we still have unresolved discussions.
I gave approved. Do you have better suggestions? @zhongjiajie @caishunfeng

i think we better add some java doc on that constants value about why we set it to 100 instead of other value
At that time, it was considered that the amount of data was too large, and then set the value of 100.

zhongjiajie

LGTM, waittig CI

sonarqubecloud · 2022-06-12T03:34:56Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

37.8% Coverage
0.0% Duplication

zhongjiajie · 2022-06-12T04:17:47Z

I restart the failing E2E/fileManageCI, and why this test failed often

[Improve] Enhance complement function transformation (apache#10376)

[Improvement] [Api & Master] Complement function transformation

05b070d

hstdream requested review from SbloodyS and caishunfeng as code owners June 8, 2022 16:41

lenboo reviewed Jun 9, 2022

View reviewed changes

Comment thread dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java Outdated

SbloodyS reviewed Jun 9, 2022

View reviewed changes

Comment thread ...er/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java

SbloodyS requested changes Jun 9, 2022

View reviewed changes

Comment thread dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java

caishunfeng reviewed Jun 9, 2022

View reviewed changes

Comment thread ...uler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java

SbloodyS assigned hstdream Jun 9, 2022

SbloodyS added improvement make more easy to user or prompt friendly backend labels Jun 9, 2022

hstdream added 5 commits June 9, 2022 20:17

Merge branch 'dev' of github.com:apache/dolphinscheduler into bushu_0609

d45b6fa

� Conflicts: � dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java

fix conflicts

aeedb99

fix conflicts

928140d

[Improvement] [Api & Master] Complement function transformation

a17e832

[Improvement] [Api & Master] Complement function transformation

d695694

Because the input parameters of runworkflow are modified, the E2E is …

96dfe2f

…shielded for the time being. After the front-end code is merged, it is opened again

hstdream requested a review from kezhenxu94 as a code owner June 10, 2022 01:19

hstdream requested review from SbloodyS and caishunfeng June 10, 2022 03:36

SbloodyS reviewed Jun 10, 2022

View reviewed changes

Comment thread ...nscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowE2ETest.java Outdated

Comment thread dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/corn/CronUtils.java Outdated

Fix e2e

5068931

SbloodyS reviewed Jun 10, 2022

View reviewed changes

Comment thread dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/corn/CronUtils.java Outdated

hstdream added 4 commits June 10, 2022 14:42

checkstyle fix.

4ab436e

e2e fix.

2701036

e2e fix.

0f62cda

e2e fix.

e1939a0

hstdream added 3 commits June 11, 2022 13:42

Merge remote-tracking branch 'upstream/dev' into bushu_0609

0fc9049

fix constants.

1b3007f

Merge remote-tracking branch 'origin/bushu_0609' into bushu_0609

405c458

hstdream dismissed SbloodyS’s stale review via 405c458 June 11, 2022 05:48

caishunfeng previously approved these changes Jun 11, 2022

View reviewed changes

add schedule time java doc.

511df01

hstdream dismissed caishunfeng’s stale review via 511df01 June 11, 2022 09:02

hstdream and others added 3 commits June 11, 2022 17:17

add schedule time java doc.

ac8efd9

add schedule time java doc.

187ccc6

Make comma to constants

6f5f4f8

zhongjiajie previously approved these changes Jun 12, 2022

View reviewed changes

hstdream added 2 commits June 12, 2022 11:07

Make comma to constants

60f7187

Merge remote-tracking branch 'origin/bushu_0609' into bushu_0609

e13fb00

hstdream dismissed zhongjiajie’s stale review via e13fb00 June 12, 2022 03:15

zhongjiajie mentioned this pull request Jun 12, 2022

[Bug] [e2e] Flake tests CI FileManager #10416

Closed

3 tasks

zhongjiajie removed the miss:docs missing documents in PR label Jun 12, 2022

zhongjiajie approved these changes Jun 12, 2022

View reviewed changes

zhongjiajie merged commit f6fea06 into apache:dev Jun 12, 2022

zhongjiajie changed the title ~~[Improvement] [Api & Master] Complement function transformation~~ [Improve] Enhance complement function transformation Jun 12, 2022

Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022

[Improve] Enhance complement function transformation (apache#10376)

e2c6c6c

Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022

Merge pull request #2 from WhaleOps/bushu_300

a22a979

[Improve] Enhance complement function transformation (apache#10376)

zhongjiajie added this to the 3.1.0-alpha milestone Jun 23, 2022

zhongjiajie mentioned this pull request Jun 23, 2022

[Bug][docs] Complement add docs. #10521

Merged

ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022

[Improve] Enhance complement function transformation (apache#10376)

eb19961

SbloodyS mentioned this pull request Feb 14, 2023

[Bug] [plugin] shell task plugin replace time variable with a wrong time #13543

Closed

3 tasks

Conversation

hstdream commented Jun 8, 2022 • edited by SbloodyS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caishunfeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lenboo commented Jun 9, 2022

Uh oh!

codecov-commenter commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hstdream commented Jun 10, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caishunfeng commented Jun 11, 2022

Uh oh!

caishunfeng left a comment

Choose a reason for hiding this comment

Uh oh!

zhongjiajie commented Jun 11, 2022

Uh oh!

hstdream commented Jun 11, 2022

Uh oh!

zhongjiajie left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 12, 2022

Uh oh!

zhongjiajie commented Jun 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hstdream commented Jun 8, 2022 •

edited by SbloodyS

Loading

codecov-commenter commented Jun 10, 2022 •

edited

Loading